aboutsummaryrefslogtreecommitdiffstats
path: root/fs/exec.c
diff options
context:
space:
mode:
authorOleg Nesterov <oleg@tv-sign.ru>2008-07-25 04:47:44 -0400
committerLinus Torvalds <torvalds@linux-foundation.org>2008-07-25 13:53:40 -0400
commitb564daf806d492dd4f7afe9b6c83b8d35d137669 (patch)
treefbd6d186035b9a0a270fca97887da5d6b106a60c /fs/exec.c
parent9d5b327bf198d2720666de958dcc2ae219d86952 (diff)
coredump: construct the list of coredumping threads at startup time
binfmt->core_dump() has to iterate over the all threads in system in order to find the coredumping threads and construct the list using the GFP_ATOMIC allocations. With this patch each thread allocates the list node on exit_mm()'s stack and adds itself to the list. This allows us to do further changes: - simplify ->core_dump() - change exit_mm() to clear ->mm first, then wait for ->core_done. this makes the coredumping process visible to oom_kill - kill mm->core_done Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru> Acked-by: Roland McGrath <roland@redhat.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'fs/exec.c')
-rw-r--r--fs/exec.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/fs/exec.c b/fs/exec.c
index b8ee842d93cd..fe2873b8037f 100644
--- a/fs/exec.c
+++ b/fs/exec.c
@@ -1604,6 +1604,8 @@ static int coredump_wait(int exit_code, struct core_state *core_state)
1604 1604
1605 init_completion(&mm->core_done); 1605 init_completion(&mm->core_done);
1606 init_completion(&core_state->startup); 1606 init_completion(&core_state->startup);
1607 core_state->dumper.task = tsk;
1608 core_state->dumper.next = NULL;
1607 core_waiters = zap_threads(tsk, mm, core_state, exit_code); 1609 core_waiters = zap_threads(tsk, mm, core_state, exit_code);
1608 up_write(&mm->mmap_sem); 1610 up_write(&mm->mmap_sem);
1609 1611