make d_splice_alias(ERR_PTR(err), dentry) = ERR_PTR(err)

... and simplify the living hell out of callers

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

1 files changed, 2 insertions, 5 deletions

diff --git a/fs/efs/namei.c b/fs/efs/namei.c
index 1511bf9e5f80..832b10ded82f 100644
--- a/fs/efs/namei.c
+++ b/fs/efs/namei.c
@@ -60,14 +60,11 @@ static efs_ino_t efs_find_entry(struct inode *inode, const char *name, int len)
 
 struct dentry *efs_lookup(struct inode *dir, struct dentry *dentry, struct nameidata *nd) {
         efs_ino_t inodenum;
-        struct inode * inode = NULL;
+        struct inode *inode = NULL;
 
         inodenum = efs_find_entry(dir, dentry->d_name.name, dentry->d_name.len);
-        if (inodenum) {
+        if (inodenum)
                 inode = efs_iget(dir->i_sb, inodenum);
-                if (IS_ERR(inode))
-                        return ERR_CAST(inode);
-        }
 
         return d_splice_alias(inode, dentry);
 }