diff options
author | Linus Torvalds <torvalds@linux-foundation.org> | 2013-11-22 13:58:14 -0500 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2013-11-22 13:58:14 -0500 |
commit | 57498f9cb91be1eebea48f1dc833ebf162606ad5 (patch) | |
tree | f7919c43e8d958a639b22c9222458a8d449dc190 /fs/ecryptfs | |
parent | e48f88a30de46c311d1c9493b5448332ebc1eb9b (diff) | |
parent | 2000f5beabc9c6baf084de5f7879975408e3652c (diff) |
Merge tag 'ecryptfs-3.13-rc1-quiet-checkers' of git://git.kernel.org/pub/scm/linux/kernel/git/tyhicks/ecryptfs
Pull minor eCryptfs fix from Tyler Hicks:
"Quiet static checkers by removing unneeded conditionals"
* tag 'ecryptfs-3.13-rc1-quiet-checkers' of git://git.kernel.org/pub/scm/linux/kernel/git/tyhicks/ecryptfs:
eCryptfs: file->private_data is always valid
Diffstat (limited to 'fs/ecryptfs')
-rw-r--r-- | fs/ecryptfs/file.c | 8 |
1 files changed, 2 insertions, 6 deletions
diff --git a/fs/ecryptfs/file.c b/fs/ecryptfs/file.c index 2229a74aeeed..b1eaa7a1f82c 100644 --- a/fs/ecryptfs/file.c +++ b/fs/ecryptfs/file.c | |||
@@ -313,11 +313,9 @@ static int ecryptfs_fasync(int fd, struct file *file, int flag) | |||
313 | static long | 313 | static long |
314 | ecryptfs_unlocked_ioctl(struct file *file, unsigned int cmd, unsigned long arg) | 314 | ecryptfs_unlocked_ioctl(struct file *file, unsigned int cmd, unsigned long arg) |
315 | { | 315 | { |
316 | struct file *lower_file = NULL; | 316 | struct file *lower_file = ecryptfs_file_to_lower(file); |
317 | long rc = -ENOTTY; | 317 | long rc = -ENOTTY; |
318 | 318 | ||
319 | if (ecryptfs_file_to_private(file)) | ||
320 | lower_file = ecryptfs_file_to_lower(file); | ||
321 | if (lower_file->f_op->unlocked_ioctl) | 319 | if (lower_file->f_op->unlocked_ioctl) |
322 | rc = lower_file->f_op->unlocked_ioctl(lower_file, cmd, arg); | 320 | rc = lower_file->f_op->unlocked_ioctl(lower_file, cmd, arg); |
323 | return rc; | 321 | return rc; |
@@ -327,11 +325,9 @@ ecryptfs_unlocked_ioctl(struct file *file, unsigned int cmd, unsigned long arg) | |||
327 | static long | 325 | static long |
328 | ecryptfs_compat_ioctl(struct file *file, unsigned int cmd, unsigned long arg) | 326 | ecryptfs_compat_ioctl(struct file *file, unsigned int cmd, unsigned long arg) |
329 | { | 327 | { |
330 | struct file *lower_file = NULL; | 328 | struct file *lower_file = ecryptfs_file_to_lower(file); |
331 | long rc = -ENOIOCTLCMD; | 329 | long rc = -ENOIOCTLCMD; |
332 | 330 | ||
333 | if (ecryptfs_file_to_private(file)) | ||
334 | lower_file = ecryptfs_file_to_lower(file); | ||
335 | if (lower_file->f_op && lower_file->f_op->compat_ioctl) | 331 | if (lower_file->f_op && lower_file->f_op->compat_ioctl) |
336 | rc = lower_file->f_op->compat_ioctl(lower_file, cmd, arg); | 332 | rc = lower_file->f_op->compat_ioctl(lower_file, cmd, arg); |
337 | return rc; | 333 | return rc; |