diff options
author | Greg Kroah-Hartman <gregkh@suse.de> | 2007-10-16 12:11:44 -0400 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@suse.de> | 2008-01-24 23:40:10 -0500 |
commit | 3514faca19a6fdc209734431c509631ea92b094e (patch) | |
tree | f6d102e6dec276f8e8d1044b47c74a02b901554f /fs/ecryptfs/main.c | |
parent | c11c4154e7ff4cebfadad849b1e22689d759c3f4 (diff) |
kobject: remove struct kobj_type from struct kset
We don't need a "default" ktype for a kset. We should set this
explicitly every time for each kset. This change is needed so that we
can make ksets dynamic, and cleans up one of the odd, undocumented
assumption that the kset/kobject/ktype model has.
This patch is based on a lot of help from Kay Sievers.
Nasty bug in the block code was found by Dave Young
<hidave.darkstar@gmail.com>
Cc: Kay Sievers <kay.sievers@vrfy.org>
Cc: Dave Young <hidave.darkstar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'fs/ecryptfs/main.c')
-rw-r--r-- | fs/ecryptfs/main.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/fs/ecryptfs/main.c b/fs/ecryptfs/main.c index f9f32472c505..fe2f44fa17cc 100644 --- a/fs/ecryptfs/main.c +++ b/fs/ecryptfs/main.c | |||
@@ -734,7 +734,7 @@ static int ecryptfs_init_kmem_caches(void) | |||
734 | return 0; | 734 | return 0; |
735 | } | 735 | } |
736 | 736 | ||
737 | static decl_subsys(ecryptfs, NULL, NULL); | 737 | static decl_subsys(ecryptfs, NULL); |
738 | 738 | ||
739 | static ssize_t version_show(struct kset *kset, char *buff) | 739 | static ssize_t version_show(struct kset *kset, char *buff) |
740 | { | 740 | { |
@@ -798,6 +798,7 @@ static int do_sysfs_registration(void) | |||
798 | { | 798 | { |
799 | int rc; | 799 | int rc; |
800 | 800 | ||
801 | ecryptfs_subsys.kobj.kset = &fs_subsys; | ||
801 | rc = subsystem_register(&ecryptfs_subsys); | 802 | rc = subsystem_register(&ecryptfs_subsys); |
802 | if (rc) { | 803 | if (rc) { |
803 | printk(KERN_ERR | 804 | printk(KERN_ERR |
@@ -845,7 +846,6 @@ static int __init ecryptfs_init(void) | |||
845 | printk(KERN_ERR "Failed to register filesystem\n"); | 846 | printk(KERN_ERR "Failed to register filesystem\n"); |
846 | goto out_free_kmem_caches; | 847 | goto out_free_kmem_caches; |
847 | } | 848 | } |
848 | kobj_set_kset_s(&ecryptfs_subsys, fs_subsys); | ||
849 | rc = do_sysfs_registration(); | 849 | rc = do_sysfs_registration(); |
850 | if (rc) { | 850 | if (rc) { |
851 | printk(KERN_ERR "sysfs registration failed\n"); | 851 | printk(KERN_ERR "sysfs registration failed\n"); |