diff options
author | Greg Kroah-Hartman <gregkh@suse.de> | 2007-10-16 12:11:44 -0400 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@suse.de> | 2008-01-24 23:40:10 -0500 |
commit | 3514faca19a6fdc209734431c509631ea92b094e (patch) | |
tree | f6d102e6dec276f8e8d1044b47c74a02b901554f /fs/dlm/lockspace.c | |
parent | c11c4154e7ff4cebfadad849b1e22689d759c3f4 (diff) |
kobject: remove struct kobj_type from struct kset
We don't need a "default" ktype for a kset. We should set this
explicitly every time for each kset. This change is needed so that we
can make ksets dynamic, and cleans up one of the odd, undocumented
assumption that the kset/kobject/ktype model has.
This patch is based on a lot of help from Kay Sievers.
Nasty bug in the block code was found by Dave Young
<hidave.darkstar@gmail.com>
Cc: Kay Sievers <kay.sievers@vrfy.org>
Cc: Dave Young <hidave.darkstar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'fs/dlm/lockspace.c')
-rw-r--r-- | fs/dlm/lockspace.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/fs/dlm/lockspace.c b/fs/dlm/lockspace.c index 6353a8384520..18e4a17b9bee 100644 --- a/fs/dlm/lockspace.c +++ b/fs/dlm/lockspace.c | |||
@@ -166,9 +166,7 @@ static struct kobj_type dlm_ktype = { | |||
166 | .release = lockspace_kobj_release, | 166 | .release = lockspace_kobj_release, |
167 | }; | 167 | }; |
168 | 168 | ||
169 | static struct kset dlm_kset = { | 169 | static struct kset dlm_kset; |
170 | .ktype = &dlm_ktype, | ||
171 | }; | ||
172 | 170 | ||
173 | static int kobject_setup(struct dlm_ls *ls) | 171 | static int kobject_setup(struct dlm_ls *ls) |
174 | { | 172 | { |
@@ -228,7 +226,7 @@ int dlm_lockspace_init(void) | |||
228 | spin_lock_init(&lslist_lock); | 226 | spin_lock_init(&lslist_lock); |
229 | 227 | ||
230 | kobject_set_name(&dlm_kset.kobj, "dlm"); | 228 | kobject_set_name(&dlm_kset.kobj, "dlm"); |
231 | kobj_set_kset_s(&dlm_kset, kernel_subsys); | 229 | dlm_kset.kobj.kset = &kernel_subsys; |
232 | error = kset_register(&dlm_kset); | 230 | error = kset_register(&dlm_kset); |
233 | if (error) | 231 | if (error) |
234 | printk("dlm_lockspace_init: cannot register kset %d\n", error); | 232 | printk("dlm_lockspace_init: cannot register kset %d\n", error); |