diff options
| author | Steven Whitehouse <swhiteho@redhat.com> | 2006-09-28 08:29:59 -0400 |
|---|---|---|
| committer | Steven Whitehouse <swhiteho@redhat.com> | 2006-09-28 08:29:59 -0400 |
| commit | 185a257f2f73bcd89050ad02da5bedbc28fc43fa (patch) | |
| tree | 5e32586114534ed3f2165614cba3d578f5d87307 /fs/debugfs | |
| parent | 3f1a9aaeffd8d1cbc5ab9776c45cbd66af1c9699 (diff) | |
| parent | a77c64c1a641950626181b4857abb701d8f38ccc (diff) | |
Merge branch 'master' into gfs2
Diffstat (limited to 'fs/debugfs')
| -rw-r--r-- | fs/debugfs/file.c | 60 | ||||
| -rw-r--r-- | fs/debugfs/inode.c | 20 |
2 files changed, 35 insertions, 45 deletions
diff --git a/fs/debugfs/file.c b/fs/debugfs/file.c index 39640fd03458..bf3901ab1744 100644 --- a/fs/debugfs/file.c +++ b/fs/debugfs/file.c | |||
| @@ -32,8 +32,8 @@ static ssize_t default_write_file(struct file *file, const char __user *buf, | |||
| 32 | 32 | ||
| 33 | static int default_open(struct inode *inode, struct file *file) | 33 | static int default_open(struct inode *inode, struct file *file) |
| 34 | { | 34 | { |
| 35 | if (inode->u.generic_ip) | 35 | if (inode->i_private) |
| 36 | file->private_data = inode->u.generic_ip; | 36 | file->private_data = inode->i_private; |
| 37 | 37 | ||
| 38 | return 0; | 38 | return 0; |
| 39 | } | 39 | } |
| @@ -55,12 +55,11 @@ static u64 debugfs_u8_get(void *data) | |||
| 55 | DEFINE_SIMPLE_ATTRIBUTE(fops_u8, debugfs_u8_get, debugfs_u8_set, "%llu\n"); | 55 | DEFINE_SIMPLE_ATTRIBUTE(fops_u8, debugfs_u8_get, debugfs_u8_set, "%llu\n"); |
| 56 | 56 | ||
| 57 | /** | 57 | /** |
| 58 | * debugfs_create_u8 - create a file in the debugfs filesystem that is used to read and write an unsigned 8 bit value. | 58 | * debugfs_create_u8 - create a debugfs file that is used to read and write an unsigned 8-bit value |
| 59 | * | ||
| 60 | * @name: a pointer to a string containing the name of the file to create. | 59 | * @name: a pointer to a string containing the name of the file to create. |
| 61 | * @mode: the permission that the file should have | 60 | * @mode: the permission that the file should have |
| 62 | * @parent: a pointer to the parent dentry for this file. This should be a | 61 | * @parent: a pointer to the parent dentry for this file. This should be a |
| 63 | * directory dentry if set. If this paramater is NULL, then the | 62 | * directory dentry if set. If this parameter is %NULL, then the |
| 64 | * file will be created in the root of the debugfs filesystem. | 63 | * file will be created in the root of the debugfs filesystem. |
| 65 | * @value: a pointer to the variable that the file should read to and write | 64 | * @value: a pointer to the variable that the file should read to and write |
| 66 | * from. | 65 | * from. |
| @@ -72,11 +71,11 @@ DEFINE_SIMPLE_ATTRIBUTE(fops_u8, debugfs_u8_get, debugfs_u8_set, "%llu\n"); | |||
| 72 | * This function will return a pointer to a dentry if it succeeds. This | 71 | * This function will return a pointer to a dentry if it succeeds. This |
| 73 | * pointer must be passed to the debugfs_remove() function when the file is | 72 | * pointer must be passed to the debugfs_remove() function when the file is |
| 74 | * to be removed (no automatic cleanup happens if your module is unloaded, | 73 | * to be removed (no automatic cleanup happens if your module is unloaded, |
| 75 | * you are responsible here.) If an error occurs, NULL will be returned. | 74 | * you are responsible here.) If an error occurs, %NULL will be returned. |
| 76 | * | 75 | * |
| 77 | * If debugfs is not enabled in the kernel, the value -ENODEV will be | 76 | * If debugfs is not enabled in the kernel, the value -%ENODEV will be |
| 78 | * returned. It is not wise to check for this value, but rather, check for | 77 | * returned. It is not wise to check for this value, but rather, check for |
| 79 | * NULL or !NULL instead as to eliminate the need for #ifdef in the calling | 78 | * %NULL or !%NULL instead as to eliminate the need for #ifdef in the calling |
| 80 | * code. | 79 | * code. |
| 81 | */ | 80 | */ |
| 82 | struct dentry *debugfs_create_u8(const char *name, mode_t mode, | 81 | struct dentry *debugfs_create_u8(const char *name, mode_t mode, |
| @@ -97,12 +96,11 @@ static u64 debugfs_u16_get(void *data) | |||
| 97 | DEFINE_SIMPLE_ATTRIBUTE(fops_u16, debugfs_u16_get, debugfs_u16_set, "%llu\n"); | 96 | DEFINE_SIMPLE_ATTRIBUTE(fops_u16, debugfs_u16_get, debugfs_u16_set, "%llu\n"); |
| 98 | 97 | ||
| 99 | /** | 98 | /** |
| 100 | * debugfs_create_u16 - create a file in the debugfs filesystem that is used to read and write an unsigned 16 bit value. | 99 | * debugfs_create_u16 - create a debugfs file that is used to read and write an unsigned 16-bit value |
| 101 | * | ||
| 102 | * @name: a pointer to a string containing the name of the file to create. | 100 | * @name: a pointer to a string containing the name of the file to create. |
| 103 | * @mode: the permission that the file should have | 101 | * @mode: the permission that the file should have |
| 104 | * @parent: a pointer to the parent dentry for this file. This should be a | 102 | * @parent: a pointer to the parent dentry for this file. This should be a |
| 105 | * directory dentry if set. If this paramater is NULL, then the | 103 | * directory dentry if set. If this parameter is %NULL, then the |
| 106 | * file will be created in the root of the debugfs filesystem. | 104 | * file will be created in the root of the debugfs filesystem. |
| 107 | * @value: a pointer to the variable that the file should read to and write | 105 | * @value: a pointer to the variable that the file should read to and write |
| 108 | * from. | 106 | * from. |
| @@ -114,11 +112,11 @@ DEFINE_SIMPLE_ATTRIBUTE(fops_u16, debugfs_u16_get, debugfs_u16_set, "%llu\n"); | |||
| 114 | * This function will return a pointer to a dentry if it succeeds. This | 112 | * This function will return a pointer to a dentry if it succeeds. This |
| 115 | * pointer must be passed to the debugfs_remove() function when the file is | 113 | * pointer must be passed to the debugfs_remove() function when the file is |
| 116 | * to be removed (no automatic cleanup happens if your module is unloaded, | 114 | * to be removed (no automatic cleanup happens if your module is unloaded, |
| 117 | * you are responsible here.) If an error occurs, NULL will be returned. | 115 | * you are responsible here.) If an error occurs, %NULL will be returned. |
| 118 | * | 116 | * |
| 119 | * If debugfs is not enabled in the kernel, the value -ENODEV will be | 117 | * If debugfs is not enabled in the kernel, the value -%ENODEV will be |
| 120 | * returned. It is not wise to check for this value, but rather, check for | 118 | * returned. It is not wise to check for this value, but rather, check for |
| 121 | * NULL or !NULL instead as to eliminate the need for #ifdef in the calling | 119 | * %NULL or !%NULL instead as to eliminate the need for #ifdef in the calling |
| 122 | * code. | 120 | * code. |
| 123 | */ | 121 | */ |
| 124 | struct dentry *debugfs_create_u16(const char *name, mode_t mode, | 122 | struct dentry *debugfs_create_u16(const char *name, mode_t mode, |
| @@ -139,12 +137,11 @@ static u64 debugfs_u32_get(void *data) | |||
| 139 | DEFINE_SIMPLE_ATTRIBUTE(fops_u32, debugfs_u32_get, debugfs_u32_set, "%llu\n"); | 137 | DEFINE_SIMPLE_ATTRIBUTE(fops_u32, debugfs_u32_get, debugfs_u32_set, "%llu\n"); |
| 140 | 138 | ||
| 141 | /** | 139 | /** |
| 142 | * debugfs_create_u32 - create a file in the debugfs filesystem that is used to read and write an unsigned 32 bit value. | 140 | * debugfs_create_u32 - create a debugfs file that is used to read and write an unsigned 32-bit value |
| 143 | * | ||
| 144 | * @name: a pointer to a string containing the name of the file to create. | 141 | * @name: a pointer to a string containing the name of the file to create. |
| 145 | * @mode: the permission that the file should have | 142 | * @mode: the permission that the file should have |
| 146 | * @parent: a pointer to the parent dentry for this file. This should be a | 143 | * @parent: a pointer to the parent dentry for this file. This should be a |
| 147 | * directory dentry if set. If this paramater is NULL, then the | 144 | * directory dentry if set. If this parameter is %NULL, then the |
| 148 | * file will be created in the root of the debugfs filesystem. | 145 | * file will be created in the root of the debugfs filesystem. |
| 149 | * @value: a pointer to the variable that the file should read to and write | 146 | * @value: a pointer to the variable that the file should read to and write |
| 150 | * from. | 147 | * from. |
| @@ -156,11 +153,11 @@ DEFINE_SIMPLE_ATTRIBUTE(fops_u32, debugfs_u32_get, debugfs_u32_set, "%llu\n"); | |||
| 156 | * This function will return a pointer to a dentry if it succeeds. This | 153 | * This function will return a pointer to a dentry if it succeeds. This |
| 157 | * pointer must be passed to the debugfs_remove() function when the file is | 154 | * pointer must be passed to the debugfs_remove() function when the file is |
| 158 | * to be removed (no automatic cleanup happens if your module is unloaded, | 155 | * to be removed (no automatic cleanup happens if your module is unloaded, |
| 159 | * you are responsible here.) If an error occurs, NULL will be returned. | 156 | * you are responsible here.) If an error occurs, %NULL will be returned. |
| 160 | * | 157 | * |
| 161 | * If debugfs is not enabled in the kernel, the value -ENODEV will be | 158 | * If debugfs is not enabled in the kernel, the value -%ENODEV will be |
| 162 | * returned. It is not wise to check for this value, but rather, check for | 159 | * returned. It is not wise to check for this value, but rather, check for |
| 163 | * NULL or !NULL instead as to eliminate the need for #ifdef in the calling | 160 | * %NULL or !%NULL instead as to eliminate the need for #ifdef in the calling |
| 164 | * code. | 161 | * code. |
| 165 | */ | 162 | */ |
| 166 | struct dentry *debugfs_create_u32(const char *name, mode_t mode, | 163 | struct dentry *debugfs_create_u32(const char *name, mode_t mode, |
| @@ -219,12 +216,11 @@ static const struct file_operations fops_bool = { | |||
| 219 | }; | 216 | }; |
| 220 | 217 | ||
| 221 | /** | 218 | /** |
| 222 | * debugfs_create_bool - create a file in the debugfs filesystem that is used to read and write a boolean value. | 219 | * debugfs_create_bool - create a debugfs file that is used to read and write a boolean value |
| 223 | * | ||
| 224 | * @name: a pointer to a string containing the name of the file to create. | 220 | * @name: a pointer to a string containing the name of the file to create. |
| 225 | * @mode: the permission that the file should have | 221 | * @mode: the permission that the file should have |
| 226 | * @parent: a pointer to the parent dentry for this file. This should be a | 222 | * @parent: a pointer to the parent dentry for this file. This should be a |
| 227 | * directory dentry if set. If this paramater is NULL, then the | 223 | * directory dentry if set. If this parameter is %NULL, then the |
| 228 | * file will be created in the root of the debugfs filesystem. | 224 | * file will be created in the root of the debugfs filesystem. |
| 229 | * @value: a pointer to the variable that the file should read to and write | 225 | * @value: a pointer to the variable that the file should read to and write |
| 230 | * from. | 226 | * from. |
| @@ -236,11 +232,11 @@ static const struct file_operations fops_bool = { | |||
| 236 | * This function will return a pointer to a dentry if it succeeds. This | 232 | * This function will return a pointer to a dentry if it succeeds. This |
| 237 | * pointer must be passed to the debugfs_remove() function when the file is | 233 | * pointer must be passed to the debugfs_remove() function when the file is |
| 238 | * to be removed (no automatic cleanup happens if your module is unloaded, | 234 | * to be removed (no automatic cleanup happens if your module is unloaded, |
| 239 | * you are responsible here.) If an error occurs, NULL will be returned. | 235 | * you are responsible here.) If an error occurs, %NULL will be returned. |
| 240 | * | 236 | * |
| 241 | * If debugfs is not enabled in the kernel, the value -ENODEV will be | 237 | * If debugfs is not enabled in the kernel, the value -%ENODEV will be |
| 242 | * returned. It is not wise to check for this value, but rather, check for | 238 | * returned. It is not wise to check for this value, but rather, check for |
| 243 | * NULL or !NULL instead as to eliminate the need for #ifdef in the calling | 239 | * %NULL or !%NULL instead as to eliminate the need for #ifdef in the calling |
| 244 | * code. | 240 | * code. |
| 245 | */ | 241 | */ |
| 246 | struct dentry *debugfs_create_bool(const char *name, mode_t mode, | 242 | struct dentry *debugfs_create_bool(const char *name, mode_t mode, |
| @@ -264,13 +260,11 @@ static struct file_operations fops_blob = { | |||
| 264 | }; | 260 | }; |
| 265 | 261 | ||
| 266 | /** | 262 | /** |
| 267 | * debugfs_create_blob - create a file in the debugfs filesystem that is | 263 | * debugfs_create_blob - create a debugfs file that is used to read and write a binary blob |
| 268 | * used to read and write a binary blob. | ||
| 269 | * | ||
| 270 | * @name: a pointer to a string containing the name of the file to create. | 264 | * @name: a pointer to a string containing the name of the file to create. |
| 271 | * @mode: the permission that the file should have | 265 | * @mode: the permission that the file should have |
| 272 | * @parent: a pointer to the parent dentry for this file. This should be a | 266 | * @parent: a pointer to the parent dentry for this file. This should be a |
| 273 | * directory dentry if set. If this paramater is NULL, then the | 267 | * directory dentry if set. If this parameter is %NULL, then the |
| 274 | * file will be created in the root of the debugfs filesystem. | 268 | * file will be created in the root of the debugfs filesystem. |
| 275 | * @blob: a pointer to a struct debugfs_blob_wrapper which contains a pointer | 269 | * @blob: a pointer to a struct debugfs_blob_wrapper which contains a pointer |
| 276 | * to the blob data and the size of the data. | 270 | * to the blob data and the size of the data. |
| @@ -282,11 +276,11 @@ static struct file_operations fops_blob = { | |||
| 282 | * This function will return a pointer to a dentry if it succeeds. This | 276 | * This function will return a pointer to a dentry if it succeeds. This |
| 283 | * pointer must be passed to the debugfs_remove() function when the file is | 277 | * pointer must be passed to the debugfs_remove() function when the file is |
| 284 | * to be removed (no automatic cleanup happens if your module is unloaded, | 278 | * to be removed (no automatic cleanup happens if your module is unloaded, |
| 285 | * you are responsible here.) If an error occurs, NULL will be returned. | 279 | * you are responsible here.) If an error occurs, %NULL will be returned. |
| 286 | * | 280 | * |
| 287 | * If debugfs is not enabled in the kernel, the value -ENODEV will be | 281 | * If debugfs is not enabled in the kernel, the value -%ENODEV will be |
| 288 | * returned. It is not wise to check for this value, but rather, check for | 282 | * returned. It is not wise to check for this value, but rather, check for |
| 289 | * NULL or !NULL instead as to eliminate the need for #ifdef in the calling | 283 | * %NULL or !%NULL instead as to eliminate the need for #ifdef in the calling |
| 290 | * code. | 284 | * code. |
| 291 | */ | 285 | */ |
| 292 | struct dentry *debugfs_create_blob(const char *name, mode_t mode, | 286 | struct dentry *debugfs_create_blob(const char *name, mode_t mode, |
diff --git a/fs/debugfs/inode.c b/fs/debugfs/inode.c index e8ae3042b806..269e649e6dc6 100644 --- a/fs/debugfs/inode.c +++ b/fs/debugfs/inode.c | |||
| @@ -40,7 +40,6 @@ static struct inode *debugfs_get_inode(struct super_block *sb, int mode, dev_t d | |||
| 40 | inode->i_mode = mode; | 40 | inode->i_mode = mode; |
| 41 | inode->i_uid = 0; | 41 | inode->i_uid = 0; |
| 42 | inode->i_gid = 0; | 42 | inode->i_gid = 0; |
| 43 | inode->i_blksize = PAGE_CACHE_SIZE; | ||
| 44 | inode->i_blocks = 0; | 43 | inode->i_blocks = 0; |
| 45 | inode->i_atime = inode->i_mtime = inode->i_ctime = CURRENT_TIME; | 44 | inode->i_atime = inode->i_mtime = inode->i_ctime = CURRENT_TIME; |
| 46 | switch (mode & S_IFMT) { | 45 | switch (mode & S_IFMT) { |
| @@ -162,14 +161,13 @@ static int debugfs_create_by_name(const char *name, mode_t mode, | |||
| 162 | 161 | ||
| 163 | /** | 162 | /** |
| 164 | * debugfs_create_file - create a file in the debugfs filesystem | 163 | * debugfs_create_file - create a file in the debugfs filesystem |
| 165 | * | ||
| 166 | * @name: a pointer to a string containing the name of the file to create. | 164 | * @name: a pointer to a string containing the name of the file to create. |
| 167 | * @mode: the permission that the file should have | 165 | * @mode: the permission that the file should have |
| 168 | * @parent: a pointer to the parent dentry for this file. This should be a | 166 | * @parent: a pointer to the parent dentry for this file. This should be a |
| 169 | * directory dentry if set. If this paramater is NULL, then the | 167 | * directory dentry if set. If this paramater is NULL, then the |
| 170 | * file will be created in the root of the debugfs filesystem. | 168 | * file will be created in the root of the debugfs filesystem. |
| 171 | * @data: a pointer to something that the caller will want to get to later | 169 | * @data: a pointer to something that the caller will want to get to later |
| 172 | * on. The inode.u.generic_ip pointer will point to this value on | 170 | * on. The inode.i_private pointer will point to this value on |
| 173 | * the open() call. | 171 | * the open() call. |
| 174 | * @fops: a pointer to a struct file_operations that should be used for | 172 | * @fops: a pointer to a struct file_operations that should be used for |
| 175 | * this file. | 173 | * this file. |
| @@ -182,11 +180,11 @@ static int debugfs_create_by_name(const char *name, mode_t mode, | |||
| 182 | * This function will return a pointer to a dentry if it succeeds. This | 180 | * This function will return a pointer to a dentry if it succeeds. This |
| 183 | * pointer must be passed to the debugfs_remove() function when the file is | 181 | * pointer must be passed to the debugfs_remove() function when the file is |
| 184 | * to be removed (no automatic cleanup happens if your module is unloaded, | 182 | * to be removed (no automatic cleanup happens if your module is unloaded, |
| 185 | * you are responsible here.) If an error occurs, NULL will be returned. | 183 | * you are responsible here.) If an error occurs, %NULL will be returned. |
| 186 | * | 184 | * |
| 187 | * If debugfs is not enabled in the kernel, the value -ENODEV will be | 185 | * If debugfs is not enabled in the kernel, the value -%ENODEV will be |
| 188 | * returned. It is not wise to check for this value, but rather, check for | 186 | * returned. It is not wise to check for this value, but rather, check for |
| 189 | * NULL or !NULL instead as to eliminate the need for #ifdef in the calling | 187 | * %NULL or !%NULL instead as to eliminate the need for #ifdef in the calling |
| 190 | * code. | 188 | * code. |
| 191 | */ | 189 | */ |
| 192 | struct dentry *debugfs_create_file(const char *name, mode_t mode, | 190 | struct dentry *debugfs_create_file(const char *name, mode_t mode, |
| @@ -210,7 +208,7 @@ struct dentry *debugfs_create_file(const char *name, mode_t mode, | |||
| 210 | 208 | ||
| 211 | if (dentry->d_inode) { | 209 | if (dentry->d_inode) { |
| 212 | if (data) | 210 | if (data) |
| 213 | dentry->d_inode->u.generic_ip = data; | 211 | dentry->d_inode->i_private = data; |
| 214 | if (fops) | 212 | if (fops) |
| 215 | dentry->d_inode->i_fop = fops; | 213 | dentry->d_inode->i_fop = fops; |
| 216 | } | 214 | } |
| @@ -221,7 +219,6 @@ EXPORT_SYMBOL_GPL(debugfs_create_file); | |||
| 221 | 219 | ||
| 222 | /** | 220 | /** |
| 223 | * debugfs_create_dir - create a directory in the debugfs filesystem | 221 | * debugfs_create_dir - create a directory in the debugfs filesystem |
| 224 | * | ||
| 225 | * @name: a pointer to a string containing the name of the directory to | 222 | * @name: a pointer to a string containing the name of the directory to |
| 226 | * create. | 223 | * create. |
| 227 | * @parent: a pointer to the parent dentry for this file. This should be a | 224 | * @parent: a pointer to the parent dentry for this file. This should be a |
| @@ -233,11 +230,11 @@ EXPORT_SYMBOL_GPL(debugfs_create_file); | |||
| 233 | * This function will return a pointer to a dentry if it succeeds. This | 230 | * This function will return a pointer to a dentry if it succeeds. This |
| 234 | * pointer must be passed to the debugfs_remove() function when the file is | 231 | * pointer must be passed to the debugfs_remove() function when the file is |
| 235 | * to be removed (no automatic cleanup happens if your module is unloaded, | 232 | * to be removed (no automatic cleanup happens if your module is unloaded, |
| 236 | * you are responsible here.) If an error occurs, NULL will be returned. | 233 | * you are responsible here.) If an error occurs, %NULL will be returned. |
| 237 | * | 234 | * |
| 238 | * If debugfs is not enabled in the kernel, the value -ENODEV will be | 235 | * If debugfs is not enabled in the kernel, the value -%ENODEV will be |
| 239 | * returned. It is not wise to check for this value, but rather, check for | 236 | * returned. It is not wise to check for this value, but rather, check for |
| 240 | * NULL or !NULL instead as to eliminate the need for #ifdef in the calling | 237 | * %NULL or !%NULL instead as to eliminate the need for #ifdef in the calling |
| 241 | * code. | 238 | * code. |
| 242 | */ | 239 | */ |
| 243 | struct dentry *debugfs_create_dir(const char *name, struct dentry *parent) | 240 | struct dentry *debugfs_create_dir(const char *name, struct dentry *parent) |
| @@ -250,7 +247,6 @@ EXPORT_SYMBOL_GPL(debugfs_create_dir); | |||
| 250 | 247 | ||
| 251 | /** | 248 | /** |
| 252 | * debugfs_remove - removes a file or directory from the debugfs filesystem | 249 | * debugfs_remove - removes a file or directory from the debugfs filesystem |
| 253 | * | ||
| 254 | * @dentry: a pointer to a the dentry of the file or directory to be | 250 | * @dentry: a pointer to a the dentry of the file or directory to be |
| 255 | * removed. | 251 | * removed. |
| 256 | * | 252 | * |
