aboutsummaryrefslogtreecommitdiffstats
path: root/fs/dcookies.c
diff options
context:
space:
mode:
authorMiklos Szeredi <miklos@szeredi.hu>2005-07-07 20:57:29 -0400
committerLinus Torvalds <torvalds@g5.osdl.org>2005-07-07 21:23:52 -0400
commit732dbef606f22a23cb3e1029d613977ec645e8ae (patch)
tree513e7230a59a526a09b387b5a2628a2eed3a80bb /fs/dcookies.c
parent484e389c63472a7f8cfb491cf11b047364e59365 (diff)
[PATCH] dcookies.c: use proper refcounting functions
Dcookies shouldn't play with the internals of dentry and vfsmnt refcounting. It defeats grepping, and is prone to break if implementation details change. In addition the function doesn't even seem to be performance critical: it calls kmem_cache_alloc(). Signed-off-by: Miklos Szeredi <miklos@szeredi.hu> Acked-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'fs/dcookies.c')
-rw-r--r--fs/dcookies.c6
1 files changed, 2 insertions, 4 deletions
diff --git a/fs/dcookies.c b/fs/dcookies.c
index 581aac959cd3..02aa0ddc582a 100644
--- a/fs/dcookies.c
+++ b/fs/dcookies.c
@@ -94,12 +94,10 @@ static struct dcookie_struct * alloc_dcookie(struct dentry * dentry,
94 if (!dcs) 94 if (!dcs)
95 return NULL; 95 return NULL;
96 96
97 atomic_inc(&dentry->d_count);
98 atomic_inc(&vfsmnt->mnt_count);
99 dentry->d_cookie = dcs; 97 dentry->d_cookie = dcs;
100 98
101 dcs->dentry = dentry; 99 dcs->dentry = dget(dentry);
102 dcs->vfsmnt = vfsmnt; 100 dcs->vfsmnt = mntget(vfsmnt);
103 hash_dcookie(dcs); 101 hash_dcookie(dcs);
104 102
105 return dcs; 103 return dcs;