configfs: Allow ->make_item() and ->make_group() to return detailed errors.

The configfs operations ->make_item() and ->make_group() currently
return a new item/group.  A return of NULL signifies an error.  Because
of this, -ENOMEM is the only return code bubbled up the stack.

Multiple folks have requested the ability to return specific error codes
when these operations fail.  This patch adds that ability by changing the
->make_item/group() ops to return ERR_PTR() values.  These errors are
bubbled up appropriately.  NULL returns are changed to -ENOMEM for
compatibility.

Also updated are the in-kernel users of configfs.

This is a rework of reverted commit 11c3b79218390a139f2d474ee1e983a672d5839a.

Signed-off-by: Joel Becker <joel.becker@oracle.com>

1 files changed, 15 insertions, 10 deletions

diff --git a/fs/configfs/dir.c b/fs/configfs/dir.c
index 614e382a6049..179589be063a 100644
--- a/fs/configfs/dir.c
+++ b/fs/configfs/dir.c
@@ -1027,9 +1027,10 @@ EXPORT_SYMBOL(configfs_undepend_item);
 
 static int configfs_mkdir(struct inode *dir, struct dentry *dentry, int mode)
 {
-        int ret, module_got = 0;
-        struct config_group *group;
-        struct config_item *item;
+        int ret = 0;
+        int module_got = 0;
+        struct config_group *group = NULL;
+        struct config_item *item = NULL;
         struct config_item *parent_item;
         struct configfs_subsystem *subsys;
         struct configfs_dirent *sd;
@@ -1070,28 +1071,32 @@ static int configfs_mkdir(struct inode *dir, struct dentry *dentry, int mode)
         snprintf(name, dentry->d_name.len + 1, "%s", dentry->d_name.name);
 
         mutex_lock(&subsys->su_mutex);
-        group = NULL;
-        item = NULL;
         if (type->ct_group_ops->make_group) {
                 group = type->ct_group_ops->make_group(to_config_group(parent_item), name);
-                if (group) {
+                if (!group)
+                        group = ERR_PTR(-ENOMEM);
+                if (!IS_ERR(group)) {
                         link_group(to_config_group(parent_item), group);
                         item = &group->cg_item;
-                }
+                } else
+                        ret = PTR_ERR(group);
         } else {
                 item = type->ct_group_ops->make_item(to_config_group(parent_item), name);
-                if (item)
+                if (!item)
+                        item = ERR_PTR(-ENOMEM);
+                if (!IS_ERR(item))
                         link_obj(parent_item, item);
+                else
+                        ret = PTR_ERR(item);
         }
         mutex_unlock(&subsys->su_mutex);
 
         kfree(name);
-        if (!item) {
+        if (ret) {
                 /*
                  * If item == NULL, then link_obj() was never called.
                  * There are no extra references to clean up.
                  */
-                ret = -ENOMEM;
                 goto out_put;
         }