aboutsummaryrefslogtreecommitdiffstats
path: root/fs/coda/upcall.c
diff options
context:
space:
mode:
authorJan Harkes <jaharkes@cs.cmu.edu>2007-07-19 04:48:41 -0400
committerLinus Torvalds <torvalds@woody.linux-foundation.org>2007-07-19 13:04:48 -0400
commit38c2e4370da495813ca93d7cad31ed5090e8c310 (patch)
treebf48c4a17f3f2f7cf17a20e37f55f898a332a2c7 /fs/coda/upcall.c
parent18991197b4b588255ccabf472ebc84db7b66a19c (diff)
coda: do not grab an uninitialized fd when the open upcall returns an error
When open fails the fd in the response is uninitialized and we ended up taking a reference on the file struct and never released it. Signed-off-by: Jan Harkes <jaharkes@cs.cmu.edu> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'fs/coda/upcall.c')
-rw-r--r--fs/coda/upcall.c10
1 files changed, 5 insertions, 5 deletions
diff --git a/fs/coda/upcall.c b/fs/coda/upcall.c
index 5faacdb1a479..1651b918219a 100644
--- a/fs/coda/upcall.c
+++ b/fs/coda/upcall.c
@@ -251,12 +251,12 @@ int venus_open(struct super_block *sb, struct CodaFid *fid,
251 insize = SIZE(open_by_fd); 251 insize = SIZE(open_by_fd);
252 UPARG(CODA_OPEN_BY_FD); 252 UPARG(CODA_OPEN_BY_FD);
253 253
254 inp->coda_open.VFid = *fid; 254 inp->coda_open_by_fd.VFid = *fid;
255 inp->coda_open.flags = flags; 255 inp->coda_open_by_fd.flags = flags;
256 256
257 error = coda_upcall(coda_sbp(sb), insize, &outsize, inp); 257 error = coda_upcall(coda_sbp(sb), insize, &outsize, inp);
258 258 if (!error)
259 *fh = outp->coda_open_by_fd.fh; 259 *fh = outp->coda_open_by_fd.fh;
260 260
261 CODA_FREE(inp, insize); 261 CODA_FREE(inp, insize);
262 return error; 262 return error;