coda: do not grab an uninitialized fd when the open upcall returns an error

When open fails the fd in the response is uninitialized and we ended up taking
a reference on the file struct and never released it.

Signed-off-by: Jan Harkes <jaharkes@cs.cmu.edu>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

1 files changed, 2 insertions, 1 deletions

diff --git a/fs/coda/psdev.c b/fs/coda/psdev.c
index 803aacf0d49c..09382d47a4e1 100644
--- a/fs/coda/psdev.c
+++ b/fs/coda/psdev.c
@@ -195,7 +195,8 @@ static ssize_t coda_psdev_write(struct file *file, const char __user *buf,
         if (req->uc_opcode == CODA_OPEN_BY_FD) {
                 struct coda_open_by_fd_out *outp =
                         (struct coda_open_by_fd_out *)req->uc_data;
-                outp->fh = fget(outp->fd);
+                if (!outp->oh.result)
+                        outp->fh = fget(outp->fd);
         }
 
         wake_up(&req->uc_sleep);