diff options
author | Steve French <sfrench@us.ibm.com> | 2010-04-21 00:12:10 -0400 |
---|---|---|
committer | Steve French <sfrench@us.ibm.com> | 2010-04-21 00:12:10 -0400 |
commit | f19159dc5ab9ec28c3b8230689101335d98e2d68 (patch) | |
tree | dbfe881035d52e3fb578e253a9d27d56cbb09c2f /fs/cifs | |
parent | b6b38f704a8193daba520493ebdaf7e819962fc8 (diff) |
[CIFS] Cleanup various minor breakage in previous cFYI cleanup
Signed-off-by: Steve French <sfrench@us.ibm.com>
Diffstat (limited to 'fs/cifs')
-rw-r--r-- | fs/cifs/cifsfs.h | 2 | ||||
-rw-r--r-- | fs/cifs/cifssmb.c | 22 | ||||
-rw-r--r-- | fs/cifs/file.c | 12 | ||||
-rw-r--r-- | fs/cifs/inode.c | 22 |
4 files changed, 29 insertions, 29 deletions
diff --git a/fs/cifs/cifsfs.h b/fs/cifs/cifsfs.h index 7aa57ecdc437..dac76022c5fe 100644 --- a/fs/cifs/cifsfs.h +++ b/fs/cifs/cifsfs.h | |||
@@ -114,5 +114,5 @@ extern long cifs_ioctl(struct file *filep, unsigned int cmd, unsigned long arg); | |||
114 | extern const struct export_operations cifs_export_ops; | 114 | extern const struct export_operations cifs_export_ops; |
115 | #endif /* EXPERIMENTAL */ | 115 | #endif /* EXPERIMENTAL */ |
116 | 116 | ||
117 | #define CIFS_VERSION "1.62" | 117 | #define CIFS_VERSION "1.63" |
118 | #endif /* _CIFSFS_H */ | 118 | #endif /* _CIFSFS_H */ |
diff --git a/fs/cifs/cifssmb.c b/fs/cifs/cifssmb.c index be23e426ffb3..980c38c658b7 100644 --- a/fs/cifs/cifssmb.c +++ b/fs/cifs/cifssmb.c | |||
@@ -1,7 +1,7 @@ | |||
1 | /* | 1 | /* |
2 | * fs/cifs/cifssmb.c | 2 | * fs/cifs/cifssmb.c |
3 | * | 3 | * |
4 | * Copyright (C) International Business Machines Corp., 2002,2009 | 4 | * Copyright (C) International Business Machines Corp., 2002,2010 |
5 | * Author(s): Steve French (sfrench@us.ibm.com) | 5 | * Author(s): Steve French (sfrench@us.ibm.com) |
6 | * | 6 | * |
7 | * Contains the routines for constructing the SMB PDUs themselves | 7 | * Contains the routines for constructing the SMB PDUs themselves |
@@ -493,14 +493,14 @@ CIFSSMBNegotiate(unsigned int xid, struct cifsSesInfo *ses) | |||
493 | goto neg_err_exit; | 493 | goto neg_err_exit; |
494 | } | 494 | } |
495 | 495 | ||
496 | cFYI(1, ("LANMAN negotiated")); | 496 | cFYI(1, "LANMAN negotiated"); |
497 | /* we will not end up setting signing flags - as no signing | 497 | /* we will not end up setting signing flags - as no signing |
498 | was in LANMAN and server did not return the flags on */ | 498 | was in LANMAN and server did not return the flags on */ |
499 | goto signing_check; | 499 | goto signing_check; |
500 | #else /* weak security disabled */ | 500 | #else /* weak security disabled */ |
501 | } else if (pSMBr->hdr.WordCount == 13) { | 501 | } else if (pSMBr->hdr.WordCount == 13) { |
502 | cERROR(1, ("mount failed, cifs module not built " | 502 | cERROR(1, "mount failed, cifs module not built " |
503 | "with CIFS_WEAK_PW_HASH support")); | 503 | "with CIFS_WEAK_PW_HASH support"); |
504 | rc = -EOPNOTSUPP; | 504 | rc = -EOPNOTSUPP; |
505 | #endif /* WEAK_PW_HASH */ | 505 | #endif /* WEAK_PW_HASH */ |
506 | goto neg_err_exit; | 506 | goto neg_err_exit; |
@@ -1513,7 +1513,7 @@ CIFSSMBWrite(const int xid, struct cifsTconInfo *tcon, | |||
1513 | (struct smb_hdr *) pSMBr, &bytes_returned, long_op); | 1513 | (struct smb_hdr *) pSMBr, &bytes_returned, long_op); |
1514 | cifs_stats_inc(&tcon->num_writes); | 1514 | cifs_stats_inc(&tcon->num_writes); |
1515 | if (rc) { | 1515 | if (rc) { |
1516 | cFYI(1, ("Send error in write = %d", rc)); | 1516 | cFYI(1, "Send error in write = %d", rc); |
1517 | } else { | 1517 | } else { |
1518 | *nbytes = le16_to_cpu(pSMBr->CountHigh); | 1518 | *nbytes = le16_to_cpu(pSMBr->CountHigh); |
1519 | *nbytes = (*nbytes) << 16; | 1519 | *nbytes = (*nbytes) << 16; |
@@ -2529,7 +2529,7 @@ validate_ntransact(char *buf, char **ppparm, char **ppdata, | |||
2529 | cFYI(1, "data starts after end of smb"); | 2529 | cFYI(1, "data starts after end of smb"); |
2530 | return -EINVAL; | 2530 | return -EINVAL; |
2531 | } else if (data_count + *ppdata > end_of_smb) { | 2531 | } else if (data_count + *ppdata > end_of_smb) { |
2532 | cFYI(1, "data %p + count %d (%p) ends after end of smb %p start %p", | 2532 | cFYI(1, "data %p + count %d (%p) past smb end %p start %p", |
2533 | *ppdata, data_count, (data_count + *ppdata), | 2533 | *ppdata, data_count, (data_count + *ppdata), |
2534 | end_of_smb, pSMBr); | 2534 | end_of_smb, pSMBr); |
2535 | return -EINVAL; | 2535 | return -EINVAL; |
@@ -3304,7 +3304,7 @@ QFileInfoRetry: | |||
3304 | rc = SendReceive(xid, tcon->ses, (struct smb_hdr *) pSMB, | 3304 | rc = SendReceive(xid, tcon->ses, (struct smb_hdr *) pSMB, |
3305 | (struct smb_hdr *) pSMBr, &bytes_returned, 0); | 3305 | (struct smb_hdr *) pSMBr, &bytes_returned, 0); |
3306 | if (rc) { | 3306 | if (rc) { |
3307 | cFYI(1, ("Send error in QPathInfo = %d", rc)); | 3307 | cFYI(1, "Send error in QPathInfo = %d", rc); |
3308 | } else { /* decode response */ | 3308 | } else { /* decode response */ |
3309 | rc = validate_t2((struct smb_t2_rsp *)pSMBr); | 3309 | rc = validate_t2((struct smb_t2_rsp *)pSMBr); |
3310 | 3310 | ||
@@ -3472,14 +3472,14 @@ UnixQFileInfoRetry: | |||
3472 | rc = SendReceive(xid, tcon->ses, (struct smb_hdr *) pSMB, | 3472 | rc = SendReceive(xid, tcon->ses, (struct smb_hdr *) pSMB, |
3473 | (struct smb_hdr *) pSMBr, &bytes_returned, 0); | 3473 | (struct smb_hdr *) pSMBr, &bytes_returned, 0); |
3474 | if (rc) { | 3474 | if (rc) { |
3475 | cFYI(1, ("Send error in QPathInfo = %d", rc)); | 3475 | cFYI(1, "Send error in QPathInfo = %d", rc); |
3476 | } else { /* decode response */ | 3476 | } else { /* decode response */ |
3477 | rc = validate_t2((struct smb_t2_rsp *)pSMBr); | 3477 | rc = validate_t2((struct smb_t2_rsp *)pSMBr); |
3478 | 3478 | ||
3479 | if (rc || (pSMBr->ByteCount < sizeof(FILE_UNIX_BASIC_INFO))) { | 3479 | if (rc || (pSMBr->ByteCount < sizeof(FILE_UNIX_BASIC_INFO))) { |
3480 | cERROR(1, ("Malformed FILE_UNIX_BASIC_INFO response.\n" | 3480 | cERROR(1, "Malformed FILE_UNIX_BASIC_INFO response.\n" |
3481 | "Unix Extensions can be disabled on mount " | 3481 | "Unix Extensions can be disabled on mount " |
3482 | "by specifying the nosfu mount option.")); | 3482 | "by specifying the nosfu mount option."); |
3483 | rc = -EIO; /* bad smb */ | 3483 | rc = -EIO; /* bad smb */ |
3484 | } else { | 3484 | } else { |
3485 | __u16 data_offset = le16_to_cpu(pSMBr->t2.DataOffset); | 3485 | __u16 data_offset = le16_to_cpu(pSMBr->t2.DataOffset); |
@@ -4037,7 +4037,7 @@ parse_DFS_referrals(TRANSACTION2_GET_DFS_REFER_RSP *pSMBr, | |||
4037 | data_end = (char *)(&(pSMBr->PathConsumed)) + | 4037 | data_end = (char *)(&(pSMBr->PathConsumed)) + |
4038 | le16_to_cpu(pSMBr->t2.DataCount); | 4038 | le16_to_cpu(pSMBr->t2.DataCount); |
4039 | 4039 | ||
4040 | cFYI(1, "num_referrals: %d dfs flags: 0x%x ... \n", | 4040 | cFYI(1, "num_referrals: %d dfs flags: 0x%x ...\n", |
4041 | *num_of_nodes, | 4041 | *num_of_nodes, |
4042 | le32_to_cpu(pSMBr->DFSFlags)); | 4042 | le32_to_cpu(pSMBr->DFSFlags)); |
4043 | 4043 | ||
diff --git a/fs/cifs/file.c b/fs/cifs/file.c index ed3689e6617c..99897e3562a7 100644 --- a/fs/cifs/file.c +++ b/fs/cifs/file.c | |||
@@ -3,7 +3,7 @@ | |||
3 | * | 3 | * |
4 | * vfs operations that deal with files | 4 | * vfs operations that deal with files |
5 | * | 5 | * |
6 | * Copyright (C) International Business Machines Corp., 2002,2007 | 6 | * Copyright (C) International Business Machines Corp., 2002,2010 |
7 | * Author(s): Steve French (sfrench@us.ibm.com) | 7 | * Author(s): Steve French (sfrench@us.ibm.com) |
8 | * Jeremy Allison (jra@samba.org) | 8 | * Jeremy Allison (jra@samba.org) |
9 | * | 9 | * |
@@ -855,9 +855,9 @@ int cifs_lock(struct file *file, int cmd, struct file_lock *pfLock) | |||
855 | 0 /* wait flag */); | 855 | 0 /* wait flag */); |
856 | pfLock->fl_type = F_RDLCK; | 856 | pfLock->fl_type = F_RDLCK; |
857 | if (rc != 0) | 857 | if (rc != 0) |
858 | cERROR(1, ("Error unlocking " | 858 | cERROR(1, "Error unlocking " |
859 | "previously locked range %d " | 859 | "previously locked range %d " |
860 | "during test of lock", rc)); | 860 | "during test of lock", rc); |
861 | rc = 0; | 861 | rc = 0; |
862 | } else { | 862 | } else { |
863 | pfLock->fl_type = F_WRLCK; | 863 | pfLock->fl_type = F_WRLCK; |
@@ -1709,7 +1709,7 @@ int cifs_fsync(struct file *file, struct dentry *dentry, int datasync) | |||
1709 | unsigned int rpages = 0; | 1709 | unsigned int rpages = 0; |
1710 | int rc = 0; | 1710 | int rc = 0; |
1711 | 1711 | ||
1712 | cFYI(1, "sync page %p",page); | 1712 | cFYI(1, "sync page %p", page); |
1713 | mapping = page->mapping; | 1713 | mapping = page->mapping; |
1714 | if (!mapping) | 1714 | if (!mapping) |
1715 | return 0; | 1715 | return 0; |
@@ -1998,7 +1998,7 @@ static int cifs_readpages(struct file *file, struct address_space *mapping, | |||
1998 | cifs_sb = CIFS_SB(file->f_path.dentry->d_sb); | 1998 | cifs_sb = CIFS_SB(file->f_path.dentry->d_sb); |
1999 | pTcon = cifs_sb->tcon; | 1999 | pTcon = cifs_sb->tcon; |
2000 | 2000 | ||
2001 | cFYI(DBG2, ("rpages: num pages %d", num_pages)); | 2001 | cFYI(DBG2, "rpages: num pages %d", num_pages); |
2002 | for (i = 0; i < num_pages; ) { | 2002 | for (i = 0; i < num_pages; ) { |
2003 | unsigned contig_pages; | 2003 | unsigned contig_pages; |
2004 | struct page *tmp_page; | 2004 | struct page *tmp_page; |
@@ -2083,7 +2083,7 @@ static int cifs_readpages(struct file *file, struct address_space *mapping, | |||
2083 | } | 2083 | } |
2084 | } else { | 2084 | } else { |
2085 | cFYI(1, "No bytes read (%d) at offset %lld . " | 2085 | cFYI(1, "No bytes read (%d) at offset %lld . " |
2086 | "Cleaning remaining pages from readahead list", | 2086 | "Cleaning remaining pages from readahead list", |
2087 | bytes_read, offset); | 2087 | bytes_read, offset); |
2088 | /* BB turn off caching and do new lookup on | 2088 | /* BB turn off caching and do new lookup on |
2089 | file size at server? */ | 2089 | file size at server? */ |
diff --git a/fs/cifs/inode.c b/fs/cifs/inode.c index 7524a90aa94f..b35cb031c20c 100644 --- a/fs/cifs/inode.c +++ b/fs/cifs/inode.c | |||
@@ -1,7 +1,7 @@ | |||
1 | /* | 1 | /* |
2 | * fs/cifs/inode.c | 2 | * fs/cifs/inode.c |
3 | * | 3 | * |
4 | * Copyright (C) International Business Machines Corp., 2002,2008 | 4 | * Copyright (C) International Business Machines Corp., 2002,2010 |
5 | * Author(s): Steve French (sfrench@us.ibm.com) | 5 | * Author(s): Steve French (sfrench@us.ibm.com) |
6 | * | 6 | * |
7 | * This library is free software; you can redistribute it and/or modify | 7 | * This library is free software; you can redistribute it and/or modify |
@@ -86,30 +86,30 @@ cifs_revalidate_cache(struct inode *inode, struct cifs_fattr *fattr) | |||
86 | { | 86 | { |
87 | struct cifsInodeInfo *cifs_i = CIFS_I(inode); | 87 | struct cifsInodeInfo *cifs_i = CIFS_I(inode); |
88 | 88 | ||
89 | cFYI(1, ("%s: revalidating inode %llu", __func__, cifs_i->uniqueid)); | 89 | cFYI(1, "%s: revalidating inode %llu", __func__, cifs_i->uniqueid); |
90 | 90 | ||
91 | if (inode->i_state & I_NEW) { | 91 | if (inode->i_state & I_NEW) { |
92 | cFYI(1, ("%s: inode %llu is new", __func__, cifs_i->uniqueid)); | 92 | cFYI(1, "%s: inode %llu is new", __func__, cifs_i->uniqueid); |
93 | return; | 93 | return; |
94 | } | 94 | } |
95 | 95 | ||
96 | /* don't bother with revalidation if we have an oplock */ | 96 | /* don't bother with revalidation if we have an oplock */ |
97 | if (cifs_i->clientCanCacheRead) { | 97 | if (cifs_i->clientCanCacheRead) { |
98 | cFYI(1, ("%s: inode %llu is oplocked", __func__, | 98 | cFYI(1, "%s: inode %llu is oplocked", __func__, |
99 | cifs_i->uniqueid)); | 99 | cifs_i->uniqueid); |
100 | return; | 100 | return; |
101 | } | 101 | } |
102 | 102 | ||
103 | /* revalidate if mtime or size have changed */ | 103 | /* revalidate if mtime or size have changed */ |
104 | if (timespec_equal(&inode->i_mtime, &fattr->cf_mtime) && | 104 | if (timespec_equal(&inode->i_mtime, &fattr->cf_mtime) && |
105 | cifs_i->server_eof == fattr->cf_eof) { | 105 | cifs_i->server_eof == fattr->cf_eof) { |
106 | cFYI(1, ("%s: inode %llu is unchanged", __func__, | 106 | cFYI(1, "%s: inode %llu is unchanged", __func__, |
107 | cifs_i->uniqueid)); | 107 | cifs_i->uniqueid); |
108 | return; | 108 | return; |
109 | } | 109 | } |
110 | 110 | ||
111 | cFYI(1, ("%s: invalidating inode %llu mapping", __func__, | 111 | cFYI(1, "%s: invalidating inode %llu mapping", __func__, |
112 | cifs_i->uniqueid)); | 112 | cifs_i->uniqueid); |
113 | cifs_i->invalid_mapping = true; | 113 | cifs_i->invalid_mapping = true; |
114 | } | 114 | } |
115 | 115 | ||
@@ -1577,9 +1577,9 @@ int cifs_revalidate_dentry(struct dentry *dentry) | |||
1577 | goto check_inval; | 1577 | goto check_inval; |
1578 | } | 1578 | } |
1579 | 1579 | ||
1580 | cFYI(1, ("Revalidate: %s inode 0x%p count %d dentry: 0x%p d_time %ld " | 1580 | cFYI(1, "Revalidate: %s inode 0x%p count %d dentry: 0x%p d_time %ld " |
1581 | "jiffies %ld", full_path, inode, inode->i_count.counter, | 1581 | "jiffies %ld", full_path, inode, inode->i_count.counter, |
1582 | dentry, dentry->d_time, jiffies)); | 1582 | dentry, dentry->d_time, jiffies); |
1583 | 1583 | ||
1584 | if (CIFS_SB(sb)->tcon->unix_ext) | 1584 | if (CIFS_SB(sb)->tcon->unix_ext) |
1585 | rc = cifs_get_inode_info_unix(&inode, full_path, sb, xid); | 1585 | rc = cifs_get_inode_info_unix(&inode, full_path, sb, xid); |