diff options
author | Miklos Szeredi <mszeredi@suse.cz> | 2013-09-16 08:51:59 -0400 |
---|---|---|
committer | Al Viro <viro@zeniv.linux.org.uk> | 2013-09-16 19:17:24 -0400 |
commit | dfb1d61b0e9f9e2c542e9adc8d970689f4114ff6 (patch) | |
tree | 7cb3e3a9742cee2298e90db10d1f07b517cf66c8 /fs/cifs | |
parent | 0854d450e229e37102a76e3ccf065d8e8137846f (diff) |
cifs: fix filp leak in cifs_atomic_open()
If an error occurs after having called finish_open() then fput() needs to
be called on the already opened file.
Signed-off-by: Miklos Szeredi <mszeredi@suse.cz>
Cc: Steve French <sfrench@samba.org>
Cc: stable@vger.kernel.org
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'fs/cifs')
-rw-r--r-- | fs/cifs/dir.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/fs/cifs/dir.c b/fs/cifs/dir.c index d3e2eaa503a6..5384c2a640ca 100644 --- a/fs/cifs/dir.c +++ b/fs/cifs/dir.c | |||
@@ -500,6 +500,7 @@ cifs_atomic_open(struct inode *inode, struct dentry *direntry, | |||
500 | if (server->ops->close) | 500 | if (server->ops->close) |
501 | server->ops->close(xid, tcon, &fid); | 501 | server->ops->close(xid, tcon, &fid); |
502 | cifs_del_pending_open(&open); | 502 | cifs_del_pending_open(&open); |
503 | fput(file); | ||
503 | rc = -ENOMEM; | 504 | rc = -ENOMEM; |
504 | } | 505 | } |
505 | 506 | ||