[PATCH] kfree cleanup: fs

This is the fs/ part of the big kfree cleanup patch.

Remove pointless checks for NULL prior to calling kfree() in fs/.

Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

5 files changed, 45 insertions, 92 deletions

diff --git a/fs/cifs/asn1.c b/fs/cifs/asn1.c
index 98539e2afe81..086ae8f4a207 100644
--- a/fs/cifs/asn1.c
+++ b/fs/cifs/asn1.c
@@ -553,8 +553,7 @@ decode_negTokenInit(unsigned char *security_blob, int length,
                                            *(oid + 3)));
                                         rc = compare_oid(oid, oidlen, NTLMSSP_OID,
                                                  NTLMSSP_OID_LEN);
-                                        if(oid)
-                                                kfree(oid);
+                                        kfree(oid);
                                         if (rc)
                                                 use_ntlmssp = TRUE;
                                 }
diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c
index d74367a08d51..450ab75d6546 100644
--- a/fs/cifs/connect.c
+++ b/fs/cifs/connect.c
@@ -1265,8 +1265,7 @@ connect_to_dfs_path(int xid, struct cifsSesInfo *pSesInfo,
                 the helper that resolves tcp names, mount to it, try to 
                 tcon to it unmount it if fail */
 
-        if(referrals)
-                kfree(referrals);
+        kfree(referrals);
 
         return rc;
 }
@@ -1535,10 +1534,8 @@ cifs_mount(struct super_block *sb, struct cifs_sb_info *cifs_sb,
         
         memset(&volume_info,0,sizeof(struct smb_vol));
         if (cifs_parse_mount_options(mount_data, devname, &volume_info)) {
-                if(volume_info.UNC)
-                        kfree(volume_info.UNC);
-                if(volume_info.password)
-                        kfree(volume_info.password);
+                kfree(volume_info.UNC);
+                kfree(volume_info.password);
                 FreeXid(xid);
                 return -EINVAL;
         }
@@ -1551,10 +1548,8 @@ cifs_mount(struct super_block *sb, struct cifs_sb_info *cifs_sb,
                 cifserror("No username specified ");
         /* In userspace mount helper we can get user name from alternate
            locations such as env variables and files on disk */
-                if(volume_info.UNC)
-                        kfree(volume_info.UNC);
-                if(volume_info.password)
-                        kfree(volume_info.password);
+                kfree(volume_info.UNC);
+                kfree(volume_info.password);
                 FreeXid(xid);
                 return -EINVAL;
         }
@@ -1573,10 +1568,8 @@ cifs_mount(struct super_block *sb, struct cifs_sb_info *cifs_sb,
        
                 if(rc <= 0) {
                         /* we failed translating address */
-                        if(volume_info.UNC)
-                                kfree(volume_info.UNC);
-                        if(volume_info.password)
-                                kfree(volume_info.password);
+                        kfree(volume_info.UNC);
+                        kfree(volume_info.password);
                         FreeXid(xid);
                         return -EINVAL;
                 }
@@ -1587,19 +1580,15 @@ cifs_mount(struct super_block *sb, struct cifs_sb_info *cifs_sb,
         } else if (volume_info.UNCip){
                 /* BB using ip addr as server name connect to the DFS root below */
                 cERROR(1,("Connecting to DFS root not implemented yet"));
-                if(volume_info.UNC)
-                        kfree(volume_info.UNC);
-                if(volume_info.password)
-                        kfree(volume_info.password);
+                kfree(volume_info.UNC);
+                kfree(volume_info.password);
                 FreeXid(xid);
                 return -EINVAL;
         } else /* which servers DFS root would we conect to */ {
                 cERROR(1,
                        ("CIFS mount error: No UNC path (e.g. -o unc=//192.168.1.100/public) specified  "));
-                if(volume_info.UNC)
-                        kfree(volume_info.UNC);
-                if(volume_info.password)
-                        kfree(volume_info.password);
+                kfree(volume_info.UNC);
+                kfree(volume_info.password);
                 FreeXid(xid);
                 return -EINVAL;
         }
@@ -1612,10 +1601,8 @@ cifs_mount(struct super_block *sb, struct cifs_sb_info *cifs_sb,
                 cifs_sb->local_nls = load_nls(volume_info.iocharset);
                 if(cifs_sb->local_nls == NULL) {
                         cERROR(1,("CIFS mount error: iocharset %s not found",volume_info.iocharset));
-                        if(volume_info.UNC)
-                                kfree(volume_info.UNC);
-                        if(volume_info.password)
-                                kfree(volume_info.password);
+                        kfree(volume_info.UNC);
+                        kfree(volume_info.password);
                         FreeXid(xid);
                         return -ELIBACC;
                 }
@@ -1630,10 +1617,8 @@ cifs_mount(struct super_block *sb, struct cifs_sb_info *cifs_sb,
                         &sin_server6.sin6_addr,
                         volume_info.username, &srvTcp);
         else {
-                if(volume_info.UNC)
-                        kfree(volume_info.UNC);
-                if(volume_info.password)
-                        kfree(volume_info.password);
+                kfree(volume_info.UNC);
+                kfree(volume_info.password);
                 FreeXid(xid);
                 return -EINVAL;
         }
@@ -1654,10 +1639,8 @@ cifs_mount(struct super_block *sb, struct cifs_sb_info *cifs_sb,
                                ("Error connecting to IPv4 socket. Aborting operation"));
                         if(csocket != NULL)
                                 sock_release(csocket);
-                        if(volume_info.UNC)
-                                kfree(volume_info.UNC);
-                        if(volume_info.password)
-                                kfree(volume_info.password);
+                        kfree(volume_info.UNC);
+                        kfree(volume_info.password);
                         FreeXid(xid);
                         return rc;
                 }
@@ -1666,10 +1649,8 @@ cifs_mount(struct super_block *sb, struct cifs_sb_info *cifs_sb,
                 if (srvTcp == NULL) {
                         rc = -ENOMEM;
                         sock_release(csocket);
-                        if(volume_info.UNC)
-                                kfree(volume_info.UNC);
-                        if(volume_info.password)
-                                kfree(volume_info.password);
+                        kfree(volume_info.UNC);
+                        kfree(volume_info.password);
                         FreeXid(xid);
                         return rc;
                 } else {
@@ -1692,10 +1673,8 @@ cifs_mount(struct super_block *sb, struct cifs_sb_info *cifs_sb,
                         if(rc < 0) {
                                 rc = -ENOMEM;
                                 sock_release(csocket);
-                                if(volume_info.UNC)
-                                        kfree(volume_info.UNC);
-                                if(volume_info.password)
-                                        kfree(volume_info.password);
+                                kfree(volume_info.UNC);
+                                kfree(volume_info.password);
                                 FreeXid(xid);
                                 return rc;
                         }
@@ -1710,8 +1689,7 @@ cifs_mount(struct super_block *sb, struct cifs_sb_info *cifs_sb,
         if (existingCifsSes) {
                 pSesInfo = existingCifsSes;
                 cFYI(1, ("Existing smb sess found "));
-                if(volume_info.password)
-                        kfree(volume_info.password);
+                kfree(volume_info.password);
                 /* volume_info.UNC freed at end of function */
         } else if (!rc) {
                 cFYI(1, ("Existing smb sess not found "));
@@ -1741,8 +1719,7 @@ cifs_mount(struct super_block *sb, struct cifs_sb_info *cifs_sb,
                         if(!rc)
                                 atomic_inc(&srvTcp->socketUseCount);
                 } else
-                        if(volume_info.password)
-                                kfree(volume_info.password);
+                        kfree(volume_info.password);
         }
     
         /* search for existing tcon to this server share */
@@ -1821,8 +1798,7 @@ cifs_mount(struct super_block *sb, struct cifs_sb_info *cifs_sb,
                                                         "", cifs_sb->local_nls,
                                                         cifs_sb->mnt_cifs_flags & 
                                                           CIFS_MOUNT_MAP_SPECIAL_CHR);
-                                        if(volume_info.UNC)
-                                                kfree(volume_info.UNC);
+                                        kfree(volume_info.UNC);
                                         FreeXid(xid);
                                         return -ENODEV;
                                 } else {
@@ -1925,8 +1901,7 @@ cifs_mount(struct super_block *sb, struct cifs_sb_info *cifs_sb,
         (in which case it is not needed anymore) but when new sesion is created
         the password ptr is put in the new session structure (in which case the
         password will be freed at unmount time) */
-        if(volume_info.UNC)
-                kfree(volume_info.UNC);
+        kfree(volume_info.UNC);
         FreeXid(xid);
         return rc;
 }
@@ -3283,8 +3258,7 @@ CIFSTCon(unsigned int xid, struct cifsSesInfo *ses,
                         if ((bcc_ptr + (2 * length)) -
                              pByteArea(smb_buffer_response) <=
                             BCC(smb_buffer_response)) {
-                                if(tcon->nativeFileSystem)
-                                        kfree(tcon->nativeFileSystem);
+                                kfree(tcon->nativeFileSystem);
                                 tcon->nativeFileSystem =
                                     kzalloc(length + 2, GFP_KERNEL);
                                 cifs_strfromUCS_le(tcon->nativeFileSystem,
@@ -3301,8 +3275,7 @@ CIFSTCon(unsigned int xid, struct cifsSesInfo *ses,
                         if ((bcc_ptr + length) -
                             pByteArea(smb_buffer_response) <=
                             BCC(smb_buffer_response)) {
-                                if(tcon->nativeFileSystem)
-                                        kfree(tcon->nativeFileSystem);
+                                kfree(tcon->nativeFileSystem);
                                 tcon->nativeFileSystem =
                                     kzalloc(length + 1, GFP_KERNEL);
                                 strncpy(tcon->nativeFileSystem, bcc_ptr,
diff --git a/fs/cifs/link.c b/fs/cifs/link.c
index b43e071fe110..0f99aae33162 100644
--- a/fs/cifs/link.c
+++ b/fs/cifs/link.c
@@ -84,10 +84,8 @@ cifs_hardlink(struct dentry *old_file, struct inode *inode,
         cifsInode->time = 0;    /* will force revalidate to go get info when needed */
 
 cifs_hl_exit:
-        if (fromName)
-                kfree(fromName);
-        if (toName)
-                kfree(toName);
+        kfree(fromName);
+        kfree(toName);
         FreeXid(xid);
         return rc;
 }
@@ -206,8 +204,7 @@ cifs_symlink(struct inode *inode, struct dentry *direntry, const char *symname)
                 }
         }
 
-        if (full_path)
-                kfree(full_path);
+        kfree(full_path);
         FreeXid(xid);
         return rc;
 }
@@ -253,8 +250,7 @@ cifs_readlink(struct dentry *direntry, char __user *pBuffer, int buflen)
                 len = buflen;
         tmpbuffer = kmalloc(len,GFP_KERNEL);   
         if(tmpbuffer == NULL) {
-                if (full_path)
-                        kfree(full_path);
+                kfree(full_path);
                 FreeXid(xid);
                 return -ENOMEM;
         }
@@ -303,8 +299,7 @@ cifs_readlink(struct dentry *direntry, char __user *pBuffer, int buflen)
                                                         strncpy(tmpbuffer, referrals, len-1);                            
                                                 }
                                         }
-                                        if(referrals)
-                                                kfree(referrals);
+                                        kfree(referrals);
                                         kfree(tmp_path);
 }
                                 /* BB add code like else decode referrals then memcpy to
@@ -323,12 +318,8 @@ cifs_readlink(struct dentry *direntry, char __user *pBuffer, int buflen)
                       rc));
         }
 
-        if (tmpbuffer) {
-                kfree(tmpbuffer);
-        }
-        if (full_path) {
-                kfree(full_path);
-        }
+        kfree(tmpbuffer);
+        kfree(full_path);
         FreeXid(xid);
         return rc;
 }
diff --git a/fs/cifs/misc.c b/fs/cifs/misc.c
index eba1de917f2a..34a06692e4fa 100644
--- a/fs/cifs/misc.c
+++ b/fs/cifs/misc.c
@@ -98,14 +98,10 @@ sesInfoFree(struct cifsSesInfo *buf_to_free)
         atomic_dec(&sesInfoAllocCount);
         list_del(&buf_to_free->cifsSessionList);
         write_unlock(&GlobalSMBSeslock);
-        if (buf_to_free->serverOS)
-                kfree(buf_to_free->serverOS);
-        if (buf_to_free->serverDomain)
-                kfree(buf_to_free->serverDomain);
-        if (buf_to_free->serverNOS)
-                kfree(buf_to_free->serverNOS);
-        if (buf_to_free->password)
-                kfree(buf_to_free->password);
+        kfree(buf_to_free->serverOS);
+        kfree(buf_to_free->serverDomain);
+        kfree(buf_to_free->serverNOS);
+        kfree(buf_to_free->password);
         kfree(buf_to_free);
 }
 
@@ -144,8 +140,7 @@ tconInfoFree(struct cifsTconInfo *buf_to_free)
         atomic_dec(&tconInfoAllocCount);
         list_del(&buf_to_free->cifsConnectionList);
         write_unlock(&GlobalSMBSeslock);
-        if (buf_to_free->nativeFileSystem)
-                kfree(buf_to_free->nativeFileSystem);
+        kfree(buf_to_free->nativeFileSystem);
         kfree(buf_to_free);
 }
 
diff --git a/fs/cifs/xattr.c b/fs/cifs/xattr.c
index c1e02eff1d25..f375f87c7dbd 100644
--- a/fs/cifs/xattr.c
+++ b/fs/cifs/xattr.c
@@ -87,8 +87,7 @@ int cifs_removexattr(struct dentry * direntry, const char * ea_name)
                         cifs_sb->mnt_cifs_flags & CIFS_MOUNT_MAP_SPECIAL_CHR);
         }
 remove_ea_exit:
-        if (full_path)
-                kfree(full_path);
+        kfree(full_path);
         FreeXid(xid);
 #endif
         return rc;
@@ -132,8 +131,7 @@ int cifs_setxattr(struct dentry * direntry, const char * ea_name,
                 returns as xattrs */
         if(value_size > MAX_EA_VALUE_SIZE) {
                 cFYI(1,("size of EA value too large"));
-                if(full_path)
-                        kfree(full_path);
+                kfree(full_path);
                 FreeXid(xid);
                 return -EOPNOTSUPP;
         }
@@ -195,8 +193,7 @@ int cifs_setxattr(struct dentry * direntry, const char * ea_name,
         }
 
 set_ea_exit:
-        if (full_path)
-                kfree(full_path);
+        kfree(full_path);
         FreeXid(xid);
 #endif
         return rc;
@@ -298,8 +295,7 @@ ssize_t cifs_getxattr(struct dentry * direntry, const char * ea_name,
                 rc = -EOPNOTSUPP; 
 
 get_ea_exit:
-        if (full_path)
-                kfree(full_path);
+        kfree(full_path);
         FreeXid(xid);
 #endif
         return rc;
@@ -345,8 +341,7 @@ ssize_t cifs_listxattr(struct dentry * direntry, char * data, size_t buf_size)
                                 cifs_sb->mnt_cifs_flags & 
                                         CIFS_MOUNT_MAP_SPECIAL_CHR);
 
-        if (full_path)
-                kfree(full_path);
+        kfree(full_path);
         FreeXid(xid);
 #endif
         return rc;