diff options
author | Al Viro <viro@zeniv.linux.org.uk> | 2012-06-22 04:40:19 -0400 |
---|---|---|
committer | Al Viro <viro@zeniv.linux.org.uk> | 2012-07-14 08:33:39 -0400 |
commit | 30d904947459cca2beb69e0110716f5248b31f2a (patch) | |
tree | 024e2a913266377d234147b14b7eb37017546173 /fs/cifs | |
parent | a4a3bdd778715999ddfeefdc52ab76254580fa76 (diff) |
kill struct opendata
Just pass struct file *. Methods are happier that way...
There's no need to return struct file * from finish_open() now,
so let it return int. Next: saner prototypes for parts in
namei.c
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'fs/cifs')
-rw-r--r-- | fs/cifs/cifsfs.h | 2 | ||||
-rw-r--r-- | fs/cifs/dir.c | 9 |
2 files changed, 5 insertions, 6 deletions
diff --git a/fs/cifs/cifsfs.h b/fs/cifs/cifsfs.h index 58d9aca46a40..48bb474ce294 100644 --- a/fs/cifs/cifsfs.h +++ b/fs/cifs/cifsfs.h | |||
@@ -47,7 +47,7 @@ extern struct inode *cifs_root_iget(struct super_block *); | |||
47 | extern int cifs_create(struct inode *, struct dentry *, umode_t, | 47 | extern int cifs_create(struct inode *, struct dentry *, umode_t, |
48 | struct nameidata *); | 48 | struct nameidata *); |
49 | extern int cifs_atomic_open(struct inode *, struct dentry *, | 49 | extern int cifs_atomic_open(struct inode *, struct dentry *, |
50 | struct opendata *, unsigned, umode_t, | 50 | struct file *, unsigned, umode_t, |
51 | int *); | 51 | int *); |
52 | extern struct dentry *cifs_lookup(struct inode *, struct dentry *, | 52 | extern struct dentry *cifs_lookup(struct inode *, struct dentry *, |
53 | struct nameidata *); | 53 | struct nameidata *); |
diff --git a/fs/cifs/dir.c b/fs/cifs/dir.c index 8ca70b102b95..c00c192f17e9 100644 --- a/fs/cifs/dir.c +++ b/fs/cifs/dir.c | |||
@@ -378,7 +378,7 @@ out: | |||
378 | 378 | ||
379 | int | 379 | int |
380 | cifs_atomic_open(struct inode *inode, struct dentry *direntry, | 380 | cifs_atomic_open(struct inode *inode, struct dentry *direntry, |
381 | struct opendata *od, unsigned oflags, umode_t mode, | 381 | struct file *file, unsigned oflags, umode_t mode, |
382 | int *opened) | 382 | int *opened) |
383 | { | 383 | { |
384 | int rc; | 384 | int rc; |
@@ -405,7 +405,7 @@ cifs_atomic_open(struct inode *inode, struct dentry *direntry, | |||
405 | if (IS_ERR(res)) | 405 | if (IS_ERR(res)) |
406 | return PTR_ERR(res); | 406 | return PTR_ERR(res); |
407 | 407 | ||
408 | finish_no_open(od, res); | 408 | finish_no_open(file, res); |
409 | return 1; | 409 | return 1; |
410 | } | 410 | } |
411 | 411 | ||
@@ -431,9 +431,8 @@ cifs_atomic_open(struct inode *inode, struct dentry *direntry, | |||
431 | if (rc) | 431 | if (rc) |
432 | goto out; | 432 | goto out; |
433 | 433 | ||
434 | filp = finish_open(od, direntry, generic_file_open, opened); | 434 | rc = finish_open(file, direntry, generic_file_open, opened); |
435 | if (IS_ERR(filp)) { | 435 | if (rc) { |
436 | rc = PTR_ERR(filp); | ||
437 | CIFSSMBClose(xid, tcon, fileHandle); | 436 | CIFSSMBClose(xid, tcon, fileHandle); |
438 | goto out; | 437 | goto out; |
439 | } | 438 | } |