diff options
author | Jesper Juhl <jesper.juhl@gmail.com> | 2005-11-07 04:01:34 -0500 |
---|---|---|
committer | Linus Torvalds <torvalds@g5.osdl.org> | 2005-11-07 10:54:06 -0500 |
commit | f99d49adf527fa6f7a9c42257fa76bca6b8df1e3 (patch) | |
tree | 41dddbc336016f9dc9557cdb15300de5e599dac1 /fs/cifs/xattr.c | |
parent | 6044ec8882c726e325017bd948aa0cd94ad33abc (diff) |
[PATCH] kfree cleanup: fs
This is the fs/ part of the big kfree cleanup patch.
Remove pointless checks for NULL prior to calling kfree() in fs/.
Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'fs/cifs/xattr.c')
-rw-r--r-- | fs/cifs/xattr.c | 15 |
1 files changed, 5 insertions, 10 deletions
diff --git a/fs/cifs/xattr.c b/fs/cifs/xattr.c index c1e02eff1d25..f375f87c7dbd 100644 --- a/fs/cifs/xattr.c +++ b/fs/cifs/xattr.c | |||
@@ -87,8 +87,7 @@ int cifs_removexattr(struct dentry * direntry, const char * ea_name) | |||
87 | cifs_sb->mnt_cifs_flags & CIFS_MOUNT_MAP_SPECIAL_CHR); | 87 | cifs_sb->mnt_cifs_flags & CIFS_MOUNT_MAP_SPECIAL_CHR); |
88 | } | 88 | } |
89 | remove_ea_exit: | 89 | remove_ea_exit: |
90 | if (full_path) | 90 | kfree(full_path); |
91 | kfree(full_path); | ||
92 | FreeXid(xid); | 91 | FreeXid(xid); |
93 | #endif | 92 | #endif |
94 | return rc; | 93 | return rc; |
@@ -132,8 +131,7 @@ int cifs_setxattr(struct dentry * direntry, const char * ea_name, | |||
132 | returns as xattrs */ | 131 | returns as xattrs */ |
133 | if(value_size > MAX_EA_VALUE_SIZE) { | 132 | if(value_size > MAX_EA_VALUE_SIZE) { |
134 | cFYI(1,("size of EA value too large")); | 133 | cFYI(1,("size of EA value too large")); |
135 | if(full_path) | 134 | kfree(full_path); |
136 | kfree(full_path); | ||
137 | FreeXid(xid); | 135 | FreeXid(xid); |
138 | return -EOPNOTSUPP; | 136 | return -EOPNOTSUPP; |
139 | } | 137 | } |
@@ -195,8 +193,7 @@ int cifs_setxattr(struct dentry * direntry, const char * ea_name, | |||
195 | } | 193 | } |
196 | 194 | ||
197 | set_ea_exit: | 195 | set_ea_exit: |
198 | if (full_path) | 196 | kfree(full_path); |
199 | kfree(full_path); | ||
200 | FreeXid(xid); | 197 | FreeXid(xid); |
201 | #endif | 198 | #endif |
202 | return rc; | 199 | return rc; |
@@ -298,8 +295,7 @@ ssize_t cifs_getxattr(struct dentry * direntry, const char * ea_name, | |||
298 | rc = -EOPNOTSUPP; | 295 | rc = -EOPNOTSUPP; |
299 | 296 | ||
300 | get_ea_exit: | 297 | get_ea_exit: |
301 | if (full_path) | 298 | kfree(full_path); |
302 | kfree(full_path); | ||
303 | FreeXid(xid); | 299 | FreeXid(xid); |
304 | #endif | 300 | #endif |
305 | return rc; | 301 | return rc; |
@@ -345,8 +341,7 @@ ssize_t cifs_listxattr(struct dentry * direntry, char * data, size_t buf_size) | |||
345 | cifs_sb->mnt_cifs_flags & | 341 | cifs_sb->mnt_cifs_flags & |
346 | CIFS_MOUNT_MAP_SPECIAL_CHR); | 342 | CIFS_MOUNT_MAP_SPECIAL_CHR); |
347 | 343 | ||
348 | if (full_path) | 344 | kfree(full_path); |
349 | kfree(full_path); | ||
350 | FreeXid(xid); | 345 | FreeXid(xid); |
351 | #endif | 346 | #endif |
352 | return rc; | 347 | return rc; |