diff options
author | Steve French <sfrench@us.ibm.com> | 2007-07-06 18:44:50 -0400 |
---|---|---|
committer | Steve French <sfrench@us.ibm.com> | 2007-07-06 18:44:50 -0400 |
commit | 79a58d1f6075bc0029c38836be9790917a69a342 (patch) | |
tree | 88159126918cbe653cac62725237e2e9fd7f4b0c /fs/cifs/transport.c | |
parent | d20acd09e3bf89aa23af034b8c2d0f5653577ea9 (diff) |
[CIFS] whitespace cleanup
checkpatch.pl redux
Signed-off-by: Steve French <sfrench@us.ibm.com>
Diffstat (limited to 'fs/cifs/transport.c')
-rw-r--r-- | fs/cifs/transport.c | 226 |
1 files changed, 113 insertions, 113 deletions
diff --git a/fs/cifs/transport.c b/fs/cifs/transport.c index 5f468459a1e2..01b589163bd8 100644 --- a/fs/cifs/transport.c +++ b/fs/cifs/transport.c | |||
@@ -1,10 +1,10 @@ | |||
1 | /* | 1 | /* |
2 | * fs/cifs/transport.c | 2 | * fs/cifs/transport.c |
3 | * | 3 | * |
4 | * Copyright (C) International Business Machines Corp., 2002,2005 | 4 | * Copyright (C) International Business Machines Corp., 2002,2007 |
5 | * Author(s): Steve French (sfrench@us.ibm.com) | 5 | * Author(s): Steve French (sfrench@us.ibm.com) |
6 | * Jeremy Allison (jra@samba.org) 2006. | 6 | * Jeremy Allison (jra@samba.org) 2006. |
7 | * | 7 | * |
8 | * This library is free software; you can redistribute it and/or modify | 8 | * This library is free software; you can redistribute it and/or modify |
9 | * it under the terms of the GNU Lesser General Public License as published | 9 | * it under the terms of the GNU Lesser General Public License as published |
10 | * by the Free Software Foundation; either version 2.1 of the License, or | 10 | * by the Free Software Foundation; either version 2.1 of the License, or |
@@ -17,7 +17,7 @@ | |||
17 | * | 17 | * |
18 | * You should have received a copy of the GNU Lesser General Public License | 18 | * You should have received a copy of the GNU Lesser General Public License |
19 | * along with this library; if not, write to the Free Software | 19 | * along with this library; if not, write to the Free Software |
20 | * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA | 20 | * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA |
21 | */ | 21 | */ |
22 | 22 | ||
23 | #include <linux/fs.h> | 23 | #include <linux/fs.h> |
@@ -86,7 +86,7 @@ DeleteMidQEntry(struct mid_q_entry *midEntry) | |||
86 | list_del(&midEntry->qhead); | 86 | list_del(&midEntry->qhead); |
87 | atomic_dec(&midCount); | 87 | atomic_dec(&midCount); |
88 | spin_unlock(&GlobalMid_Lock); | 88 | spin_unlock(&GlobalMid_Lock); |
89 | if(midEntry->largeBuf) | 89 | if (midEntry->largeBuf) |
90 | cifs_buf_release(midEntry->resp_buf); | 90 | cifs_buf_release(midEntry->resp_buf); |
91 | else | 91 | else |
92 | cifs_small_buf_release(midEntry->resp_buf); | 92 | cifs_small_buf_release(midEntry->resp_buf); |
@@ -94,8 +94,8 @@ DeleteMidQEntry(struct mid_q_entry *midEntry) | |||
94 | now = jiffies; | 94 | now = jiffies; |
95 | /* commands taking longer than one second are indications that | 95 | /* commands taking longer than one second are indications that |
96 | something is wrong, unless it is quite a slow link or server */ | 96 | something is wrong, unless it is quite a slow link or server */ |
97 | if((now - midEntry->when_alloc) > HZ) { | 97 | if ((now - midEntry->when_alloc) > HZ) { |
98 | if((cifsFYI & CIFS_TIMER) && | 98 | if ((cifsFYI & CIFS_TIMER) && |
99 | (midEntry->command != SMB_COM_LOCKING_ANDX)) { | 99 | (midEntry->command != SMB_COM_LOCKING_ANDX)) { |
100 | printk(KERN_DEBUG " CIFS slow rsp: cmd %d mid %d", | 100 | printk(KERN_DEBUG " CIFS slow rsp: cmd %d mid %d", |
101 | midEntry->command, midEntry->mid); | 101 | midEntry->command, midEntry->mid); |
@@ -110,10 +110,10 @@ DeleteMidQEntry(struct mid_q_entry *midEntry) | |||
110 | } | 110 | } |
111 | 111 | ||
112 | struct oplock_q_entry * | 112 | struct oplock_q_entry * |
113 | AllocOplockQEntry(struct inode * pinode, __u16 fid, struct cifsTconInfo * tcon) | 113 | AllocOplockQEntry(struct inode *pinode, __u16 fid, struct cifsTconInfo *tcon) |
114 | { | 114 | { |
115 | struct oplock_q_entry *temp; | 115 | struct oplock_q_entry *temp; |
116 | if ((pinode== NULL) || (tcon == NULL)) { | 116 | if ((pinode == NULL) || (tcon == NULL)) { |
117 | cERROR(1, ("Null parms passed to AllocOplockQEntry")); | 117 | cERROR(1, ("Null parms passed to AllocOplockQEntry")); |
118 | return NULL; | 118 | return NULL; |
119 | } | 119 | } |
@@ -133,9 +133,9 @@ AllocOplockQEntry(struct inode * pinode, __u16 fid, struct cifsTconInfo * tcon) | |||
133 | 133 | ||
134 | } | 134 | } |
135 | 135 | ||
136 | void DeleteOplockQEntry(struct oplock_q_entry * oplockEntry) | 136 | void DeleteOplockQEntry(struct oplock_q_entry *oplockEntry) |
137 | { | 137 | { |
138 | spin_lock(&GlobalMid_Lock); | 138 | spin_lock(&GlobalMid_Lock); |
139 | /* should we check if list empty first? */ | 139 | /* should we check if list empty first? */ |
140 | list_del(&oplockEntry->qhead); | 140 | list_del(&oplockEntry->qhead); |
141 | spin_unlock(&GlobalMid_Lock); | 141 | spin_unlock(&GlobalMid_Lock); |
@@ -152,7 +152,7 @@ smb_send(struct socket *ssocket, struct smb_hdr *smb_buffer, | |||
152 | struct kvec iov; | 152 | struct kvec iov; |
153 | unsigned len = smb_buf_length + 4; | 153 | unsigned len = smb_buf_length + 4; |
154 | 154 | ||
155 | if(ssocket == NULL) | 155 | if (ssocket == NULL) |
156 | return -ENOTSOCK; /* BB eventually add reconnect code here */ | 156 | return -ENOTSOCK; /* BB eventually add reconnect code here */ |
157 | iov.iov_base = smb_buffer; | 157 | iov.iov_base = smb_buffer; |
158 | iov.iov_len = len; | 158 | iov.iov_len = len; |
@@ -164,8 +164,8 @@ smb_send(struct socket *ssocket, struct smb_hdr *smb_buffer, | |||
164 | smb_msg.msg_flags = MSG_DONTWAIT + MSG_NOSIGNAL; /* BB add more flags?*/ | 164 | smb_msg.msg_flags = MSG_DONTWAIT + MSG_NOSIGNAL; /* BB add more flags?*/ |
165 | 165 | ||
166 | /* smb header is converted in header_assemble. bcc and rest of SMB word | 166 | /* smb header is converted in header_assemble. bcc and rest of SMB word |
167 | area, and byte area if necessary, is converted to littleendian in | 167 | area, and byte area if necessary, is converted to littleendian in |
168 | cifssmb.c and RFC1001 len is converted to bigendian in smb_send | 168 | cifssmb.c and RFC1001 len is converted to bigendian in smb_send |
169 | Flags2 is converted in SendReceive */ | 169 | Flags2 is converted in SendReceive */ |
170 | 170 | ||
171 | smb_buffer->smb_buf_length = cpu_to_be32(smb_buffer->smb_buf_length); | 171 | smb_buffer->smb_buf_length = cpu_to_be32(smb_buffer->smb_buf_length); |
@@ -177,9 +177,9 @@ smb_send(struct socket *ssocket, struct smb_hdr *smb_buffer, | |||
177 | if ((rc == -ENOSPC) || (rc == -EAGAIN)) { | 177 | if ((rc == -ENOSPC) || (rc == -EAGAIN)) { |
178 | i++; | 178 | i++; |
179 | /* smaller timeout here than send2 since smaller size */ | 179 | /* smaller timeout here than send2 since smaller size */ |
180 | /* Although it may not be required, this also is smaller | 180 | /* Although it may not be required, this also is smaller |
181 | oplock break time */ | 181 | oplock break time */ |
182 | if(i > 12) { | 182 | if (i > 12) { |
183 | cERROR(1, | 183 | cERROR(1, |
184 | ("sends on sock %p stuck for 7 seconds", | 184 | ("sends on sock %p stuck for 7 seconds", |
185 | ssocket)); | 185 | ssocket)); |
@@ -189,7 +189,7 @@ smb_send(struct socket *ssocket, struct smb_hdr *smb_buffer, | |||
189 | msleep(1 << i); | 189 | msleep(1 << i); |
190 | continue; | 190 | continue; |
191 | } | 191 | } |
192 | if (rc < 0) | 192 | if (rc < 0) |
193 | break; | 193 | break; |
194 | else | 194 | else |
195 | i = 0; /* reset i after each successful send */ | 195 | i = 0; /* reset i after each successful send */ |
@@ -199,7 +199,7 @@ smb_send(struct socket *ssocket, struct smb_hdr *smb_buffer, | |||
199 | } | 199 | } |
200 | 200 | ||
201 | if (rc < 0) { | 201 | if (rc < 0) { |
202 | cERROR(1,("Error %d sending data on socket to server", rc)); | 202 | cERROR(1, ("Error %d sending data on socket to server", rc)); |
203 | } else { | 203 | } else { |
204 | rc = 0; | 204 | rc = 0; |
205 | } | 205 | } |
@@ -224,7 +224,7 @@ smb_send2(struct socket *ssocket, struct kvec *iov, int n_vec, | |||
224 | int first_vec = 0; | 224 | int first_vec = 0; |
225 | unsigned int smb_buf_length = smb_buffer->smb_buf_length; | 225 | unsigned int smb_buf_length = smb_buffer->smb_buf_length; |
226 | 226 | ||
227 | if(ssocket == NULL) | 227 | if (ssocket == NULL) |
228 | return -ENOTSOCK; /* BB eventually add reconnect code here */ | 228 | return -ENOTSOCK; /* BB eventually add reconnect code here */ |
229 | 229 | ||
230 | smb_msg.msg_name = sin; | 230 | smb_msg.msg_name = sin; |
@@ -234,8 +234,8 @@ smb_send2(struct socket *ssocket, struct kvec *iov, int n_vec, | |||
234 | smb_msg.msg_flags = MSG_DONTWAIT + MSG_NOSIGNAL; /* BB add more flags?*/ | 234 | smb_msg.msg_flags = MSG_DONTWAIT + MSG_NOSIGNAL; /* BB add more flags?*/ |
235 | 235 | ||
236 | /* smb header is converted in header_assemble. bcc and rest of SMB word | 236 | /* smb header is converted in header_assemble. bcc and rest of SMB word |
237 | area, and byte area if necessary, is converted to littleendian in | 237 | area, and byte area if necessary, is converted to littleendian in |
238 | cifssmb.c and RFC1001 len is converted to bigendian in smb_send | 238 | cifssmb.c and RFC1001 len is converted to bigendian in smb_send |
239 | Flags2 is converted in SendReceive */ | 239 | Flags2 is converted in SendReceive */ |
240 | 240 | ||
241 | 241 | ||
@@ -252,7 +252,7 @@ smb_send2(struct socket *ssocket, struct kvec *iov, int n_vec, | |||
252 | n_vec - first_vec, total_len); | 252 | n_vec - first_vec, total_len); |
253 | if ((rc == -ENOSPC) || (rc == -EAGAIN)) { | 253 | if ((rc == -ENOSPC) || (rc == -EAGAIN)) { |
254 | i++; | 254 | i++; |
255 | if(i >= 14) { | 255 | if (i >= 14) { |
256 | cERROR(1, | 256 | cERROR(1, |
257 | ("sends on sock %p stuck for 15 seconds", | 257 | ("sends on sock %p stuck for 15 seconds", |
258 | ssocket)); | 258 | ssocket)); |
@@ -262,17 +262,17 @@ smb_send2(struct socket *ssocket, struct kvec *iov, int n_vec, | |||
262 | msleep(1 << i); | 262 | msleep(1 << i); |
263 | continue; | 263 | continue; |
264 | } | 264 | } |
265 | if (rc < 0) | 265 | if (rc < 0) |
266 | break; | 266 | break; |
267 | 267 | ||
268 | if (rc >= total_len) { | 268 | if (rc >= total_len) { |
269 | WARN_ON(rc > total_len); | 269 | WARN_ON(rc > total_len); |
270 | break; | 270 | break; |
271 | } | 271 | } |
272 | if(rc == 0) { | 272 | if (rc == 0) { |
273 | /* should never happen, letting socket clear before | 273 | /* should never happen, letting socket clear before |
274 | retrying is our only obvious option here */ | 274 | retrying is our only obvious option here */ |
275 | cERROR(1,("tcp sent no data")); | 275 | cERROR(1, ("tcp sent no data")); |
276 | msleep(500); | 276 | msleep(500); |
277 | continue; | 277 | continue; |
278 | } | 278 | } |
@@ -295,7 +295,7 @@ smb_send2(struct socket *ssocket, struct kvec *iov, int n_vec, | |||
295 | } | 295 | } |
296 | 296 | ||
297 | if (rc < 0) { | 297 | if (rc < 0) { |
298 | cERROR(1,("Error %d sending data on socket to server", rc)); | 298 | cERROR(1, ("Error %d sending data on socket to server", rc)); |
299 | } else | 299 | } else |
300 | rc = 0; | 300 | rc = 0; |
301 | 301 | ||
@@ -308,13 +308,13 @@ smb_send2(struct socket *ssocket, struct kvec *iov, int n_vec, | |||
308 | 308 | ||
309 | static int wait_for_free_request(struct cifsSesInfo *ses, const int long_op) | 309 | static int wait_for_free_request(struct cifsSesInfo *ses, const int long_op) |
310 | { | 310 | { |
311 | if(long_op == -1) { | 311 | if (long_op == -1) { |
312 | /* oplock breaks must not be held up */ | 312 | /* oplock breaks must not be held up */ |
313 | atomic_inc(&ses->server->inFlight); | 313 | atomic_inc(&ses->server->inFlight); |
314 | } else { | 314 | } else { |
315 | spin_lock(&GlobalMid_Lock); | 315 | spin_lock(&GlobalMid_Lock); |
316 | while(1) { | 316 | while (1) { |
317 | if(atomic_read(&ses->server->inFlight) >= | 317 | if (atomic_read(&ses->server->inFlight) >= |
318 | cifs_max_pending){ | 318 | cifs_max_pending){ |
319 | spin_unlock(&GlobalMid_Lock); | 319 | spin_unlock(&GlobalMid_Lock); |
320 | #ifdef CONFIG_CIFS_STATS2 | 320 | #ifdef CONFIG_CIFS_STATS2 |
@@ -328,13 +328,13 @@ static int wait_for_free_request(struct cifsSesInfo *ses, const int long_op) | |||
328 | #endif | 328 | #endif |
329 | spin_lock(&GlobalMid_Lock); | 329 | spin_lock(&GlobalMid_Lock); |
330 | } else { | 330 | } else { |
331 | if(ses->server->tcpStatus == CifsExiting) { | 331 | if (ses->server->tcpStatus == CifsExiting) { |
332 | spin_unlock(&GlobalMid_Lock); | 332 | spin_unlock(&GlobalMid_Lock); |
333 | return -ENOENT; | 333 | return -ENOENT; |
334 | } | 334 | } |
335 | 335 | ||
336 | /* can not count locking commands against total since | 336 | /* can not count locking commands against total |
337 | they are allowed to block on server */ | 337 | as they are allowed to block on server */ |
338 | 338 | ||
339 | /* update # of requests on the wire to server */ | 339 | /* update # of requests on the wire to server */ |
340 | if (long_op < 3) | 340 | if (long_op < 3) |
@@ -353,11 +353,11 @@ static int allocate_mid(struct cifsSesInfo *ses, struct smb_hdr *in_buf, | |||
353 | if (ses->server->tcpStatus == CifsExiting) { | 353 | if (ses->server->tcpStatus == CifsExiting) { |
354 | return -ENOENT; | 354 | return -ENOENT; |
355 | } else if (ses->server->tcpStatus == CifsNeedReconnect) { | 355 | } else if (ses->server->tcpStatus == CifsNeedReconnect) { |
356 | cFYI(1,("tcp session dead - return to caller to retry")); | 356 | cFYI(1, ("tcp session dead - return to caller to retry")); |
357 | return -EAGAIN; | 357 | return -EAGAIN; |
358 | } else if (ses->status != CifsGood) { | 358 | } else if (ses->status != CifsGood) { |
359 | /* check if SMB session is bad because we are setting it up */ | 359 | /* check if SMB session is bad because we are setting it up */ |
360 | if((in_buf->Command != SMB_COM_SESSION_SETUP_ANDX) && | 360 | if ((in_buf->Command != SMB_COM_SESSION_SETUP_ANDX) && |
361 | (in_buf->Command != SMB_COM_NEGOTIATE)) { | 361 | (in_buf->Command != SMB_COM_NEGOTIATE)) { |
362 | return -EAGAIN; | 362 | return -EAGAIN; |
363 | } /* else ok - we are setting up session */ | 363 | } /* else ok - we are setting up session */ |
@@ -369,7 +369,7 @@ static int allocate_mid(struct cifsSesInfo *ses, struct smb_hdr *in_buf, | |||
369 | return 0; | 369 | return 0; |
370 | } | 370 | } |
371 | 371 | ||
372 | static int wait_for_response(struct cifsSesInfo *ses, | 372 | static int wait_for_response(struct cifsSesInfo *ses, |
373 | struct mid_q_entry *midQ, | 373 | struct mid_q_entry *midQ, |
374 | unsigned long timeout, | 374 | unsigned long timeout, |
375 | unsigned long time_to_wait) | 375 | unsigned long time_to_wait) |
@@ -379,8 +379,8 @@ static int wait_for_response(struct cifsSesInfo *ses, | |||
379 | for (;;) { | 379 | for (;;) { |
380 | curr_timeout = timeout + jiffies; | 380 | curr_timeout = timeout + jiffies; |
381 | wait_event(ses->server->response_q, | 381 | wait_event(ses->server->response_q, |
382 | (!(midQ->midState == MID_REQUEST_SUBMITTED)) || | 382 | (!(midQ->midState == MID_REQUEST_SUBMITTED)) || |
383 | time_after(jiffies, curr_timeout) || | 383 | time_after(jiffies, curr_timeout) || |
384 | ((ses->server->tcpStatus != CifsGood) && | 384 | ((ses->server->tcpStatus != CifsGood) && |
385 | (ses->server->tcpStatus != CifsNew))); | 385 | (ses->server->tcpStatus != CifsNew))); |
386 | 386 | ||
@@ -398,16 +398,16 @@ static int wait_for_response(struct cifsSesInfo *ses, | |||
398 | spin_unlock(&GlobalMid_Lock); | 398 | spin_unlock(&GlobalMid_Lock); |
399 | 399 | ||
400 | /* Calculate time_to_wait past last receive time. | 400 | /* Calculate time_to_wait past last receive time. |
401 | Although we prefer not to time out if the | 401 | Although we prefer not to time out if the |
402 | server is still responding - we will time | 402 | server is still responding - we will time |
403 | out if the server takes more than 15 (or 45 | 403 | out if the server takes more than 15 (or 45 |
404 | or 180) seconds to respond to this request | 404 | or 180) seconds to respond to this request |
405 | and has not responded to any request from | 405 | and has not responded to any request from |
406 | other threads on the client within 10 seconds */ | 406 | other threads on the client within 10 seconds */ |
407 | lrt += time_to_wait; | 407 | lrt += time_to_wait; |
408 | if (time_after(jiffies, lrt)) { | 408 | if (time_after(jiffies, lrt)) { |
409 | /* No replies for time_to_wait. */ | 409 | /* No replies for time_to_wait. */ |
410 | cERROR(1,("server not responding")); | 410 | cERROR(1, ("server not responding")); |
411 | return -1; | 411 | return -1; |
412 | } | 412 | } |
413 | } else { | 413 | } else { |
@@ -417,8 +417,8 @@ static int wait_for_response(struct cifsSesInfo *ses, | |||
417 | } | 417 | } |
418 | 418 | ||
419 | int | 419 | int |
420 | SendReceive2(const unsigned int xid, struct cifsSesInfo *ses, | 420 | SendReceive2(const unsigned int xid, struct cifsSesInfo *ses, |
421 | struct kvec *iov, int n_vec, int * pRespBufType /* ret */, | 421 | struct kvec *iov, int n_vec, int *pRespBufType /* ret */, |
422 | const int long_op) | 422 | const int long_op) |
423 | { | 423 | { |
424 | int rc = 0; | 424 | int rc = 0; |
@@ -431,16 +431,16 @@ SendReceive2(const unsigned int xid, struct cifsSesInfo *ses, | |||
431 | 431 | ||
432 | if ((ses == NULL) || (ses->server == NULL)) { | 432 | if ((ses == NULL) || (ses->server == NULL)) { |
433 | cifs_small_buf_release(in_buf); | 433 | cifs_small_buf_release(in_buf); |
434 | cERROR(1,("Null session")); | 434 | cERROR(1, ("Null session")); |
435 | return -EIO; | 435 | return -EIO; |
436 | } | 436 | } |
437 | 437 | ||
438 | if(ses->server->tcpStatus == CifsExiting) { | 438 | if (ses->server->tcpStatus == CifsExiting) { |
439 | cifs_small_buf_release(in_buf); | 439 | cifs_small_buf_release(in_buf); |
440 | return -ENOENT; | 440 | return -ENOENT; |
441 | } | 441 | } |
442 | 442 | ||
443 | /* Ensure that we do not send more than 50 overlapping requests | 443 | /* Ensure that we do not send more than 50 overlapping requests |
444 | to the same server. We may make this configurable later or | 444 | to the same server. We may make this configurable later or |
445 | use ses->maxReq */ | 445 | use ses->maxReq */ |
446 | 446 | ||
@@ -450,23 +450,23 @@ SendReceive2(const unsigned int xid, struct cifsSesInfo *ses, | |||
450 | return rc; | 450 | return rc; |
451 | } | 451 | } |
452 | 452 | ||
453 | /* make sure that we sign in the same order that we send on this socket | 453 | /* make sure that we sign in the same order that we send on this socket |
454 | and avoid races inside tcp sendmsg code that could cause corruption | 454 | and avoid races inside tcp sendmsg code that could cause corruption |
455 | of smb data */ | 455 | of smb data */ |
456 | 456 | ||
457 | down(&ses->server->tcpSem); | 457 | down(&ses->server->tcpSem); |
458 | 458 | ||
459 | rc = allocate_mid(ses, in_buf, &midQ); | 459 | rc = allocate_mid(ses, in_buf, &midQ); |
460 | if (rc) { | 460 | if (rc) { |
461 | up(&ses->server->tcpSem); | 461 | up(&ses->server->tcpSem); |
462 | cifs_small_buf_release(in_buf); | 462 | cifs_small_buf_release(in_buf); |
463 | /* Update # of requests on wire to server */ | 463 | /* Update # of requests on wire to server */ |
464 | atomic_dec(&ses->server->inFlight); | 464 | atomic_dec(&ses->server->inFlight); |
465 | wake_up(&ses->server->request_q); | 465 | wake_up(&ses->server->request_q); |
466 | return rc; | 466 | return rc; |
467 | } | 467 | } |
468 | 468 | ||
469 | rc = cifs_sign_smb2(iov, n_vec, ses->server, &midQ->sequence_number); | 469 | rc = cifs_sign_smb2(iov, n_vec, ses->server, &midQ->sequence_number); |
470 | 470 | ||
471 | midQ->midState = MID_REQUEST_SUBMITTED; | 471 | midQ->midState = MID_REQUEST_SUBMITTED; |
472 | #ifdef CONFIG_CIFS_STATS2 | 472 | #ifdef CONFIG_CIFS_STATS2 |
@@ -482,7 +482,7 @@ SendReceive2(const unsigned int xid, struct cifsSesInfo *ses, | |||
482 | up(&ses->server->tcpSem); | 482 | up(&ses->server->tcpSem); |
483 | cifs_small_buf_release(in_buf); | 483 | cifs_small_buf_release(in_buf); |
484 | 484 | ||
485 | if(rc < 0) | 485 | if (rc < 0) |
486 | goto out; | 486 | goto out; |
487 | 487 | ||
488 | if (long_op == -1) | 488 | if (long_op == -1) |
@@ -490,18 +490,18 @@ SendReceive2(const unsigned int xid, struct cifsSesInfo *ses, | |||
490 | else if (long_op == 2) /* writes past end of file can take loong time */ | 490 | else if (long_op == 2) /* writes past end of file can take loong time */ |
491 | timeout = 180 * HZ; | 491 | timeout = 180 * HZ; |
492 | else if (long_op == 1) | 492 | else if (long_op == 1) |
493 | timeout = 45 * HZ; /* should be greater than | 493 | timeout = 45 * HZ; /* should be greater than |
494 | servers oplock break timeout (about 43 seconds) */ | 494 | servers oplock break timeout (about 43 seconds) */ |
495 | else | 495 | else |
496 | timeout = 15 * HZ; | 496 | timeout = 15 * HZ; |
497 | 497 | ||
498 | /* wait for 15 seconds or until woken up due to response arriving or | 498 | /* wait for 15 seconds or until woken up due to response arriving or |
499 | due to last connection to this server being unmounted */ | 499 | due to last connection to this server being unmounted */ |
500 | if (signal_pending(current)) { | 500 | if (signal_pending(current)) { |
501 | /* if signal pending do not hold up user for full smb timeout | 501 | /* if signal pending do not hold up user for full smb timeout |
502 | but we still give response a chance to complete */ | 502 | but we still give response a chance to complete */ |
503 | timeout = 2 * HZ; | 503 | timeout = 2 * HZ; |
504 | } | 504 | } |
505 | 505 | ||
506 | /* No user interrupts in wait - wreaks havoc with performance */ | 506 | /* No user interrupts in wait - wreaks havoc with performance */ |
507 | wait_for_response(ses, midQ, timeout, 10 * HZ); | 507 | wait_for_response(ses, midQ, timeout, 10 * HZ); |
@@ -511,10 +511,10 @@ SendReceive2(const unsigned int xid, struct cifsSesInfo *ses, | |||
511 | spin_unlock(&GlobalMid_Lock); | 511 | spin_unlock(&GlobalMid_Lock); |
512 | receive_len = midQ->resp_buf->smb_buf_length; | 512 | receive_len = midQ->resp_buf->smb_buf_length; |
513 | } else { | 513 | } else { |
514 | cERROR(1,("No response to cmd %d mid %d", | 514 | cERROR(1, ("No response to cmd %d mid %d", |
515 | midQ->command, midQ->mid)); | 515 | midQ->command, midQ->mid)); |
516 | if(midQ->midState == MID_REQUEST_SUBMITTED) { | 516 | if (midQ->midState == MID_REQUEST_SUBMITTED) { |
517 | if(ses->server->tcpStatus == CifsExiting) | 517 | if (ses->server->tcpStatus == CifsExiting) |
518 | rc = -EHOSTDOWN; | 518 | rc = -EHOSTDOWN; |
519 | else { | 519 | else { |
520 | ses->server->tcpStatus = CifsNeedReconnect; | 520 | ses->server->tcpStatus = CifsNeedReconnect; |
@@ -523,9 +523,9 @@ SendReceive2(const unsigned int xid, struct cifsSesInfo *ses, | |||
523 | } | 523 | } |
524 | 524 | ||
525 | if (rc != -EHOSTDOWN) { | 525 | if (rc != -EHOSTDOWN) { |
526 | if(midQ->midState == MID_RETRY_NEEDED) { | 526 | if (midQ->midState == MID_RETRY_NEEDED) { |
527 | rc = -EAGAIN; | 527 | rc = -EAGAIN; |
528 | cFYI(1,("marking request for retry")); | 528 | cFYI(1, ("marking request for retry")); |
529 | } else { | 529 | } else { |
530 | rc = -EIO; | 530 | rc = -EIO; |
531 | } | 531 | } |
@@ -533,7 +533,7 @@ SendReceive2(const unsigned int xid, struct cifsSesInfo *ses, | |||
533 | spin_unlock(&GlobalMid_Lock); | 533 | spin_unlock(&GlobalMid_Lock); |
534 | DeleteMidQEntry(midQ); | 534 | DeleteMidQEntry(midQ); |
535 | /* Update # of requests on wire to server */ | 535 | /* Update # of requests on wire to server */ |
536 | atomic_dec(&ses->server->inFlight); | 536 | atomic_dec(&ses->server->inFlight); |
537 | wake_up(&ses->server->request_q); | 537 | wake_up(&ses->server->request_q); |
538 | return rc; | 538 | return rc; |
539 | } | 539 | } |
@@ -543,11 +543,11 @@ SendReceive2(const unsigned int xid, struct cifsSesInfo *ses, | |||
543 | receive_len, xid)); | 543 | receive_len, xid)); |
544 | rc = -EIO; | 544 | rc = -EIO; |
545 | } else { /* rcvd frame is ok */ | 545 | } else { /* rcvd frame is ok */ |
546 | if (midQ->resp_buf && | 546 | if (midQ->resp_buf && |
547 | (midQ->midState == MID_RESPONSE_RECEIVED)) { | 547 | (midQ->midState == MID_RESPONSE_RECEIVED)) { |
548 | 548 | ||
549 | iov[0].iov_base = (char *)midQ->resp_buf; | 549 | iov[0].iov_base = (char *)midQ->resp_buf; |
550 | if(midQ->largeBuf) | 550 | if (midQ->largeBuf) |
551 | *pRespBufType = CIFS_LARGE_BUFFER; | 551 | *pRespBufType = CIFS_LARGE_BUFFER; |
552 | else | 552 | else |
553 | *pRespBufType = CIFS_SMALL_BUFFER; | 553 | *pRespBufType = CIFS_SMALL_BUFFER; |
@@ -555,14 +555,14 @@ SendReceive2(const unsigned int xid, struct cifsSesInfo *ses, | |||
555 | 555 | ||
556 | dump_smb(midQ->resp_buf, 80); | 556 | dump_smb(midQ->resp_buf, 80); |
557 | /* convert the length into a more usable form */ | 557 | /* convert the length into a more usable form */ |
558 | if((receive_len > 24) && | 558 | if ((receive_len > 24) && |
559 | (ses->server->secMode & (SECMODE_SIGN_REQUIRED | | 559 | (ses->server->secMode & (SECMODE_SIGN_REQUIRED | |
560 | SECMODE_SIGN_ENABLED))) { | 560 | SECMODE_SIGN_ENABLED))) { |
561 | rc = cifs_verify_signature(midQ->resp_buf, | 561 | rc = cifs_verify_signature(midQ->resp_buf, |
562 | ses->server->mac_signing_key, | 562 | ses->server->mac_signing_key, |
563 | midQ->sequence_number+1); | 563 | midQ->sequence_number+1); |
564 | if(rc) { | 564 | if (rc) { |
565 | cERROR(1,("Unexpected SMB signature")); | 565 | cERROR(1, ("Unexpected SMB signature")); |
566 | /* BB FIXME add code to kill session */ | 566 | /* BB FIXME add code to kill session */ |
567 | } | 567 | } |
568 | } | 568 | } |
@@ -576,19 +576,19 @@ SendReceive2(const unsigned int xid, struct cifsSesInfo *ses, | |||
576 | sizeof (struct smb_hdr) - | 576 | sizeof (struct smb_hdr) - |
577 | 4 /* do not count RFC1001 header */ + | 577 | 4 /* do not count RFC1001 header */ + |
578 | (2 * midQ->resp_buf->WordCount) + 2 /* bcc */ ) | 578 | (2 * midQ->resp_buf->WordCount) + 2 /* bcc */ ) |
579 | BCC(midQ->resp_buf) = | 579 | BCC(midQ->resp_buf) = |
580 | le16_to_cpu(BCC_LE(midQ->resp_buf)); | 580 | le16_to_cpu(BCC_LE(midQ->resp_buf)); |
581 | midQ->resp_buf = NULL; /* mark it so will not be freed | 581 | midQ->resp_buf = NULL; /* mark it so will not be freed |
582 | by DeleteMidQEntry */ | 582 | by DeleteMidQEntry */ |
583 | } else { | 583 | } else { |
584 | rc = -EIO; | 584 | rc = -EIO; |
585 | cFYI(1,("Bad MID state?")); | 585 | cFYI(1, ("Bad MID state?")); |
586 | } | 586 | } |
587 | } | 587 | } |
588 | 588 | ||
589 | out: | 589 | out: |
590 | DeleteMidQEntry(midQ); | 590 | DeleteMidQEntry(midQ); |
591 | atomic_dec(&ses->server->inFlight); | 591 | atomic_dec(&ses->server->inFlight); |
592 | wake_up(&ses->server->request_q); | 592 | wake_up(&ses->server->request_q); |
593 | 593 | ||
594 | return rc; | 594 | return rc; |
@@ -605,18 +605,18 @@ SendReceive(const unsigned int xid, struct cifsSesInfo *ses, | |||
605 | struct mid_q_entry *midQ; | 605 | struct mid_q_entry *midQ; |
606 | 606 | ||
607 | if (ses == NULL) { | 607 | if (ses == NULL) { |
608 | cERROR(1,("Null smb session")); | 608 | cERROR(1, ("Null smb session")); |
609 | return -EIO; | 609 | return -EIO; |
610 | } | 610 | } |
611 | if(ses->server == NULL) { | 611 | if (ses->server == NULL) { |
612 | cERROR(1,("Null tcp session")); | 612 | cERROR(1, ("Null tcp session")); |
613 | return -EIO; | 613 | return -EIO; |
614 | } | 614 | } |
615 | 615 | ||
616 | if(ses->server->tcpStatus == CifsExiting) | 616 | if (ses->server->tcpStatus == CifsExiting) |
617 | return -ENOENT; | 617 | return -ENOENT; |
618 | 618 | ||
619 | /* Ensure that we do not send more than 50 overlapping requests | 619 | /* Ensure that we do not send more than 50 overlapping requests |
620 | to the same server. We may make this configurable later or | 620 | to the same server. We may make this configurable later or |
621 | use ses->maxReq */ | 621 | use ses->maxReq */ |
622 | 622 | ||
@@ -624,17 +624,17 @@ SendReceive(const unsigned int xid, struct cifsSesInfo *ses, | |||
624 | if (rc) | 624 | if (rc) |
625 | return rc; | 625 | return rc; |
626 | 626 | ||
627 | /* make sure that we sign in the same order that we send on this socket | 627 | /* make sure that we sign in the same order that we send on this socket |
628 | and avoid races inside tcp sendmsg code that could cause corruption | 628 | and avoid races inside tcp sendmsg code that could cause corruption |
629 | of smb data */ | 629 | of smb data */ |
630 | 630 | ||
631 | down(&ses->server->tcpSem); | 631 | down(&ses->server->tcpSem); |
632 | 632 | ||
633 | rc = allocate_mid(ses, in_buf, &midQ); | 633 | rc = allocate_mid(ses, in_buf, &midQ); |
634 | if (rc) { | 634 | if (rc) { |
635 | up(&ses->server->tcpSem); | 635 | up(&ses->server->tcpSem); |
636 | /* Update # of requests on wire to server */ | 636 | /* Update # of requests on wire to server */ |
637 | atomic_dec(&ses->server->inFlight); | 637 | atomic_dec(&ses->server->inFlight); |
638 | wake_up(&ses->server->request_q); | 638 | wake_up(&ses->server->request_q); |
639 | return rc; | 639 | return rc; |
640 | } | 640 | } |
@@ -645,7 +645,7 @@ SendReceive(const unsigned int xid, struct cifsSesInfo *ses, | |||
645 | DeleteMidQEntry(midQ); | 645 | DeleteMidQEntry(midQ); |
646 | up(&ses->server->tcpSem); | 646 | up(&ses->server->tcpSem); |
647 | /* Update # of requests on wire to server */ | 647 | /* Update # of requests on wire to server */ |
648 | atomic_dec(&ses->server->inFlight); | 648 | atomic_dec(&ses->server->inFlight); |
649 | wake_up(&ses->server->request_q); | 649 | wake_up(&ses->server->request_q); |
650 | return -EIO; | 650 | return -EIO; |
651 | } | 651 | } |
@@ -664,7 +664,7 @@ SendReceive(const unsigned int xid, struct cifsSesInfo *ses, | |||
664 | #endif | 664 | #endif |
665 | up(&ses->server->tcpSem); | 665 | up(&ses->server->tcpSem); |
666 | 666 | ||
667 | if(rc < 0) | 667 | if (rc < 0) |
668 | goto out; | 668 | goto out; |
669 | 669 | ||
670 | if (long_op == -1) | 670 | if (long_op == -1) |
@@ -672,17 +672,17 @@ SendReceive(const unsigned int xid, struct cifsSesInfo *ses, | |||
672 | else if (long_op == 2) /* writes past end of file can take loong time */ | 672 | else if (long_op == 2) /* writes past end of file can take loong time */ |
673 | timeout = 180 * HZ; | 673 | timeout = 180 * HZ; |
674 | else if (long_op == 1) | 674 | else if (long_op == 1) |
675 | timeout = 45 * HZ; /* should be greater than | 675 | timeout = 45 * HZ; /* should be greater than |
676 | servers oplock break timeout (about 43 seconds) */ | 676 | servers oplock break timeout (about 43 seconds) */ |
677 | else | 677 | else |
678 | timeout = 15 * HZ; | 678 | timeout = 15 * HZ; |
679 | /* wait for 15 seconds or until woken up due to response arriving or | 679 | /* wait for 15 seconds or until woken up due to response arriving or |
680 | due to last connection to this server being unmounted */ | 680 | due to last connection to this server being unmounted */ |
681 | if (signal_pending(current)) { | 681 | if (signal_pending(current)) { |
682 | /* if signal pending do not hold up user for full smb timeout | 682 | /* if signal pending do not hold up user for full smb timeout |
683 | but we still give response a chance to complete */ | 683 | but we still give response a chance to complete */ |
684 | timeout = 2 * HZ; | 684 | timeout = 2 * HZ; |
685 | } | 685 | } |
686 | 686 | ||
687 | /* No user interrupts in wait - wreaks havoc with performance */ | 687 | /* No user interrupts in wait - wreaks havoc with performance */ |
688 | wait_for_response(ses, midQ, timeout, 10 * HZ); | 688 | wait_for_response(ses, midQ, timeout, 10 * HZ); |
@@ -692,10 +692,10 @@ SendReceive(const unsigned int xid, struct cifsSesInfo *ses, | |||
692 | spin_unlock(&GlobalMid_Lock); | 692 | spin_unlock(&GlobalMid_Lock); |
693 | receive_len = midQ->resp_buf->smb_buf_length; | 693 | receive_len = midQ->resp_buf->smb_buf_length; |
694 | } else { | 694 | } else { |
695 | cERROR(1,("No response for cmd %d mid %d", | 695 | cERROR(1, ("No response for cmd %d mid %d", |
696 | midQ->command, midQ->mid)); | 696 | midQ->command, midQ->mid)); |
697 | if(midQ->midState == MID_REQUEST_SUBMITTED) { | 697 | if (midQ->midState == MID_REQUEST_SUBMITTED) { |
698 | if(ses->server->tcpStatus == CifsExiting) | 698 | if (ses->server->tcpStatus == CifsExiting) |
699 | rc = -EHOSTDOWN; | 699 | rc = -EHOSTDOWN; |
700 | else { | 700 | else { |
701 | ses->server->tcpStatus = CifsNeedReconnect; | 701 | ses->server->tcpStatus = CifsNeedReconnect; |
@@ -704,9 +704,9 @@ SendReceive(const unsigned int xid, struct cifsSesInfo *ses, | |||
704 | } | 704 | } |
705 | 705 | ||
706 | if (rc != -EHOSTDOWN) { | 706 | if (rc != -EHOSTDOWN) { |
707 | if(midQ->midState == MID_RETRY_NEEDED) { | 707 | if (midQ->midState == MID_RETRY_NEEDED) { |
708 | rc = -EAGAIN; | 708 | rc = -EAGAIN; |
709 | cFYI(1,("marking request for retry")); | 709 | cFYI(1, ("marking request for retry")); |
710 | } else { | 710 | } else { |
711 | rc = -EIO; | 711 | rc = -EIO; |
712 | } | 712 | } |
@@ -714,7 +714,7 @@ SendReceive(const unsigned int xid, struct cifsSesInfo *ses, | |||
714 | spin_unlock(&GlobalMid_Lock); | 714 | spin_unlock(&GlobalMid_Lock); |
715 | DeleteMidQEntry(midQ); | 715 | DeleteMidQEntry(midQ); |
716 | /* Update # of requests on wire to server */ | 716 | /* Update # of requests on wire to server */ |
717 | atomic_dec(&ses->server->inFlight); | 717 | atomic_dec(&ses->server->inFlight); |
718 | wake_up(&ses->server->request_q); | 718 | wake_up(&ses->server->request_q); |
719 | return rc; | 719 | return rc; |
720 | } | 720 | } |
@@ -734,14 +734,14 @@ SendReceive(const unsigned int xid, struct cifsSesInfo *ses, | |||
734 | 734 | ||
735 | dump_smb(out_buf, 92); | 735 | dump_smb(out_buf, 92); |
736 | /* convert the length into a more usable form */ | 736 | /* convert the length into a more usable form */ |
737 | if((receive_len > 24) && | 737 | if ((receive_len > 24) && |
738 | (ses->server->secMode & (SECMODE_SIGN_REQUIRED | | 738 | (ses->server->secMode & (SECMODE_SIGN_REQUIRED | |
739 | SECMODE_SIGN_ENABLED))) { | 739 | SECMODE_SIGN_ENABLED))) { |
740 | rc = cifs_verify_signature(out_buf, | 740 | rc = cifs_verify_signature(out_buf, |
741 | ses->server->mac_signing_key, | 741 | ses->server->mac_signing_key, |
742 | midQ->sequence_number+1); | 742 | midQ->sequence_number+1); |
743 | if(rc) { | 743 | if (rc) { |
744 | cERROR(1,("Unexpected SMB signature")); | 744 | cERROR(1, ("Unexpected SMB signature")); |
745 | /* BB FIXME add code to kill session */ | 745 | /* BB FIXME add code to kill session */ |
746 | } | 746 | } |
747 | } | 747 | } |
@@ -759,13 +759,13 @@ SendReceive(const unsigned int xid, struct cifsSesInfo *ses, | |||
759 | BCC(out_buf) = le16_to_cpu(BCC_LE(out_buf)); | 759 | BCC(out_buf) = le16_to_cpu(BCC_LE(out_buf)); |
760 | } else { | 760 | } else { |
761 | rc = -EIO; | 761 | rc = -EIO; |
762 | cERROR(1,("Bad MID state?")); | 762 | cERROR(1, ("Bad MID state?")); |
763 | } | 763 | } |
764 | } | 764 | } |
765 | 765 | ||
766 | out: | 766 | out: |
767 | DeleteMidQEntry(midQ); | 767 | DeleteMidQEntry(midQ); |
768 | atomic_dec(&ses->server->inFlight); | 768 | atomic_dec(&ses->server->inFlight); |
769 | wake_up(&ses->server->request_q); | 769 | wake_up(&ses->server->request_q); |
770 | 770 | ||
771 | return rc; | 771 | return rc; |
@@ -783,7 +783,7 @@ send_nt_cancel(struct cifsTconInfo *tcon, struct smb_hdr *in_buf, | |||
783 | 783 | ||
784 | header_assemble(in_buf, SMB_COM_NT_CANCEL, tcon, 0); | 784 | header_assemble(in_buf, SMB_COM_NT_CANCEL, tcon, 0); |
785 | in_buf->Mid = mid; | 785 | in_buf->Mid = mid; |
786 | down(&ses->server->tcpSem); | 786 | down(&ses->server->tcpSem); |
787 | rc = cifs_sign_smb(in_buf, ses->server, &midQ->sequence_number); | 787 | rc = cifs_sign_smb(in_buf, ses->server, &midQ->sequence_number); |
788 | if (rc) { | 788 | if (rc) { |
789 | up(&ses->server->tcpSem); | 789 | up(&ses->server->tcpSem); |
@@ -832,20 +832,20 @@ SendReceiveBlockingLock(const unsigned int xid, struct cifsTconInfo *tcon, | |||
832 | struct cifsSesInfo *ses; | 832 | struct cifsSesInfo *ses; |
833 | 833 | ||
834 | if (tcon == NULL || tcon->ses == NULL) { | 834 | if (tcon == NULL || tcon->ses == NULL) { |
835 | cERROR(1,("Null smb session")); | 835 | cERROR(1, ("Null smb session")); |
836 | return -EIO; | 836 | return -EIO; |
837 | } | 837 | } |
838 | ses = tcon->ses; | 838 | ses = tcon->ses; |
839 | 839 | ||
840 | if(ses->server == NULL) { | 840 | if (ses->server == NULL) { |
841 | cERROR(1,("Null tcp session")); | 841 | cERROR(1, ("Null tcp session")); |
842 | return -EIO; | 842 | return -EIO; |
843 | } | 843 | } |
844 | 844 | ||
845 | if(ses->server->tcpStatus == CifsExiting) | 845 | if (ses->server->tcpStatus == CifsExiting) |
846 | return -ENOENT; | 846 | return -ENOENT; |
847 | 847 | ||
848 | /* Ensure that we do not send more than 50 overlapping requests | 848 | /* Ensure that we do not send more than 50 overlapping requests |
849 | to the same server. We may make this configurable later or | 849 | to the same server. We may make this configurable later or |
850 | use ses->maxReq */ | 850 | use ses->maxReq */ |
851 | 851 | ||
@@ -853,11 +853,11 @@ SendReceiveBlockingLock(const unsigned int xid, struct cifsTconInfo *tcon, | |||
853 | if (rc) | 853 | if (rc) |
854 | return rc; | 854 | return rc; |
855 | 855 | ||
856 | /* make sure that we sign in the same order that we send on this socket | 856 | /* make sure that we sign in the same order that we send on this socket |
857 | and avoid races inside tcp sendmsg code that could cause corruption | 857 | and avoid races inside tcp sendmsg code that could cause corruption |
858 | of smb data */ | 858 | of smb data */ |
859 | 859 | ||
860 | down(&ses->server->tcpSem); | 860 | down(&ses->server->tcpSem); |
861 | 861 | ||
862 | rc = allocate_mid(ses, in_buf, &midQ); | 862 | rc = allocate_mid(ses, in_buf, &midQ); |
863 | if (rc) { | 863 | if (rc) { |
@@ -887,14 +887,14 @@ SendReceiveBlockingLock(const unsigned int xid, struct cifsTconInfo *tcon, | |||
887 | #endif | 887 | #endif |
888 | up(&ses->server->tcpSem); | 888 | up(&ses->server->tcpSem); |
889 | 889 | ||
890 | if(rc < 0) { | 890 | if (rc < 0) { |
891 | DeleteMidQEntry(midQ); | 891 | DeleteMidQEntry(midQ); |
892 | return rc; | 892 | return rc; |
893 | } | 893 | } |
894 | 894 | ||
895 | /* Wait for a reply - allow signals to interrupt. */ | 895 | /* Wait for a reply - allow signals to interrupt. */ |
896 | rc = wait_event_interruptible(ses->server->response_q, | 896 | rc = wait_event_interruptible(ses->server->response_q, |
897 | (!(midQ->midState == MID_REQUEST_SUBMITTED)) || | 897 | (!(midQ->midState == MID_REQUEST_SUBMITTED)) || |
898 | ((ses->server->tcpStatus != CifsGood) && | 898 | ((ses->server->tcpStatus != CifsGood) && |
899 | (ses->server->tcpStatus != CifsNew))); | 899 | (ses->server->tcpStatus != CifsNew))); |
900 | 900 | ||
@@ -928,7 +928,7 @@ SendReceiveBlockingLock(const unsigned int xid, struct cifsTconInfo *tcon, | |||
928 | } | 928 | } |
929 | 929 | ||
930 | /* Wait 5 seconds for the response. */ | 930 | /* Wait 5 seconds for the response. */ |
931 | if (wait_for_response(ses, midQ, 5 * HZ, 5 * HZ)==0) { | 931 | if (wait_for_response(ses, midQ, 5 * HZ, 5 * HZ) == 0) { |
932 | /* We got the response - restart system call. */ | 932 | /* We got the response - restart system call. */ |
933 | rstart = 1; | 933 | rstart = 1; |
934 | } | 934 | } |
@@ -939,10 +939,10 @@ SendReceiveBlockingLock(const unsigned int xid, struct cifsTconInfo *tcon, | |||
939 | spin_unlock(&GlobalMid_Lock); | 939 | spin_unlock(&GlobalMid_Lock); |
940 | receive_len = midQ->resp_buf->smb_buf_length; | 940 | receive_len = midQ->resp_buf->smb_buf_length; |
941 | } else { | 941 | } else { |
942 | cERROR(1,("No response for cmd %d mid %d", | 942 | cERROR(1, ("No response for cmd %d mid %d", |
943 | midQ->command, midQ->mid)); | 943 | midQ->command, midQ->mid)); |
944 | if(midQ->midState == MID_REQUEST_SUBMITTED) { | 944 | if (midQ->midState == MID_REQUEST_SUBMITTED) { |
945 | if(ses->server->tcpStatus == CifsExiting) | 945 | if (ses->server->tcpStatus == CifsExiting) |
946 | rc = -EHOSTDOWN; | 946 | rc = -EHOSTDOWN; |
947 | else { | 947 | else { |
948 | ses->server->tcpStatus = CifsNeedReconnect; | 948 | ses->server->tcpStatus = CifsNeedReconnect; |
@@ -951,9 +951,9 @@ SendReceiveBlockingLock(const unsigned int xid, struct cifsTconInfo *tcon, | |||
951 | } | 951 | } |
952 | 952 | ||
953 | if (rc != -EHOSTDOWN) { | 953 | if (rc != -EHOSTDOWN) { |
954 | if(midQ->midState == MID_RETRY_NEEDED) { | 954 | if (midQ->midState == MID_RETRY_NEEDED) { |
955 | rc = -EAGAIN; | 955 | rc = -EAGAIN; |
956 | cFYI(1,("marking request for retry")); | 956 | cFYI(1, ("marking request for retry")); |
957 | } else { | 957 | } else { |
958 | rc = -EIO; | 958 | rc = -EIO; |
959 | } | 959 | } |
@@ -978,14 +978,14 @@ SendReceiveBlockingLock(const unsigned int xid, struct cifsTconInfo *tcon, | |||
978 | 978 | ||
979 | dump_smb(out_buf, 92); | 979 | dump_smb(out_buf, 92); |
980 | /* convert the length into a more usable form */ | 980 | /* convert the length into a more usable form */ |
981 | if((receive_len > 24) && | 981 | if ((receive_len > 24) && |
982 | (ses->server->secMode & (SECMODE_SIGN_REQUIRED | | 982 | (ses->server->secMode & (SECMODE_SIGN_REQUIRED | |
983 | SECMODE_SIGN_ENABLED))) { | 983 | SECMODE_SIGN_ENABLED))) { |
984 | rc = cifs_verify_signature(out_buf, | 984 | rc = cifs_verify_signature(out_buf, |
985 | ses->server->mac_signing_key, | 985 | ses->server->mac_signing_key, |
986 | midQ->sequence_number+1); | 986 | midQ->sequence_number+1); |
987 | if(rc) { | 987 | if (rc) { |
988 | cERROR(1,("Unexpected SMB signature")); | 988 | cERROR(1, ("Unexpected SMB signature")); |
989 | /* BB FIXME add code to kill session */ | 989 | /* BB FIXME add code to kill session */ |
990 | } | 990 | } |
991 | } | 991 | } |
@@ -1003,7 +1003,7 @@ SendReceiveBlockingLock(const unsigned int xid, struct cifsTconInfo *tcon, | |||
1003 | BCC(out_buf) = le16_to_cpu(BCC_LE(out_buf)); | 1003 | BCC(out_buf) = le16_to_cpu(BCC_LE(out_buf)); |
1004 | } else { | 1004 | } else { |
1005 | rc = -EIO; | 1005 | rc = -EIO; |
1006 | cERROR(1,("Bad MID state?")); | 1006 | cERROR(1, ("Bad MID state?")); |
1007 | } | 1007 | } |
1008 | } | 1008 | } |
1009 | DeleteMidQEntry(midQ); | 1009 | DeleteMidQEntry(midQ); |