[CIFS] cifs: Rename cERROR and cFYI to cifs_dbg

It's not obvious from reading the macro names that these macros
are for debugging.  Convert the names to a single more typical
kernel style cifs_dbg macro.

	cERROR(1, ...)   -> cifs_dbg(VFS, ...)
	cFYI(1, ...)     -> cifs_dbg(FYI, ...)
	cFYI(DBG2, ...)  -> cifs_dbg(NOISY, ...)

Move the terminating format newline from the macro to the call site.

Add CONFIG_CIFS_DEBUG function cifs_vfs_err to emit the
"CIFS VFS: " prefix for VFS messages.

Size is reduced ~ 1% when CONFIG_CIFS_DEBUG is set (default y)

$ size fs/cifs/cifs.ko*
   text    data     bss     dec     hex filename
 265245	   2525	    132	 267902	  4167e	fs/cifs/cifs.ko.new
 268359    2525     132  271016   422a8 fs/cifs/cifs.ko.old

Other miscellaneous changes around these conversions:

o Miscellaneous typo fixes
o Add terminating \n's to almost all formats and remove them
  from the macros to be more kernel style like.  A few formats
  previously had defective \n's
o Remove unnecessary OOM messages as kmalloc() calls dump_stack
o Coalesce formats to make grep easier,
  added missing spaces when coalescing formats
o Use %s, __func__ instead of embedded function name
o Removed unnecessary "cifs: " prefixes
o Convert kzalloc with multiply to kcalloc
o Remove unused cifswarn macro

Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Jeff Layton <jlayton@redhat.com>
Signed-off-by: Steve French <smfrench@gmail.com>

1 files changed, 9 insertions, 8 deletions

diff --git a/fs/cifs/dns_resolve.c b/fs/cifs/dns_resolve.c
index 1d2d91d9bf65..e7512e497611 100644
--- a/fs/cifs/dns_resolve.c
+++ b/fs/cifs/dns_resolve.c
@@ -55,7 +55,7 @@ dns_resolve_server_name_to_ip(const char *unc, char **ip_addr)
 
         len = strlen(unc);
         if (len < 3) {
-                cFYI(1, "%s: unc is too short: %s", __func__, unc);
+                cifs_dbg(FYI, "%s: unc is too short: %s\n", __func__, unc);
                 return -EINVAL;
         }
 
@@ -68,8 +68,8 @@ dns_resolve_server_name_to_ip(const char *unc, char **ip_addr)
         if (sep)
                 len = sep - hostname;
         else
-                cFYI(1, "%s: probably server name is whole unc: %s",
-                     __func__, unc);
+                cifs_dbg(FYI, "%s: probably server name is whole unc: %s\n",
+                         __func__, unc);
 
         /* Try to interpret hostname as an IPv4 or IPv6 address */
         rc = cifs_convert_address((struct sockaddr *)&ss, hostname, len);
@@ -79,11 +79,11 @@ dns_resolve_server_name_to_ip(const char *unc, char **ip_addr)
         /* Perform the upcall */
         rc = dns_query(NULL, hostname, len, NULL, ip_addr, NULL);
         if (rc < 0)
-                cFYI(1, "%s: unable to resolve: %*.*s",
-                        __func__, len, len, hostname);
+                cifs_dbg(FYI, "%s: unable to resolve: %*.*s\n",
+                         __func__, len, len, hostname);
         else
-                cFYI(1, "%s: resolved: %*.*s to %s",
-                     __func__, len, len, hostname, *ip_addr);
+                cifs_dbg(FYI, "%s: resolved: %*.*s to %s\n",
+                         __func__, len, len, hostname, *ip_addr);
         return rc;
 
 name_is_IP_address:
@@ -92,7 +92,8 @@ name_is_IP_address:
                 return -ENOMEM;
         memcpy(name, hostname, len);
         name[len] = 0;
-        cFYI(1, "%s: unc is IP, skipping dns upcall: %s", __func__, name);
+        cifs_dbg(FYI, "%s: unc is IP, skipping dns upcall: %s\n",
+                 __func__, name);
         *ip_addr = name;
         return 0;
 }