diff options
author | Steve French <sfrench@us.ibm.com> | 2005-08-13 11:15:54 -0400 |
---|---|---|
committer | Steve French <sfrench@us.ibm.com> | 2005-08-13 11:15:54 -0400 |
commit | 4a6d87f1db06c9670251d6c72a89319e7d1cbaee (patch) | |
tree | aa21e8220215933742f931a452d7d96839b93c2b /fs/cifs/dir.c | |
parent | a47fd3f5e3a3f970ac1b81643ac56737f97a1fea (diff) |
[CIFS] Add missing check for path name allocation failure. Remove four
redundant null pointer checks before cifs_buf_release.
Found by coverity analyzer.
Signed-off-by: Steve French (sfrench@us.ibm.com)
Diffstat (limited to 'fs/cifs/dir.c')
-rw-r--r-- | fs/cifs/dir.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/fs/cifs/dir.c b/fs/cifs/dir.c index c0f20fc09290..c619d45060ce 100644 --- a/fs/cifs/dir.c +++ b/fs/cifs/dir.c | |||
@@ -226,7 +226,8 @@ cifs_create(struct inode *inode, struct dentry *direntry, int mode, | |||
226 | } | 226 | } |
227 | 227 | ||
228 | if (rc != 0) { | 228 | if (rc != 0) { |
229 | cFYI(1,("Create worked but get_inode_info failed with rc = %d", | 229 | cFYI(1, |
230 | ("Create worked but get_inode_info failed rc = %d", | ||
230 | rc)); | 231 | rc)); |
231 | } else { | 232 | } else { |
232 | direntry->d_op = &cifs_dentry_ops; | 233 | direntry->d_op = &cifs_dentry_ops; |
@@ -303,8 +304,7 @@ int cifs_mknod(struct inode *inode, struct dentry *direntry, int mode, dev_t dev | |||
303 | up(&direntry->d_sb->s_vfs_rename_sem); | 304 | up(&direntry->d_sb->s_vfs_rename_sem); |
304 | if(full_path == NULL) | 305 | if(full_path == NULL) |
305 | rc = -ENOMEM; | 306 | rc = -ENOMEM; |
306 | 307 | else if (pTcon->ses->capabilities & CAP_UNIX) { | |
307 | if (full_path && (pTcon->ses->capabilities & CAP_UNIX)) { | ||
308 | if(cifs_sb->mnt_cifs_flags & CIFS_MOUNT_SET_UID) { | 308 | if(cifs_sb->mnt_cifs_flags & CIFS_MOUNT_SET_UID) { |
309 | rc = CIFSSMBUnixSetPerms(xid, pTcon, full_path, | 309 | rc = CIFSSMBUnixSetPerms(xid, pTcon, full_path, |
310 | mode,(__u64)current->euid,(__u64)current->egid, | 310 | mode,(__u64)current->euid,(__u64)current->egid, |