diff options
author | Jeff Layton <jlayton@redhat.com> | 2010-10-22 14:52:29 -0400 |
---|---|---|
committer | Steve French <sfrench@us.ibm.com> | 2010-10-24 20:19:00 -0400 |
commit | eb4b756b1e60b66e54932619088b645c712414a3 (patch) | |
tree | c2a10df2f33be6bd9a8b5491cc1815515dc59e84 /fs/cifs/cifsglob.h | |
parent | 6c0f6218ba04a5d6e61d0c55b68e6c4ef0736531 (diff) |
cifs: eliminate cifsInodeInfo->write_behind_rc (try #6)
write_behind_rc is redundant and just adds complexity to the code. What
we really want to do instead is to use mapping_set_error to reset the
flags on the mapping when we find a writeback error and can't report it
to userspace yet.
For cifs_flush and cifs_fsync, we shouldn't reset the flags since errors
returned there do get reported to userspace.
Signed-off-by: Jeff Layton <jlayton@redhat.com>
Reviewed-by: Suresh Jayaraman <sjayaraman@suse.de>
Reviewed-by: Dave Kleikamp <shaggy@linux.vnet.ibm.com>
Signed-off-by: Steve French <sfrench@us.ibm.com>
Diffstat (limited to 'fs/cifs/cifsglob.h')
-rw-r--r-- | fs/cifs/cifsglob.h | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/fs/cifs/cifsglob.h b/fs/cifs/cifsglob.h index 7128c291cec8..ef5709b250e6 100644 --- a/fs/cifs/cifsglob.h +++ b/fs/cifs/cifsglob.h | |||
@@ -420,7 +420,6 @@ struct cifsInodeInfo { | |||
420 | struct list_head lockList; | 420 | struct list_head lockList; |
421 | /* BB add in lists for dirty pages i.e. write caching info for oplock */ | 421 | /* BB add in lists for dirty pages i.e. write caching info for oplock */ |
422 | struct list_head openFileList; | 422 | struct list_head openFileList; |
423 | int write_behind_rc; | ||
424 | __u32 cifsAttrs; /* e.g. DOS archive bit, sparse, compressed, system */ | 423 | __u32 cifsAttrs; /* e.g. DOS archive bit, sparse, compressed, system */ |
425 | unsigned long time; /* jiffies of last update/check of inode */ | 424 | unsigned long time; /* jiffies of last update/check of inode */ |
426 | bool clientCanCacheRead:1; /* read oplock */ | 425 | bool clientCanCacheRead:1; /* read oplock */ |