aboutsummaryrefslogtreecommitdiffstats
path: root/fs/cifs/cifsfs.c
diff options
context:
space:
mode:
authorSean Finney <seanius@seanius.net>2011-04-11 09:19:35 -0400
committerSteve French <sfrench@us.ibm.com>2011-05-19 10:10:55 -0400
commitf14bcf71d1b802f6042b6c70a0c37120e47a0876 (patch)
tree9852d20c31ec19caaccec30a0b06b89542681ac7 /fs/cifs/cifsfs.c
parent5167f11ec962690ecf926fab00f1d0524cd78664 (diff)
cifs: Unconditionally copy mount options to superblock info
Previously mount options were copied and updated in the cifs_sb_info struct only when CONFIG_CIFS_DFS_UPCALL was enabled. Making this information generally available allows us to remove a number of ifdefs, extra function params, and temporary variables. Reviewed-by: Jeff Layton <jlayton@redhat.com> Signed-off-by: Sean Finney <seanius@seanius.net> Signed-off-by: Steve French <sfrench@us.ibm.com>
Diffstat (limited to 'fs/cifs/cifsfs.c')
-rw-r--r--fs/cifs/cifsfs.c8
1 files changed, 1 insertions, 7 deletions
diff --git a/fs/cifs/cifsfs.c b/fs/cifs/cifsfs.c
index bb39afcc6f38..2b8e47e5e533 100644
--- a/fs/cifs/cifsfs.c
+++ b/fs/cifs/cifsfs.c
@@ -128,7 +128,6 @@ cifs_read_super(struct super_block *sb, void *data,
128 } 128 }
129 cifs_sb->bdi.ra_pages = default_backing_dev_info.ra_pages; 129 cifs_sb->bdi.ra_pages = default_backing_dev_info.ra_pages;
130 130
131#ifdef CONFIG_CIFS_DFS_UPCALL
132 /* 131 /*
133 * Copy mount params to sb for use in submounts. Better to do 132 * Copy mount params to sb for use in submounts. Better to do
134 * the copy here and deal with the error before cleanup gets 133 * the copy here and deal with the error before cleanup gets
@@ -143,9 +142,8 @@ cifs_read_super(struct super_block *sb, void *data,
143 return -ENOMEM; 142 return -ENOMEM;
144 } 143 }
145 } 144 }
146#endif
147 145
148 rc = cifs_mount(sb, cifs_sb, data, devname); 146 rc = cifs_mount(sb, cifs_sb, devname);
149 147
150 if (rc) { 148 if (rc) {
151 if (!silent) 149 if (!silent)
@@ -197,12 +195,10 @@ out_no_root:
197 195
198out_mount_failed: 196out_mount_failed:
199 if (cifs_sb) { 197 if (cifs_sb) {
200#ifdef CONFIG_CIFS_DFS_UPCALL
201 if (cifs_sb->mountdata) { 198 if (cifs_sb->mountdata) {
202 kfree(cifs_sb->mountdata); 199 kfree(cifs_sb->mountdata);
203 cifs_sb->mountdata = NULL; 200 cifs_sb->mountdata = NULL;
204 } 201 }
205#endif
206 unload_nls(cifs_sb->local_nls); 202 unload_nls(cifs_sb->local_nls);
207 bdi_destroy(&cifs_sb->bdi); 203 bdi_destroy(&cifs_sb->bdi);
208 kfree(cifs_sb); 204 kfree(cifs_sb);
@@ -226,12 +222,10 @@ cifs_put_super(struct super_block *sb)
226 rc = cifs_umount(sb, cifs_sb); 222 rc = cifs_umount(sb, cifs_sb);
227 if (rc) 223 if (rc)
228 cERROR(1, "cifs_umount failed with return code %d", rc); 224 cERROR(1, "cifs_umount failed with return code %d", rc);
229#ifdef CONFIG_CIFS_DFS_UPCALL
230 if (cifs_sb->mountdata) { 225 if (cifs_sb->mountdata) {
231 kfree(cifs_sb->mountdata); 226 kfree(cifs_sb->mountdata);
232 cifs_sb->mountdata = NULL; 227 cifs_sb->mountdata = NULL;
233 } 228 }
234#endif
235 229
236 unload_nls(cifs_sb->local_nls); 230 unload_nls(cifs_sb->local_nls);
237 bdi_destroy(&cifs_sb->bdi); 231 bdi_destroy(&cifs_sb->bdi);