diff options
author | Steve French <sfrench@us.ibm.com> | 2007-09-14 23:01:17 -0400 |
---|---|---|
committer | Steve French <sfrench@us.ibm.com> | 2007-09-14 23:01:17 -0400 |
commit | 88f370a688e765de9755a343702ca04e6817e5f5 (patch) | |
tree | 82ad179c2310cf60c8aa83c50e221f363b51d8fe /fs/cifs/cifs_debug.c | |
parent | 638b250766272fcaaa0f7ed2776f58f4ac701914 (diff) |
[CIFS] Fix potential NULL pointer usage if kzalloc fails
Potential problem was noticed by Cyrill Gorcunov
CC: Cyrill Gorcunov <gorcunov@gmail.com>
Signed-off-by: Steve French <sfrench@us.ibm.com>
Diffstat (limited to 'fs/cifs/cifs_debug.c')
-rw-r--r-- | fs/cifs/cifs_debug.c | 16 |
1 files changed, 9 insertions, 7 deletions
diff --git a/fs/cifs/cifs_debug.c b/fs/cifs/cifs_debug.c index 1bf8cf522ad6..0356694b5cd0 100644 --- a/fs/cifs/cifs_debug.c +++ b/fs/cifs/cifs_debug.c | |||
@@ -209,13 +209,15 @@ cifs_debug_data_read(char *buf, char **beginBuffer, off_t offset, | |||
209 | i++; | 209 | i++; |
210 | tcon = list_entry(tmp, struct cifsTconInfo, cifsConnectionList); | 210 | tcon = list_entry(tmp, struct cifsTconInfo, cifsConnectionList); |
211 | dev_type = le32_to_cpu(tcon->fsDevInfo.DeviceType); | 211 | dev_type = le32_to_cpu(tcon->fsDevInfo.DeviceType); |
212 | length = | 212 | length = sprintf(buf, "\n%d) %s Uses: %d ", i, |
213 | sprintf(buf, | 213 | tcon->treeName, atomic_read(&tcon->useCount)); |
214 | "\n%d) %s Uses: %d Type: %s DevInfo: 0x%x " | 214 | buf += length; |
215 | "Attributes: 0x%x\nPathComponentMax: %d Status: %d", | 215 | if (tcon->nativeFileSystem) { |
216 | i, tcon->treeName, | 216 | length = sprintf("Type: %s ", tcon->nativeFileSystem); |
217 | atomic_read(&tcon->useCount), | 217 | buf += length; |
218 | tcon->nativeFileSystem, | 218 | } |
219 | length = sprintf(buf, "DevInfo: 0x%x Attributes: 0x%x" | ||
220 | "\nPathComponentMax: %d Status: %d", | ||
219 | le32_to_cpu(tcon->fsDevInfo.DeviceCharacteristics), | 221 | le32_to_cpu(tcon->fsDevInfo.DeviceCharacteristics), |
220 | le32_to_cpu(tcon->fsAttrInfo.Attributes), | 222 | le32_to_cpu(tcon->fsAttrInfo.Attributes), |
221 | le32_to_cpu(tcon->fsAttrInfo.MaxPathNameComponentLength), | 223 | le32_to_cpu(tcon->fsAttrInfo.MaxPathNameComponentLength), |