aboutsummaryrefslogtreecommitdiffstats
path: root/fs/cifs/TODO
diff options
context:
space:
mode:
authorLinus Torvalds <torvalds@woody.linux-foundation.org>2007-08-01 00:12:07 -0400
committerLinus Torvalds <torvalds@woody.linux-foundation.org>2007-08-01 00:12:07 -0400
commit8d4fbcfbe0a4bfc73e7f0297c59ae514e1f1436f (patch)
treef4fe8e2028620b8aeb298c78ee5dc9d6df07e708 /fs/cifs/TODO
parent2f63251ed0a803ddbe7bf2577b69d467aa872f68 (diff)
Fix WARN_ON() on bitfield ops
Alexey Dobriyan noticed that the new WARN_ON() semantics that were introduced by commit 684f978347deb42d180373ac4c427f82ef963171 (to also return the value to be warned on) didn't compile when given a bitfield, because the typeof doesn't work for bitfields. So instead of the typeof trick, use an "int" variable together with a "!!(x)" expression, as suggested by Al Viro. To make matters more interesting, Paul Mackerras points out that that is sub-optimal on Power, but the old asm-coded comparison seems to be buggy anyway on 32-bit Power if the conditional was 64-bit, so I think there are more problems there. Regardless, the new WARN_ON() semantics may have been a bad idea. But this at least avoids the more serious complications. Cc: Alexey Dobriyan <adobriyan@sw.ru> Cc: Herbert Xu <herbert@gondor.apana.org.au> Cc: Paul Mackerras <paulus@samba.org> Cc: Al Viro <viro@ftp.linux.org.uk> Cc: Ingo Molnar <mingo@elte.hu> Cc: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'fs/cifs/TODO')
0 files changed, 0 insertions, 0 deletions