aboutsummaryrefslogtreecommitdiffstats
path: root/fs/ceph
diff options
context:
space:
mode:
authorLi Wang <liwang@ubuntukylin.com>2013-11-13 02:22:14 -0500
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2014-01-09 15:24:22 -0500
commit88285f766c96205ccf30afd3d0621401701ff26c (patch)
tree4e6773891bf954fccf0a5fbfce996401e123f14f /fs/ceph
parent6008a51b189b39fae1dd545da28c3cfc8038870c (diff)
ceph: Avoid data inconsistency due to d-cache aliasing in readpage()
commit 56f91aad69444d650237295f68c195b74d888d95 upstream. If the length of data to be read in readpage() is exactly PAGE_CACHE_SIZE, the original code does not flush d-cache for data consistency after finishing reading. This patches fixes this. Signed-off-by: Li Wang <liwang@ubuntukylin.com> Signed-off-by: Sage Weil <sage@inktank.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'fs/ceph')
-rw-r--r--fs/ceph/addr.c8
1 files changed, 6 insertions, 2 deletions
diff --git a/fs/ceph/addr.c b/fs/ceph/addr.c
index 3e68ac101040..5da06f020986 100644
--- a/fs/ceph/addr.c
+++ b/fs/ceph/addr.c
@@ -213,9 +213,13 @@ static int readpage_nounlock(struct file *filp, struct page *page)
213 if (err < 0) { 213 if (err < 0) {
214 SetPageError(page); 214 SetPageError(page);
215 goto out; 215 goto out;
216 } else if (err < PAGE_CACHE_SIZE) { 216 } else {
217 if (err < PAGE_CACHE_SIZE) {
217 /* zero fill remainder of page */ 218 /* zero fill remainder of page */
218 zero_user_segment(page, err, PAGE_CACHE_SIZE); 219 zero_user_segment(page, err, PAGE_CACHE_SIZE);
220 } else {
221 flush_dcache_page(page);
222 }
219 } 223 }
220 SetPageUptodate(page); 224 SetPageUptodate(page);
221 225