aboutsummaryrefslogtreecommitdiffstats
path: root/fs/ceph/osd_client.c
diff options
context:
space:
mode:
authorYehuda Sadeh <yehuda@hq.newdream.net>2010-02-01 19:10:45 -0500
committerSage Weil <sage@newdream.net>2010-02-02 19:29:50 -0500
commit0c948992a00d478c17042f4790b7d6b35299cf94 (patch)
tree8a6bdfabcaf9f524fcfa6ce2ec10ebb73df0a9aa /fs/ceph/osd_client.c
parent0f26c4b21b684825a6dd41f2bc04d48ff62d72f8 (diff)
ceph: always send truncation info with read and write osd ops
This fixes a bug where the read/write ops arrive the osd after a following truncation request. Signed-off-by: Yehuda Sadeh <yehuda@hq.newdream.net> Signed-off-by: Sage Weil <sage@newdream.net>
Diffstat (limited to 'fs/ceph/osd_client.c')
-rw-r--r--fs/ceph/osd_client.c16
1 files changed, 3 insertions, 13 deletions
diff --git a/fs/ceph/osd_client.c b/fs/ceph/osd_client.c
index df2106839713..944759b3079f 100644
--- a/fs/ceph/osd_client.c
+++ b/fs/ceph/osd_client.c
@@ -199,11 +199,9 @@ struct ceph_osd_request *ceph_osdc_new_request(struct ceph_osd_client *osdc,
199 struct ceph_osd_request_head *head; 199 struct ceph_osd_request_head *head;
200 struct ceph_osd_op *op; 200 struct ceph_osd_op *op;
201 void *p; 201 void *p;
202 int do_trunc = truncate_seq && (off + *plen > truncate_size); 202 int num_op = 1 + do_sync;
203 int num_op = 1 + do_sync + do_trunc;
204 size_t msg_size = sizeof(*head) + num_op*sizeof(*op); 203 size_t msg_size = sizeof(*head) + num_op*sizeof(*op);
205 int err, i; 204 int err, i;
206 u64 prevofs;
207 205
208 if (use_mempool) { 206 if (use_mempool) {
209 req = mempool_alloc(osdc->req_mempool, GFP_NOFS); 207 req = mempool_alloc(osdc->req_mempool, GFP_NOFS);
@@ -268,22 +266,14 @@ struct ceph_osd_request *ceph_osdc_new_request(struct ceph_osd_client *osdc,
268 req->r_request->hdr.data_len = cpu_to_le32(*plen); 266 req->r_request->hdr.data_len = cpu_to_le32(*plen);
269 op->payload_len = cpu_to_le32(*plen); 267 op->payload_len = cpu_to_le32(*plen);
270 } 268 }
269 op->extent.truncate_size = cpu_to_le64(truncate_size);
270 op->extent.truncate_seq = cpu_to_le32(truncate_seq);
271 271
272 /* fill in oid */ 272 /* fill in oid */
273 head->object_len = cpu_to_le32(req->r_oid_len); 273 head->object_len = cpu_to_le32(req->r_oid_len);
274 memcpy(p, req->r_oid, req->r_oid_len); 274 memcpy(p, req->r_oid, req->r_oid_len);
275 p += req->r_oid_len; 275 p += req->r_oid_len;
276 276
277 /* additional ops */
278 if (do_trunc) {
279 op++;
280 op->op = cpu_to_le16(opcode == CEPH_OSD_OP_READ ?
281 CEPH_OSD_OP_MASKTRUNC : CEPH_OSD_OP_SETTRUNC);
282 op->trunc.truncate_seq = cpu_to_le32(truncate_seq);
283 prevofs = le64_to_cpu((op-1)->extent.offset);
284 op->trunc.truncate_size = cpu_to_le64(truncate_size -
285 (off-prevofs));
286 }
287 if (do_sync) { 277 if (do_sync) {
288 op++; 278 op++;
289 op->op = cpu_to_le16(CEPH_OSD_OP_STARTSYNC); 279 op->op = cpu_to_le16(CEPH_OSD_OP_STARTSYNC);