diff options
author | David Howells <dhowells@redhat.com> | 2015-01-29 07:02:36 -0500 |
---|---|---|
committer | Al Viro <viro@zeniv.linux.org.uk> | 2015-02-22 11:38:41 -0500 |
commit | ce40fa78ef8f0e813392903c96de65b947298d16 (patch) | |
tree | 0b4a5db5feafed3cadaab68bd77d0c7e6b049ef1 /fs/cachefiles/rdwr.c | |
parent | e36cb0b89ce20b4f8786a57e8a6bc8476f577650 (diff) |
Cachefiles: Fix up scripted S_ISDIR/S_ISREG/S_ISLNK conversions
Fix up the following scripted S_ISDIR/S_ISREG/S_ISLNK conversions (or lack
thereof) in cachefiles:
(1) Cachefiles mostly wants to use d_can_lookup() rather than d_is_dir() as
it doesn't want to deal with automounts in its cache.
(2) Coccinelle didn't find S_IS* expressions in ASSERT() statements in
cachefiles.
Signed-off-by: David Howells <dhowells@redhat.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'fs/cachefiles/rdwr.c')
-rw-r--r-- | fs/cachefiles/rdwr.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/cachefiles/rdwr.c b/fs/cachefiles/rdwr.c index 616db0e77b44..c6cd8d7a4eef 100644 --- a/fs/cachefiles/rdwr.c +++ b/fs/cachefiles/rdwr.c | |||
@@ -900,7 +900,7 @@ int cachefiles_write_page(struct fscache_storage *op, struct page *page) | |||
900 | return -ENOBUFS; | 900 | return -ENOBUFS; |
901 | } | 901 | } |
902 | 902 | ||
903 | ASSERT(S_ISREG(object->backer->d_inode->i_mode)); | 903 | ASSERT(d_is_reg(object->backer)); |
904 | 904 | ||
905 | cache = container_of(object->fscache.cache, | 905 | cache = container_of(object->fscache.cache, |
906 | struct cachefiles_cache, cache); | 906 | struct cachefiles_cache, cache); |