diff options
author | Nick Piggin <npiggin@suse.de> | 2009-03-31 18:23:21 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2009-04-01 11:59:14 -0400 |
commit | c2ec175c39f62949438354f603f4aa170846aabb (patch) | |
tree | f2c9bf1bec2deabe2d3a5092405b027637b6ead3 /fs/buffer.c | |
parent | c2fdf3a9b2d52842808a8e551b53b55dd9b45030 (diff) |
mm: page_mkwrite change prototype to match fault
Change the page_mkwrite prototype to take a struct vm_fault, and return
VM_FAULT_xxx flags. There should be no functional change.
This makes it possible to return much more detailed error information to
the VM (and also can provide more information eg. virtual_address to the
driver, which might be important in some special cases).
This is required for a subsequent fix. And will also make it easier to
merge page_mkwrite() with fault() in future.
Signed-off-by: Nick Piggin <npiggin@suse.de>
Cc: Chris Mason <chris.mason@oracle.com>
Cc: Trond Myklebust <trond.myklebust@fys.uio.no>
Cc: Miklos Szeredi <miklos@szeredi.hu>
Cc: Steven Whitehouse <swhiteho@redhat.com>
Cc: Mark Fasheh <mfasheh@suse.com>
Cc: Joel Becker <joel.becker@oracle.com>
Cc: Artem Bityutskiy <dedekind@infradead.org>
Cc: Felix Blyakher <felixb@sgi.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'fs/buffer.c')
-rw-r--r-- | fs/buffer.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/fs/buffer.c b/fs/buffer.c index 73abe6d8218c..6d51a3da362c 100644 --- a/fs/buffer.c +++ b/fs/buffer.c | |||
@@ -2313,9 +2313,10 @@ int block_commit_write(struct page *page, unsigned from, unsigned to) | |||
2313 | * unlock the page. | 2313 | * unlock the page. |
2314 | */ | 2314 | */ |
2315 | int | 2315 | int |
2316 | block_page_mkwrite(struct vm_area_struct *vma, struct page *page, | 2316 | block_page_mkwrite(struct vm_area_struct *vma, struct vm_fault *vmf, |
2317 | get_block_t get_block) | 2317 | get_block_t get_block) |
2318 | { | 2318 | { |
2319 | struct page *page = vmf->page; | ||
2319 | struct inode *inode = vma->vm_file->f_path.dentry->d_inode; | 2320 | struct inode *inode = vma->vm_file->f_path.dentry->d_inode; |
2320 | unsigned long end; | 2321 | unsigned long end; |
2321 | loff_t size; | 2322 | loff_t size; |
@@ -2340,6 +2341,9 @@ block_page_mkwrite(struct vm_area_struct *vma, struct page *page, | |||
2340 | ret = block_commit_write(page, 0, end); | 2341 | ret = block_commit_write(page, 0, end); |
2341 | 2342 | ||
2342 | out_unlock: | 2343 | out_unlock: |
2344 | if (ret) | ||
2345 | ret = VM_FAULT_SIGBUS; | ||
2346 | |||
2343 | unlock_page(page); | 2347 | unlock_page(page); |
2344 | return ret; | 2348 | return ret; |
2345 | } | 2349 | } |