aboutsummaryrefslogtreecommitdiffstats
path: root/fs/buffer.c
diff options
context:
space:
mode:
authorJeff Layton <jlayton@redhat.com>2011-10-27 17:53:08 -0400
committerChristoph Hellwig <hch@serles.lst.de>2011-10-28 07:55:08 -0400
commit39be79c16f2b8eb07dd0d4e965cddfe39cc0534a (patch)
tree821611221295d47c671ec72e1fb558efcedff03b /fs/buffer.c
parentc3b92c8787367a8bb53d57d9789b558f1295cc96 (diff)
vfs: iov_iter: have iov_iter_advance decrement nr_segs appropriately
Currently, when you call iov_iter_advance, then the pointer to the iovec array can be incremented, but it does not decrement the nr_segs value in the iov_iter struct. The result is a iov_iter struct with a nr_segs value that goes beyond the end of the array. While I'm not aware of anything that's specifically broken by this, it seems odd and a bit dangerous not to decrement that value. If someone were to trust the nr_segs value to be correct, then they could end up walking off the end of the array. Changing this might also provide some micro-optimization when dealing with the last iovec in an array. Many of the other routines that deal with iov_iter have optimized codepaths when nr_segs == 1. Cc: Nick Piggin <npiggin@suse.de> Signed-off-by: Jeff Layton <jlayton@redhat.com> Signed-off-by: Christoph Hellwig <hch@lst.de>
Diffstat (limited to 'fs/buffer.c')
0 files changed, 0 insertions, 0 deletions