aboutsummaryrefslogtreecommitdiffstats
path: root/fs/btrfs/tree-log.c
diff options
context:
space:
mode:
authorLiu Bo <bo.li.liu@oracle.com>2012-08-27 12:52:20 -0400
committerChris Mason <chris.mason@fusionio.com>2012-10-01 15:19:05 -0400
commit4e2f84e63dc138eca91e89ccbc34f37732ce58f7 (patch)
tree31691a22773cf249fc289d8414be62b52d071513 /fs/btrfs/tree-log.c
parentca7e70f59078046db28501519308c2061b0e7a6f (diff)
Btrfs: improve fsync by filtering extents that we want
This is based on Josef's "Btrfs: turbo charge fsync". The above Josef's patch performs very good in random sync write test, because we won't have too much extents to merge. However, it does not performs good on the test: dd if=/dev/zero of=foobar bs=4k count=12500 oflag=sync The reason is when we do sequencial sync write, we need to merge the current extent just with the previous one, so that we can get accumulated extents to log: A(4k) --> AA(8k) --> AAA(12k) --> AAAA(16k) ... So we'll have to flush more and more checksum into log tree, which is the bottleneck according to my tests. But we can avoid this by telling fsync the real extents that are needed to be logged. With this, I did the above dd sync write test (size=50m), w/o (orig) w/ (josef's) w/ (this) SATA 104KB/s 109KB/s 121KB/s ramdisk 1.5MB/s 1.5MB/s 10.7MB/s (613%) Signed-off-by: Liu Bo <bo.li.liu@oracle.com>
Diffstat (limited to 'fs/btrfs/tree-log.c')
-rw-r--r--fs/btrfs/tree-log.c6
1 files changed, 3 insertions, 3 deletions
diff --git a/fs/btrfs/tree-log.c b/fs/btrfs/tree-log.c
index 58075d711d24..71e71539ffb7 100644
--- a/fs/btrfs/tree-log.c
+++ b/fs/btrfs/tree-log.c
@@ -2833,8 +2833,8 @@ static int log_one_extent(struct btrfs_trans_handle *trans,
2833 struct btrfs_root *log = root->log_root; 2833 struct btrfs_root *log = root->log_root;
2834 struct btrfs_file_extent_item *fi; 2834 struct btrfs_file_extent_item *fi;
2835 struct btrfs_key key; 2835 struct btrfs_key key;
2836 u64 start = em->start; 2836 u64 start = em->mod_start;
2837 u64 len = em->len; 2837 u64 len = em->mod_len;
2838 u64 num_bytes; 2838 u64 num_bytes;
2839 int nritems; 2839 int nritems;
2840 int ret; 2840 int ret;
@@ -2970,7 +2970,7 @@ static int btrfs_log_changed_extents(struct btrfs_trans_handle *trans,
2970 * sequential then we need to copy the items we have and redo 2970 * sequential then we need to copy the items we have and redo
2971 * our search 2971 * our search
2972 */ 2972 */
2973 if (args.nr && em->start != args.next_offset) { 2973 if (args.nr && em->mod_start != args.next_offset) {
2974 ret = copy_items(trans, log, dst_path, args.src, 2974 ret = copy_items(trans, log, dst_path, args.src,
2975 args.start_slot, args.nr, 2975 args.start_slot, args.nr,
2976 LOG_INODE_ALL); 2976 LOG_INODE_ALL);