diff options
author | Josef Bacik <jbacik@fusionio.com> | 2012-09-14 10:34:40 -0400 |
---|---|---|
committer | Chris Mason <chris.mason@fusionio.com> | 2012-10-04 09:39:56 -0400 |
commit | 60376ce4a8396bc5cd777be05b6a9bf044520f42 (patch) | |
tree | 9648ab1c651557c640b8cdd24ce18d75b434c510 /fs/btrfs/transaction.h | |
parent | b3ae244e7174d981c09ad7a6a68e7909d600aaca (diff) |
Btrfs: fix race in sync and freeze again
I screwed this up, there is a race between checking if there is a running
transaction and actually starting a transaction in sync where we could race
with a freezer and get ourselves into trouble. To fix this we need to make
a new join type to only do the try lock on the freeze stuff. If it fails
we'll return EPERM and just return from sync. This fixes a hang Liu Bo
reported when running xfstest 68 in a loop. Thanks,
Reported-by: Liu Bo <bo.li.liu@oracle.com>
Signed-off-by: Josef Bacik <jbacik@fusionio.com>
Diffstat (limited to 'fs/btrfs/transaction.h')
-rw-r--r-- | fs/btrfs/transaction.h | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/fs/btrfs/transaction.h b/fs/btrfs/transaction.h index b6463e128048..fbf8313b9d67 100644 --- a/fs/btrfs/transaction.h +++ b/fs/btrfs/transaction.h | |||
@@ -102,6 +102,7 @@ struct btrfs_trans_handle *btrfs_start_transaction_noflush( | |||
102 | struct btrfs_root *root, int num_items); | 102 | struct btrfs_root *root, int num_items); |
103 | struct btrfs_trans_handle *btrfs_join_transaction(struct btrfs_root *root); | 103 | struct btrfs_trans_handle *btrfs_join_transaction(struct btrfs_root *root); |
104 | struct btrfs_trans_handle *btrfs_join_transaction_nolock(struct btrfs_root *root); | 104 | struct btrfs_trans_handle *btrfs_join_transaction_nolock(struct btrfs_root *root); |
105 | struct btrfs_trans_handle *btrfs_join_transaction_freeze(struct btrfs_root *root); | ||
105 | struct btrfs_trans_handle *btrfs_start_ioctl_transaction(struct btrfs_root *root); | 106 | struct btrfs_trans_handle *btrfs_start_ioctl_transaction(struct btrfs_root *root); |
106 | int btrfs_wait_for_commit(struct btrfs_root *root, u64 transid); | 107 | int btrfs_wait_for_commit(struct btrfs_root *root, u64 transid); |
107 | int btrfs_write_and_wait_transaction(struct btrfs_trans_handle *trans, | 108 | int btrfs_write_and_wait_transaction(struct btrfs_trans_handle *trans, |