Btrfs: cleanup some BUG_ON()

This patch changes some BUG_ON() to the error return.
(but, most callers still use BUG_ON())

Signed-off-by: Tsutomu Itoh <t-itoh@jp.fujitsu.com>
Signed-off-by: Chris Mason <chris.mason@oracle.com>

1 files changed, 9 insertions, 3 deletions

diff --git a/fs/btrfs/transaction.c b/fs/btrfs/transaction.c
index 5b4bc685bb0e..ce48eb59d615 100644
--- a/fs/btrfs/transaction.c
+++ b/fs/btrfs/transaction.c
@@ -57,7 +57,8 @@ static noinline int join_transaction(struct btrfs_root *root)
         if (!cur_trans) {
                 cur_trans = kmem_cache_alloc(btrfs_transaction_cachep,
                                              GFP_NOFS);
-                BUG_ON(!cur_trans);
+                if (!cur_trans)
+                        return -ENOMEM;
                 root->fs_info->generation++;
                 cur_trans->num_writers = 1;
                 cur_trans->num_joined = 0;
@@ -195,7 +196,11 @@ again:
                 wait_current_trans(root);
 
         ret = join_transaction(root);
-        BUG_ON(ret);
+        if (ret < 0) {
+                if (type != TRANS_JOIN_NOLOCK)
+                        mutex_unlock(&root->fs_info->trans_mutex);
+                return ERR_PTR(ret);
+        }
 
         cur_trans = root->fs_info->running_transaction;
         cur_trans->use_count++;
@@ -1156,7 +1161,8 @@ int btrfs_commit_transaction_async(struct btrfs_trans_handle *trans,
         struct btrfs_transaction *cur_trans;
 
         ac = kmalloc(sizeof(*ac), GFP_NOFS);
-        BUG_ON(!ac);
+        if (!ac)
+                return -ENOMEM;
 
         INIT_DELAYED_WORK(&ac->work, do_async_commit);
         ac->root = root;