diff options
author | Josef Bacik <josef@redhat.com> | 2011-10-05 10:00:18 -0400 |
---|---|---|
committer | Josef Bacik <josef@redhat.com> | 2011-10-19 15:12:51 -0400 |
commit | f75b130e9bb361850787e156c79311adb84f551e (patch) | |
tree | 6bc2fdf8c19f36124583774f07550e26b85de7e5 /fs/btrfs/free-space-cache.c | |
parent | 73bc187680f94bed498f8a669103cad290e41180 (diff) |
Btrfs: don't skip writing out a empty block groups cache
I noticed a slight bug where we will not bother writing out the block group
cache's space cache if it's space tree is empty. Since it could have a cluster
or pinned extents that need to be written out this is just not a valid test.
Thanks,
Signed-off-by: Josef Bacik <josef@redhat.com>
Diffstat (limited to 'fs/btrfs/free-space-cache.c')
-rw-r--r-- | fs/btrfs/free-space-cache.c | 10 |
1 files changed, 6 insertions, 4 deletions
diff --git a/fs/btrfs/free-space-cache.c b/fs/btrfs/free-space-cache.c index 0a8ccdbdd464..b81556ca75ea 100644 --- a/fs/btrfs/free-space-cache.c +++ b/fs/btrfs/free-space-cache.c | |||
@@ -575,10 +575,6 @@ int __btrfs_write_out_cache(struct btrfs_root *root, struct inode *inode, | |||
575 | 575 | ||
576 | INIT_LIST_HEAD(&bitmap_list); | 576 | INIT_LIST_HEAD(&bitmap_list); |
577 | 577 | ||
578 | node = rb_first(&ctl->free_space_offset); | ||
579 | if (!node) | ||
580 | return -1; | ||
581 | |||
582 | if (!i_size_read(inode)) | 578 | if (!i_size_read(inode)) |
583 | return -1; | 579 | return -1; |
584 | 580 | ||
@@ -639,6 +635,12 @@ int __btrfs_write_out_cache(struct btrfs_root *root, struct inode *inode, | |||
639 | if (block_group) | 635 | if (block_group) |
640 | start = block_group->key.objectid; | 636 | start = block_group->key.objectid; |
641 | 637 | ||
638 | node = rb_first(&ctl->free_space_offset); | ||
639 | if (!node && cluster) { | ||
640 | node = rb_first(&cluster->root); | ||
641 | cluster = NULL; | ||
642 | } | ||
643 | |||
642 | /* Write out the extent entries */ | 644 | /* Write out the extent entries */ |
643 | do { | 645 | do { |
644 | struct btrfs_free_space_entry *entry; | 646 | struct btrfs_free_space_entry *entry; |