btrfs: replace many BUG_ONs with proper error handling

 btrfs currently handles most errors with BUG_ON. This patch is a work-in-
 progress but aims to handle most errors other than internal logic
 errors and ENOMEM more gracefully.

 This iteration prevents most crashes but can run into lockups with
 the page lock on occasion when the timing "works out."

Signed-off-by: Jeff Mahoney <jeffm@suse.com>

1 files changed, 8 insertions, 5 deletions

diff --git a/fs/btrfs/free-space-cache.c b/fs/btrfs/free-space-cache.c
index ecbcc8711a03..054707ed5791 100644
--- a/fs/btrfs/free-space-cache.c
+++ b/fs/btrfs/free-space-cache.c
@@ -230,11 +230,13 @@ int btrfs_truncate_free_space_cache(struct btrfs_root *root,
 
         if (ret) {
                 trans->block_rsv = rsv;
-                WARN_ON(1);
+                btrfs_abort_transaction(trans, root, ret);
                 return ret;
         }
 
         ret = btrfs_update_inode(trans, root, inode);
+        if (ret)
+                btrfs_abort_transaction(trans, root, ret);
         trans->block_rsv = rsv;
 
         return ret;
@@ -1948,14 +1950,14 @@ again:
                  */
                 ret = btrfs_add_free_space(block_group, old_start,
                                            offset - old_start);
-                WARN_ON(ret);
+                WARN_ON(ret); /* -ENOMEM */
                 goto out;
         }
 
         ret = remove_from_bitmap(ctl, info, &offset, &bytes);
         if (ret == -EAGAIN)
                 goto again;
-        BUG_ON(ret);
+        BUG_ON(ret); /* logic error */
 out_lock:
         spin_unlock(&ctl->tree_lock);
 out:
@@ -2346,7 +2348,7 @@ again:
         rb_erase(&entry->offset_index, &ctl->free_space_offset);
         ret = tree_insert_offset(&cluster->root, entry->offset,
                                  &entry->offset_index, 1);
-        BUG_ON(ret);
+        BUG_ON(ret); /* -EEXIST; Logic error */
 
         trace_btrfs_setup_cluster(block_group, cluster,
                                   total_found * block_group->sectorsize, 1);
@@ -2439,7 +2441,7 @@ setup_cluster_no_bitmap(struct btrfs_block_group_cache *block_group,
                 ret = tree_insert_offset(&cluster->root, entry->offset,
                                          &entry->offset_index, 0);
                 total_size += entry->bytes;
-                BUG_ON(ret);
+                BUG_ON(ret); /* -EEXIST; Logic error */
         } while (node && entry != last);
 
         cluster->max_size = max_extent;
@@ -2830,6 +2832,7 @@ u64 btrfs_find_ino_for_alloc(struct btrfs_root *fs_root)
                 int ret;
 
                 ret = search_bitmap(ctl, entry, &offset, &count);
+                /* Logic error; Should be empty if it can't find anything */
                 BUG_ON(ret);
 
                 ino = offset;