aboutsummaryrefslogtreecommitdiffstats
path: root/fs/btrfs/extent_map.c
diff options
context:
space:
mode:
authorJosef Bacik <jbacik@fusionio.com>2013-01-24 12:02:07 -0500
committerJosef Bacik <jbacik@fusionio.com>2013-01-24 12:49:48 -0500
commit201a90389424d6771d24fc5d72f7e34cb4a8f967 (patch)
tree2e184b0b5a702855163d7da2fa5bee2a6fb8ef98 /fs/btrfs/extent_map.c
parenta105bb88f46b60de2adf1ee98745bd59362b09ab (diff)
Btrfs: do not allow logged extents to be merged or removed
We drop the extent map tree lock while we're logging extents, so somebody could come in and merge another extent into this one and screw up our logging, or they could even remove us from the list which would keep us from logging the extent or freeing our ref on it, so we need to make sure to not clear LOGGING until after the extent is logged, and then we can merge it to adjacent extents. Thanks, Signed-off-by: Josef Bacik <jbacik@fusionio.com>
Diffstat (limited to 'fs/btrfs/extent_map.c')
-rw-r--r--fs/btrfs/extent_map.c13
1 files changed, 12 insertions, 1 deletions
diff --git a/fs/btrfs/extent_map.c b/fs/btrfs/extent_map.c
index fff2c28497b6..ed88f5ee4bea 100644
--- a/fs/btrfs/extent_map.c
+++ b/fs/btrfs/extent_map.c
@@ -171,6 +171,10 @@ static int mergable_maps(struct extent_map *prev, struct extent_map *next)
171 if (test_bit(EXTENT_FLAG_COMPRESSED, &prev->flags)) 171 if (test_bit(EXTENT_FLAG_COMPRESSED, &prev->flags))
172 return 0; 172 return 0;
173 173
174 if (test_bit(EXTENT_FLAG_LOGGING, &prev->flags) ||
175 test_bit(EXTENT_FLAG_LOGGING, &next->flags))
176 return 0;
177
174 if (extent_map_end(prev) == next->start && 178 if (extent_map_end(prev) == next->start &&
175 prev->flags == next->flags && 179 prev->flags == next->flags &&
176 prev->bdev == next->bdev && 180 prev->bdev == next->bdev &&
@@ -256,7 +260,8 @@ int unpin_extent_cache(struct extent_map_tree *tree, u64 start, u64 len,
256 if (!em) 260 if (!em)
257 goto out; 261 goto out;
258 262
259 list_move(&em->list, &tree->modified_extents); 263 if (!test_bit(EXTENT_FLAG_LOGGING, &em->flags))
264 list_move(&em->list, &tree->modified_extents);
260 em->generation = gen; 265 em->generation = gen;
261 clear_bit(EXTENT_FLAG_PINNED, &em->flags); 266 clear_bit(EXTENT_FLAG_PINNED, &em->flags);
262 em->mod_start = em->start; 267 em->mod_start = em->start;
@@ -281,6 +286,12 @@ out:
281 286
282} 287}
283 288
289void clear_em_logging(struct extent_map_tree *tree, struct extent_map *em)
290{
291 clear_bit(EXTENT_FLAG_LOGGING, &em->flags);
292 try_merge_map(tree, em);
293}
294
284/** 295/**
285 * add_extent_mapping - add new extent map to the extent tree 296 * add_extent_mapping - add new extent map to the extent tree
286 * @tree: tree to insert new map in 297 * @tree: tree to insert new map in