diff options
author | Julia Lawall <Julia.Lawall@lip6.fr> | 2012-11-03 06:58:34 -0400 |
---|---|---|
committer | Josef Bacik <jbacik@fusionio.com> | 2012-12-12 17:15:23 -0500 |
commit | 31b1a2bd758f439fc945b3ac5899d890cb7e2dc6 (patch) | |
tree | a5659a8e51a780eb02a51c2f79c8e3c25d29bb92 /fs/btrfs/extent_io.c | |
parent | 5269b67e3d809dcaa4c6763a343423bb1b7b3fe6 (diff) |
fs/btrfs: use WARN
Use WARN rather than printk followed by WARN_ON(1), for conciseness.
A simplified version of the semantic patch that makes this transformation
is as follows: (http://coccinelle.lip6.fr/)
// <smpl>
@@
expression list es;
@@
-printk(
+WARN(1,
es);
-WARN_ON(1);
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Reviewed-by: David Sterba <dsterba@suse.cz>
Signed-off-by: Chris Mason <chris.mason@fusionio.com>
Diffstat (limited to 'fs/btrfs/extent_io.c')
-rw-r--r-- | fs/btrfs/extent_io.c | 9 |
1 files changed, 3 insertions, 6 deletions
diff --git a/fs/btrfs/extent_io.c b/fs/btrfs/extent_io.c index 472873a94d96..3c062c8d1d70 100644 --- a/fs/btrfs/extent_io.c +++ b/fs/btrfs/extent_io.c | |||
@@ -341,12 +341,10 @@ static int insert_state(struct extent_io_tree *tree, | |||
341 | { | 341 | { |
342 | struct rb_node *node; | 342 | struct rb_node *node; |
343 | 343 | ||
344 | if (end < start) { | 344 | if (end < start) |
345 | printk(KERN_ERR "btrfs end < start %llu %llu\n", | 345 | WARN(1, KERN_ERR "btrfs end < start %llu %llu\n", |
346 | (unsigned long long)end, | 346 | (unsigned long long)end, |
347 | (unsigned long long)start); | 347 | (unsigned long long)start); |
348 | WARN_ON(1); | ||
349 | } | ||
350 | state->start = start; | 348 | state->start = start; |
351 | state->end = end; | 349 | state->end = end; |
352 | 350 | ||
@@ -4721,10 +4719,9 @@ int map_private_extent_buffer(struct extent_buffer *eb, unsigned long start, | |||
4721 | } | 4719 | } |
4722 | 4720 | ||
4723 | if (start + min_len > eb->len) { | 4721 | if (start + min_len > eb->len) { |
4724 | printk(KERN_ERR "btrfs bad mapping eb start %llu len %lu, " | 4722 | WARN(1, KERN_ERR "btrfs bad mapping eb start %llu len %lu, " |
4725 | "wanted %lu %lu\n", (unsigned long long)eb->start, | 4723 | "wanted %lu %lu\n", (unsigned long long)eb->start, |
4726 | eb->len, start, min_len); | 4724 | eb->len, start, min_len); |
4727 | WARN_ON(1); | ||
4728 | return -EINVAL; | 4725 | return -EINVAL; |
4729 | } | 4726 | } |
4730 | 4727 | ||