diff options
author | Miguel <miguel.filipe@gmail.com> | 2008-04-11 15:45:51 -0400 |
---|---|---|
committer | Chris Mason <chris.mason@oracle.com> | 2008-09-25 11:04:01 -0400 |
commit | a5eb62e345fc1818d0d8b6181463200a9e8dfe39 (patch) | |
tree | 2e67b0628c8312d941f52edadc6c49bd8ac4c914 /fs/btrfs/disk-io.c | |
parent | 587f77043a1c86e2a7900ff2ce86bef3c1f4e075 (diff) |
Btrfs: Endianess bug fix for v0.13 with kernels
Fix for a endianess BUG when using btrfs v0.13 with kernels older than 2.6.23
Problem:
Has of v0.13, btrfs-progs is using crc32c.c equivalent to the one found on
linux-2.6.23/lib/libcrc32c.c Since crc32c_le() changed in linux-2.6.23, when
running btrfs v0.13 with older kernels we have a missmatch between the versions
of crc32c_le() from btrfs-progs and libcrc32c in the kernel. This missmatch
causes a bug when using btrfs on big endian machines.
Solution:
btrfs_crc32c() macro that when compiling for kernels older than 2.6.23, does
endianess conversion to parameters and return value of crc32c().
This endianess conversion nullifies the differences in implementation
of crc32c_le().
If kernel 2.6.23 or better, it calls crc32c().
Signed-off-by: Miguel Sousa Filipe <miguel.filipe@gmail.com>
---
Signed-off-by: Chris Mason <chris.mason@oracle.com>
Diffstat (limited to 'fs/btrfs/disk-io.c')
-rw-r--r-- | fs/btrfs/disk-io.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c index e22960e23501..0bfcc31d94d7 100644 --- a/fs/btrfs/disk-io.c +++ b/fs/btrfs/disk-io.c | |||
@@ -18,13 +18,13 @@ | |||
18 | 18 | ||
19 | #include <linux/fs.h> | 19 | #include <linux/fs.h> |
20 | #include <linux/blkdev.h> | 20 | #include <linux/blkdev.h> |
21 | #include <linux/crc32c.h> | ||
22 | #include <linux/scatterlist.h> | 21 | #include <linux/scatterlist.h> |
23 | #include <linux/swap.h> | 22 | #include <linux/swap.h> |
24 | #include <linux/radix-tree.h> | 23 | #include <linux/radix-tree.h> |
25 | #include <linux/writeback.h> | 24 | #include <linux/writeback.h> |
26 | #include <linux/buffer_head.h> // for block_sync_page | 25 | #include <linux/buffer_head.h> // for block_sync_page |
27 | #include <linux/workqueue.h> | 26 | #include <linux/workqueue.h> |
27 | #include "crc32c.h" | ||
28 | #include "ctree.h" | 28 | #include "ctree.h" |
29 | #include "disk-io.h" | 29 | #include "disk-io.h" |
30 | #include "transaction.h" | 30 | #include "transaction.h" |
@@ -100,7 +100,7 @@ out: | |||
100 | 100 | ||
101 | u32 btrfs_csum_data(struct btrfs_root *root, char *data, u32 seed, size_t len) | 101 | u32 btrfs_csum_data(struct btrfs_root *root, char *data, u32 seed, size_t len) |
102 | { | 102 | { |
103 | return crc32c(seed, data, len); | 103 | return btrfs_crc32c(seed, data, len); |
104 | } | 104 | } |
105 | 105 | ||
106 | void btrfs_csum_final(u32 crc, char *result) | 106 | void btrfs_csum_final(u32 crc, char *result) |