diff options
author | Liu Bo <liubo2009@cn.fujitsu.com> | 2011-11-14 20:48:06 -0500 |
---|---|---|
committer | Chris Mason <chris.mason@oracle.com> | 2011-11-15 09:53:28 -0500 |
commit | f1ebcc74d5b2159f44c96b479b6eb8afc7829095 (patch) | |
tree | 83d949e151f2f7e4a980396538cc0f2356bacfd4 /fs/btrfs/ctree.h | |
parent | 8965593e41dd2d0e2a2f1e6f245336005ea94a2c (diff) |
Btrfs: fix tree corruption after multi-thread snapshots and inode_cache flush
The btrfs snapshotting code requires that once a root has been
snapshotted, we don't change it during a commit.
But there are two cases to lead to tree corruptions:
1) multi-thread snapshots can commit serveral snapshots in a transaction,
and this may change the src root when processing the following pending
snapshots, which lead to the former snapshots corruptions;
2) the free inode cache was changing the roots when it root the cache,
which lead to corruptions.
This fixes things by making sure we force COW the block after we create a
snapshot during commiting a transaction, then any changes to the roots
will result in COW, and we get all the fs roots and snapshot roots to be
consistent.
Signed-off-by: Liu Bo <liubo2009@cn.fujitsu.com>
Signed-off-by: Miao Xie <miaox@cn.fujitsu.com>
Signed-off-by: Chris Mason <chris.mason@oracle.com>
Diffstat (limited to 'fs/btrfs/ctree.h')
-rw-r--r-- | fs/btrfs/ctree.h | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/fs/btrfs/ctree.h b/fs/btrfs/ctree.h index b9ba59ff9292..b1cb3c052484 100644 --- a/fs/btrfs/ctree.h +++ b/fs/btrfs/ctree.h | |||
@@ -1271,6 +1271,8 @@ struct btrfs_root { | |||
1271 | * for stat. It may be used for more later | 1271 | * for stat. It may be used for more later |
1272 | */ | 1272 | */ |
1273 | dev_t anon_dev; | 1273 | dev_t anon_dev; |
1274 | |||
1275 | int force_cow; | ||
1274 | }; | 1276 | }; |
1275 | 1277 | ||
1276 | struct btrfs_ioctl_defrag_range_args { | 1278 | struct btrfs_ioctl_defrag_range_args { |