diff options
author | Christoph Hellwig <hch@lst.de> | 2009-05-05 09:40:36 -0400 |
---|---|---|
committer | Al Viro <viro@zeniv.linux.org.uk> | 2009-06-11 21:36:07 -0400 |
commit | 6cfd0148425e528b859b26e436b01f23f6926224 (patch) | |
tree | 60e3257053554ff198fe5825e6f12a00c3b4422a /fs/bfs | |
parent | a9e220f8322e2b0e0b8903fe00265461cffad3f0 (diff) |
push BKL down into ->put_super
Move BKL into ->put_super from the only caller. A couple of
filesystems had trivial enough ->put_super (only kfree and NULLing of
s_fs_info + stuff in there) to not get any locking: coda, cramfs, efs,
hugetlbfs, omfs, qnx4, shmem, all others got the full treatment. Most
of them probably don't need it, but I'd rather sort that out individually.
Preferably after all the other BKL pushdowns in that area.
[AV: original used to move lock_super() down as well; these changes are
removed since we don't do lock_super() at all in generic_shutdown_super()
now]
[AV: fuse, btrfs and xfs are known to need no damn BKL, exempt]
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'fs/bfs')
-rw-r--r-- | fs/bfs/inode.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/fs/bfs/inode.c b/fs/bfs/inode.c index 4cf3d269e271..3a9a1361fdc1 100644 --- a/fs/bfs/inode.c +++ b/fs/bfs/inode.c | |||
@@ -217,6 +217,8 @@ static void bfs_put_super(struct super_block *s) | |||
217 | if (!info) | 217 | if (!info) |
218 | return; | 218 | return; |
219 | 219 | ||
220 | lock_kernel(); | ||
221 | |||
220 | if (s->s_dirt) | 222 | if (s->s_dirt) |
221 | bfs_write_super(s); | 223 | bfs_write_super(s); |
222 | 224 | ||
@@ -225,6 +227,8 @@ static void bfs_put_super(struct super_block *s) | |||
225 | kfree(info->si_imap); | 227 | kfree(info->si_imap); |
226 | kfree(info); | 228 | kfree(info); |
227 | s->s_fs_info = NULL; | 229 | s->s_fs_info = NULL; |
230 | |||
231 | unlock_kernel(); | ||
228 | } | 232 | } |
229 | 233 | ||
230 | static int bfs_statfs(struct dentry *dentry, struct kstatfs *buf) | 234 | static int bfs_statfs(struct dentry *dentry, struct kstatfs *buf) |