diff options
author | Christoph Hellwig <hch@lst.de> | 2009-04-28 12:00:26 -0400 |
---|---|---|
committer | Al Viro <viro@zeniv.linux.org.uk> | 2009-06-11 21:36:06 -0400 |
commit | 8c85e125124a473d6f3e9bb187b0b84207f81d91 (patch) | |
tree | d883424a156c00c55193e46567efdffddb6ef6b9 /fs/bfs/inode.c | |
parent | 517bfae28353e996160518add4d00033d3886e61 (diff) |
remove ->write_super call in generic_shutdown_super
We just did a full fs writeout using sync_filesystem before, and if
that's not enough for the filesystem it can perform it's own writeout
in ->put_super, which many filesystems already do.
Move a call to foofs_write_super into every foofs_put_super for now to
guarantee identical behaviour until it's cleaned up by the individual
filesystem maintainers.
Exceptions:
- affs already has identical copy & pasted code at the beginning of
affs_put_super so no need to do it twice.
- xfs does the right thing without it and I have changes pending for
the xfs tree touching this are so I don't really need conflicts
here..
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'fs/bfs/inode.c')
-rw-r--r-- | fs/bfs/inode.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/fs/bfs/inode.c b/fs/bfs/inode.c index cc4062d12ca2..4cf3d269e271 100644 --- a/fs/bfs/inode.c +++ b/fs/bfs/inode.c | |||
@@ -30,6 +30,7 @@ MODULE_LICENSE("GPL"); | |||
30 | #define dprintf(x...) | 30 | #define dprintf(x...) |
31 | #endif | 31 | #endif |
32 | 32 | ||
33 | static void bfs_write_super(struct super_block *s); | ||
33 | void dump_imap(const char *prefix, struct super_block *s); | 34 | void dump_imap(const char *prefix, struct super_block *s); |
34 | 35 | ||
35 | struct inode *bfs_iget(struct super_block *sb, unsigned long ino) | 36 | struct inode *bfs_iget(struct super_block *sb, unsigned long ino) |
@@ -216,6 +217,9 @@ static void bfs_put_super(struct super_block *s) | |||
216 | if (!info) | 217 | if (!info) |
217 | return; | 218 | return; |
218 | 219 | ||
220 | if (s->s_dirt) | ||
221 | bfs_write_super(s); | ||
222 | |||
219 | brelse(info->si_sbh); | 223 | brelse(info->si_sbh); |
220 | mutex_destroy(&info->bfs_lock); | 224 | mutex_destroy(&info->bfs_lock); |
221 | kfree(info->si_imap); | 225 | kfree(info->si_imap); |