diff options
author | Theodore Ts'o <tytso@mit.edu> | 2006-09-27 04:50:46 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@g5.osdl.org> | 2006-09-27 11:26:17 -0400 |
commit | 8e18e2941c53416aa219708e7dcad21fb4bd6794 (patch) | |
tree | 44118f8b09556193ac93e0b71aecfa3e1d4bc182 /fs/autofs | |
parent | 6a1d9805ec506d8b9d04450997707da5f643d87c (diff) |
[PATCH] inode_diet: Replace inode.u.generic_ip with inode.i_private
The following patches reduce the size of the VFS inode structure by 28 bytes
on a UP x86. (It would be more on an x86_64 system). This is a 10% reduction
in the inode size on a UP kernel that is configured in a production mode
(i.e., with no spinlock or other debugging functions enabled; if you want to
save memory taken up by in-core inodes, the first thing you should do is
disable the debugging options; they are responsible for a huge amount of bloat
in the VFS inode structure).
This patch:
The filesystem or device-specific pointer in the inode is inside a union,
which is pretty pointless given that all 30+ users of this field have been
using the void pointer. Get rid of the union and rename it to i_private, with
a comment to explain who is allowed to use the void pointer. This is just a
cleanup, but it allows us to reuse the union 'u' for something something where
the union will actually be used.
[judith@osdl.org: powerpc build fix]
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Signed-off-by: Judith Lebzelter <judith@osdl.org>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'fs/autofs')
-rw-r--r-- | fs/autofs/inode.c | 2 | ||||
-rw-r--r-- | fs/autofs/symlink.c | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/fs/autofs/inode.c b/fs/autofs/inode.c index c81d6b8c2828..d39d2acd9b38 100644 --- a/fs/autofs/inode.c +++ b/fs/autofs/inode.c | |||
@@ -241,7 +241,7 @@ static void autofs_read_inode(struct inode *inode) | |||
241 | 241 | ||
242 | inode->i_op = &autofs_symlink_inode_operations; | 242 | inode->i_op = &autofs_symlink_inode_operations; |
243 | sl = &sbi->symlink[n]; | 243 | sl = &sbi->symlink[n]; |
244 | inode->u.generic_ip = sl; | 244 | inode->i_private = sl; |
245 | inode->i_mode = S_IFLNK | S_IRWXUGO; | 245 | inode->i_mode = S_IFLNK | S_IRWXUGO; |
246 | inode->i_mtime.tv_sec = inode->i_ctime.tv_sec = sl->mtime; | 246 | inode->i_mtime.tv_sec = inode->i_ctime.tv_sec = sl->mtime; |
247 | inode->i_mtime.tv_nsec = inode->i_ctime.tv_nsec = 0; | 247 | inode->i_mtime.tv_nsec = inode->i_ctime.tv_nsec = 0; |
diff --git a/fs/autofs/symlink.c b/fs/autofs/symlink.c index 52e8772b066e..c74f2eb65775 100644 --- a/fs/autofs/symlink.c +++ b/fs/autofs/symlink.c | |||
@@ -15,7 +15,7 @@ | |||
15 | /* Nothing to release.. */ | 15 | /* Nothing to release.. */ |
16 | static void *autofs_follow_link(struct dentry *dentry, struct nameidata *nd) | 16 | static void *autofs_follow_link(struct dentry *dentry, struct nameidata *nd) |
17 | { | 17 | { |
18 | char *s=((struct autofs_symlink *)dentry->d_inode->u.generic_ip)->data; | 18 | char *s=((struct autofs_symlink *)dentry->d_inode->i_private)->data; |
19 | nd_set_link(nd, s); | 19 | nd_set_link(nd, s); |
20 | return NULL; | 20 | return NULL; |
21 | } | 21 | } |