switch follow_down()

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

4 files changed, 14 insertions, 16 deletions

diff --git a/fs/autofs4/autofs_i.h b/fs/autofs4/autofs_i.h
index b7ff33c63101..8f7cdde41733 100644
--- a/fs/autofs4/autofs_i.h
+++ b/fs/autofs4/autofs_i.h
@@ -223,12 +223,12 @@ int autofs4_wait(struct autofs_sb_info *,struct dentry *, enum autofs_notify);
 int autofs4_wait_release(struct autofs_sb_info *,autofs_wqt_t,int);
 void autofs4_catatonic_mode(struct autofs_sb_info *);
 
-static inline int autofs4_follow_mount(struct vfsmount **mnt, struct dentry **dentry)
+static inline int autofs4_follow_mount(struct path *path)
 {
         int res = 0;
 
-        while (d_mountpoint(*dentry)) {
-                int followed = follow_down(mnt, dentry);
+        while (d_mountpoint(path->dentry)) {
+                int followed = follow_down(path);
                 if (!followed)
                         break;
                 res = 1;
diff --git a/fs/autofs4/dev-ioctl.c b/fs/autofs4/dev-ioctl.c
index 670407576b25..f3da2eb51f56 100644
--- a/fs/autofs4/dev-ioctl.c
+++ b/fs/autofs4/dev-ioctl.c
@@ -562,7 +562,7 @@ static int autofs_dev_ioctl_ismountpoint(struct file *fp,
                 err = have_submounts(path.dentry);
 
                 if (path.mnt->mnt_mountpoint != path.mnt->mnt_root) {
-                        if (follow_down(&path.mnt, &path.dentry))
+                        if (follow_down(&path))
                                 magic = path.mnt->mnt_sb->s_magic;
                 }
         }
diff --git a/fs/autofs4/expire.c b/fs/autofs4/expire.c
index 3077d8f16523..aa39ae83f019 100644
--- a/fs/autofs4/expire.c
+++ b/fs/autofs4/expire.c
@@ -48,19 +48,19 @@ static inline int autofs4_can_expire(struct dentry *dentry,
 static int autofs4_mount_busy(struct vfsmount *mnt, struct dentry *dentry)
 {
         struct dentry *top = dentry;
+        struct path path = {.mnt = mnt, .dentry = dentry};
         int status = 1;
 
         DPRINTK("dentry %p %.*s",
                 dentry, (int)dentry->d_name.len, dentry->d_name.name);
 
-        mntget(mnt);
-        dget(dentry);
+        path_get(&path);
 
-        if (!follow_down(&mnt, &dentry))
+        if (!follow_down(&path))
                 goto done;
 
-        if (is_autofs4_dentry(dentry)) {
-                struct autofs_sb_info *sbi = autofs4_sbi(dentry->d_sb);
+        if (is_autofs4_dentry(path.dentry)) {
+                struct autofs_sb_info *sbi = autofs4_sbi(path.dentry->d_sb);
 
                 /* This is an autofs submount, we can't expire it */
                 if (autofs_type_indirect(sbi->type))
@@ -70,7 +70,7 @@ static int autofs4_mount_busy(struct vfsmount *mnt, struct dentry *dentry)
                  * Otherwise it's an offset mount and we need to check
                  * if we can umount its mount, if there is one.
                  */
-                if (!d_mountpoint(dentry)) {
+                if (!d_mountpoint(path.dentry)) {
                         status = 0;
                         goto done;
                 }
@@ -86,8 +86,7 @@ static int autofs4_mount_busy(struct vfsmount *mnt, struct dentry *dentry)
         status = 0;
 done:
         DPRINTK("returning = %d", status);
-        dput(dentry);
-        mntput(mnt);
+        path_put(&path);
         return status;
 }
 
diff --git a/fs/autofs4/root.c b/fs/autofs4/root.c
index e383bf0334f1..b96a3c57359d 100644
--- a/fs/autofs4/root.c
+++ b/fs/autofs4/root.c
@@ -181,7 +181,7 @@ static void *autofs4_follow_link(struct dentry *dentry, struct nameidata *nd)
                 nd->flags);
         /*
          * For an expire of a covered direct or offset mount we need
-         * to beeak out of follow_down() at the autofs mount trigger
+         * to break out of follow_down() at the autofs mount trigger
          * (d_mounted--), so we can see the expiring flag, and manage
          * the blocking and following here until the expire is completed.
          */
@@ -190,7 +190,7 @@ static void *autofs4_follow_link(struct dentry *dentry, struct nameidata *nd)
                 if (ino->flags & AUTOFS_INF_EXPIRING) {
                         spin_unlock(&sbi->fs_lock);
                         /* Follow down to our covering mount. */
-                        if (!follow_down(&nd->path.mnt, &nd->path.dentry))
+                        if (!follow_down(&nd->path))
                                 goto done;
                         goto follow;
                 }
@@ -230,8 +230,7 @@ follow:
          * to follow it.
          */
         if (d_mountpoint(dentry)) {
-                if (!autofs4_follow_mount(&nd->path.mnt,
-                                          &nd->path.dentry)) {
+                if (!autofs4_follow_mount(&nd->path)) {
                         status = -ENOENT;
                         goto out_error;
                 }