diff options
author | Robert Love <rml@novell.com> | 2005-07-12 17:06:03 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@g5.osdl.org> | 2005-07-12 23:38:38 -0400 |
commit | 0eeca28300df110bd6ed54b31193c83b87921443 (patch) | |
tree | 7db42d8a18d80eca538f5b7d25e0532b8fa38b85 /fs/attr.c | |
parent | bd4c625c061c2a38568d0add3478f59172455159 (diff) |
[PATCH] inotify
inotify is intended to correct the deficiencies of dnotify, particularly
its inability to scale and its terrible user interface:
* dnotify requires the opening of one fd per each directory
that you intend to watch. This quickly results in too many
open files and pins removable media, preventing unmount.
* dnotify is directory-based. You only learn about changes to
directories. Sure, a change to a file in a directory affects
the directory, but you are then forced to keep a cache of
stat structures.
* dnotify's interface to user-space is awful. Signals?
inotify provides a more usable, simple, powerful solution to file change
notification:
* inotify's interface is a system call that returns a fd, not SIGIO.
You get a single fd, which is select()-able.
* inotify has an event that says "the filesystem that the item
you were watching is on was unmounted."
* inotify can watch directories or files.
Inotify is currently used by Beagle (a desktop search infrastructure),
Gamin (a FAM replacement), and other projects.
See Documentation/filesystems/inotify.txt.
Signed-off-by: Robert Love <rml@novell.com>
Cc: John McCutchan <ttb@tentacle.dhs.org>
Cc: Christoph Hellwig <hch@lst.de>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'fs/attr.c')
-rw-r--r-- | fs/attr.c | 33 |
1 files changed, 4 insertions, 29 deletions
@@ -10,7 +10,7 @@ | |||
10 | #include <linux/mm.h> | 10 | #include <linux/mm.h> |
11 | #include <linux/string.h> | 11 | #include <linux/string.h> |
12 | #include <linux/smp_lock.h> | 12 | #include <linux/smp_lock.h> |
13 | #include <linux/dnotify.h> | 13 | #include <linux/fsnotify.h> |
14 | #include <linux/fcntl.h> | 14 | #include <linux/fcntl.h> |
15 | #include <linux/quotaops.h> | 15 | #include <linux/quotaops.h> |
16 | #include <linux/security.h> | 16 | #include <linux/security.h> |
@@ -107,31 +107,8 @@ int inode_setattr(struct inode * inode, struct iattr * attr) | |||
107 | out: | 107 | out: |
108 | return error; | 108 | return error; |
109 | } | 109 | } |
110 | |||
111 | EXPORT_SYMBOL(inode_setattr); | 110 | EXPORT_SYMBOL(inode_setattr); |
112 | 111 | ||
113 | int setattr_mask(unsigned int ia_valid) | ||
114 | { | ||
115 | unsigned long dn_mask = 0; | ||
116 | |||
117 | if (ia_valid & ATTR_UID) | ||
118 | dn_mask |= DN_ATTRIB; | ||
119 | if (ia_valid & ATTR_GID) | ||
120 | dn_mask |= DN_ATTRIB; | ||
121 | if (ia_valid & ATTR_SIZE) | ||
122 | dn_mask |= DN_MODIFY; | ||
123 | /* both times implies a utime(s) call */ | ||
124 | if ((ia_valid & (ATTR_ATIME|ATTR_MTIME)) == (ATTR_ATIME|ATTR_MTIME)) | ||
125 | dn_mask |= DN_ATTRIB; | ||
126 | else if (ia_valid & ATTR_ATIME) | ||
127 | dn_mask |= DN_ACCESS; | ||
128 | else if (ia_valid & ATTR_MTIME) | ||
129 | dn_mask |= DN_MODIFY; | ||
130 | if (ia_valid & ATTR_MODE) | ||
131 | dn_mask |= DN_ATTRIB; | ||
132 | return dn_mask; | ||
133 | } | ||
134 | |||
135 | int notify_change(struct dentry * dentry, struct iattr * attr) | 112 | int notify_change(struct dentry * dentry, struct iattr * attr) |
136 | { | 113 | { |
137 | struct inode *inode = dentry->d_inode; | 114 | struct inode *inode = dentry->d_inode; |
@@ -197,11 +174,9 @@ int notify_change(struct dentry * dentry, struct iattr * attr) | |||
197 | if (ia_valid & ATTR_SIZE) | 174 | if (ia_valid & ATTR_SIZE) |
198 | up_write(&dentry->d_inode->i_alloc_sem); | 175 | up_write(&dentry->d_inode->i_alloc_sem); |
199 | 176 | ||
200 | if (!error) { | 177 | if (!error) |
201 | unsigned long dn_mask = setattr_mask(ia_valid); | 178 | fsnotify_change(dentry, ia_valid); |
202 | if (dn_mask) | 179 | |
203 | dnotify_parent(dentry, dn_mask); | ||
204 | } | ||
205 | return error; | 180 | return error; |
206 | } | 181 | } |
207 | 182 | ||