diff options
author | Christoph Hellwig <hch@lst.de> | 2010-06-04 05:30:00 -0400 |
---|---|---|
committer | Al Viro <viro@zeniv.linux.org.uk> | 2010-08-09 16:47:35 -0400 |
commit | 6a1a90ad1b0edb556a7550a6ef8a8756f0304dd5 (patch) | |
tree | 234488533d89e3f8b938823c2071be19e66e1b4b /fs/attr.c | |
parent | d39aae9ec447dda84d9a2850743a78a535a71c90 (diff) |
rename generic_setattr
Despite its name it's now a generic implementation of ->setattr, but
rather a helper to copy attributes from a struct iattr to the inode.
Rename it to setattr_copy to reflect this fact.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'fs/attr.c')
-rw-r--r-- | fs/attr.c | 14 |
1 files changed, 7 insertions, 7 deletions
@@ -105,13 +105,13 @@ out_big: | |||
105 | EXPORT_SYMBOL(inode_newsize_ok); | 105 | EXPORT_SYMBOL(inode_newsize_ok); |
106 | 106 | ||
107 | /** | 107 | /** |
108 | * generic_setattr - copy simple metadata updates into the generic inode | 108 | * setattr_copy - copy simple metadata updates into the generic inode |
109 | * @inode: the inode to be updated | 109 | * @inode: the inode to be updated |
110 | * @attr: the new attributes | 110 | * @attr: the new attributes |
111 | * | 111 | * |
112 | * generic_setattr must be called with i_mutex held. | 112 | * setattr_copy must be called with i_mutex held. |
113 | * | 113 | * |
114 | * generic_setattr updates the inode's metadata with that specified | 114 | * setattr_copy updates the inode's metadata with that specified |
115 | * in attr. Noticably missing is inode size update, which is more complex | 115 | * in attr. Noticably missing is inode size update, which is more complex |
116 | * as it requires pagecache updates. See simple_setsize. | 116 | * as it requires pagecache updates. See simple_setsize. |
117 | * | 117 | * |
@@ -119,7 +119,7 @@ EXPORT_SYMBOL(inode_newsize_ok); | |||
119 | * that for "simple" filesystems, the struct inode is the inode storage. | 119 | * that for "simple" filesystems, the struct inode is the inode storage. |
120 | * The caller is free to mark the inode dirty afterwards if needed. | 120 | * The caller is free to mark the inode dirty afterwards if needed. |
121 | */ | 121 | */ |
122 | void generic_setattr(struct inode *inode, const struct iattr *attr) | 122 | void setattr_copy(struct inode *inode, const struct iattr *attr) |
123 | { | 123 | { |
124 | unsigned int ia_valid = attr->ia_valid; | 124 | unsigned int ia_valid = attr->ia_valid; |
125 | 125 | ||
@@ -144,11 +144,11 @@ void generic_setattr(struct inode *inode, const struct iattr *attr) | |||
144 | inode->i_mode = mode; | 144 | inode->i_mode = mode; |
145 | } | 145 | } |
146 | } | 146 | } |
147 | EXPORT_SYMBOL(generic_setattr); | 147 | EXPORT_SYMBOL(setattr_copy); |
148 | 148 | ||
149 | /* | 149 | /* |
150 | * note this function is deprecated, the new truncate sequence should be | 150 | * note this function is deprecated, the new truncate sequence should be |
151 | * used instead -- see eg. simple_setsize, generic_setattr. | 151 | * used instead -- see eg. simple_setsize, setattr_copy. |
152 | */ | 152 | */ |
153 | int inode_setattr(struct inode *inode, const struct iattr *attr) | 153 | int inode_setattr(struct inode *inode, const struct iattr *attr) |
154 | { | 154 | { |
@@ -163,7 +163,7 @@ int inode_setattr(struct inode *inode, const struct iattr *attr) | |||
163 | return error; | 163 | return error; |
164 | } | 164 | } |
165 | 165 | ||
166 | generic_setattr(inode, attr); | 166 | setattr_copy(inode, attr); |
167 | 167 | ||
168 | mark_inode_dirty(inode); | 168 | mark_inode_dirty(inode); |
169 | 169 | ||