diff options
author | Michel Lespinasse <walken@google.com> | 2013-02-22 19:32:47 -0500 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2013-02-23 20:50:11 -0500 |
commit | 41badc15cbad0350de34408c1b0c690f9df76d4b (patch) | |
tree | 2545134398b99b37259bf6412a0bb56442f120fa /fs/aio.c | |
parent | 1869305009857cdeaabe6283bcdc2359c5784543 (diff) |
mm: make do_mmap_pgoff return populate as a size in bytes, not as a bool
do_mmap_pgoff() rounds up the desired size to the next PAGE_SIZE
multiple, however there was no equivalent code in mm_populate(), which
caused issues.
This could be fixed by introduced the same rounding in mm_populate(),
however I think it's preferable to make do_mmap_pgoff() return populate
as a size rather than as a boolean, so we don't have to duplicate the
size rounding logic in mm_populate().
Signed-off-by: Michel Lespinasse <walken@google.com>
Acked-by: Rik van Riel <riel@redhat.com>
Tested-by: Andy Lutomirski <luto@amacapital.net>
Cc: Greg Ungerer <gregungerer@westnet.com.au>
Cc: David Howells <dhowells@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'fs/aio.c')
-rw-r--r-- | fs/aio.c | 5 |
1 files changed, 2 insertions, 3 deletions
@@ -101,9 +101,8 @@ static int aio_setup_ring(struct kioctx *ctx) | |||
101 | struct aio_ring *ring; | 101 | struct aio_ring *ring; |
102 | struct aio_ring_info *info = &ctx->ring_info; | 102 | struct aio_ring_info *info = &ctx->ring_info; |
103 | unsigned nr_events = ctx->max_reqs; | 103 | unsigned nr_events = ctx->max_reqs; |
104 | unsigned long size; | 104 | unsigned long size, populate; |
105 | int nr_pages; | 105 | int nr_pages; |
106 | bool populate; | ||
107 | 106 | ||
108 | /* Compensate for the ring buffer's head/tail overlap entry */ | 107 | /* Compensate for the ring buffer's head/tail overlap entry */ |
109 | nr_events += 2; /* 1 is required, 2 for good luck */ | 108 | nr_events += 2; /* 1 is required, 2 for good luck */ |
@@ -150,7 +149,7 @@ static int aio_setup_ring(struct kioctx *ctx) | |||
150 | return -EAGAIN; | 149 | return -EAGAIN; |
151 | } | 150 | } |
152 | if (populate) | 151 | if (populate) |
153 | mm_populate(info->mmap_base, info->mmap_size); | 152 | mm_populate(info->mmap_base, populate); |
154 | 153 | ||
155 | ctx->user_id = info->mmap_base; | 154 | ctx->user_id = info->mmap_base; |
156 | 155 | ||