aboutsummaryrefslogtreecommitdiffstats
path: root/fs/afs/super.c
diff options
context:
space:
mode:
authorTheodore Ts'o <tytso@mit.edu>2006-03-24 06:15:10 -0500
committerLinus Torvalds <torvalds@g5.osdl.org>2006-03-24 10:33:15 -0500
commit9b04c997b1120feefa1e6ee8e2902270bc055cd2 (patch)
tree09376b68d11ccce2a1ef53bac25a41a763ad36d0 /fs/afs/super.c
parent6961ec8267d08e21011457b05d2263ec06bdcfe1 (diff)
[PATCH] vfs: MS_VERBOSE should be MS_SILENT
The meaning of MS_VERBOSE is backwards; if the bit is set, it really means, "don't be verbose". This is confusing and counter-intuitive. In addition, there is also no way to set the MS_VERBOSE flag in the mount(8) program in util-linux, but interesting, it does define options which would do the right thing if MS_SILENT were defined, which unfortunately we do not: #ifdef MS_SILENT { "quiet", 0, 0, MS_SILENT }, /* be quiet */ { "loud", 0, 1, MS_SILENT }, /* print out messages. */ #endif So the obvious fix is to deprecate the use of MS_VERBOSE and replace it with MS_SILENT. Signed-off-by: "Theodore Ts'o" <tytso@mit.edu> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'fs/afs/super.c')
-rw-r--r--fs/afs/super.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/afs/super.c b/fs/afs/super.c
index d6fa8e5999df..53c56e7231ab 100644
--- a/fs/afs/super.c
+++ b/fs/afs/super.c
@@ -341,7 +341,7 @@ static struct super_block *afs_get_sb(struct file_system_type *fs_type,
341 341
342 sb->s_flags = flags; 342 sb->s_flags = flags;
343 343
344 ret = afs_fill_super(sb, &params, flags & MS_VERBOSE ? 1 : 0); 344 ret = afs_fill_super(sb, &params, flags & MS_SILENT ? 1 : 0);
345 if (ret < 0) { 345 if (ret < 0) {
346 up_write(&sb->s_umount); 346 up_write(&sb->s_umount);
347 deactivate_super(sb); 347 deactivate_super(sb);