diff options
author | Christoph Hellwig <hch@lst.de> | 2009-05-11 17:35:03 -0400 |
---|---|---|
committer | Al Viro <viro@zeniv.linux.org.uk> | 2009-06-11 21:36:09 -0400 |
commit | ebc1ac164560a241d9bf1b7519062910c3f90a01 (patch) | |
tree | db17fd3043b15f8269cce2c2d00213814022fc30 /fs/affs | |
parent | 01ba687577647beef6c5f2ea59bfb56fac9fcde2 (diff) |
->write_super lock_super pushdown
Push down lock_super into ->write_super instances and remove it from the
caller.
Following filesystem don't need ->s_lock in ->write_super and are skipped:
* bfs, nilfs2 - no other uses of s_lock and have internal locks in
->write_super
* ext2 - uses BKL in ext2_write_super and has internal calls without s_lock
* reiserfs - no other uses of s_lock as has reiserfs_write_lock (BKL) in
->write_super
* xfs - no other uses of s_lock and uses internal lock (buffer lock on
superblock buffer) to serialize ->write_super. Also xfs_fs_write_super
is superflous and will go away in the next merge window
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'fs/affs')
-rw-r--r-- | fs/affs/super.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/fs/affs/super.c b/fs/affs/super.c index d7386462a8e7..280d361af41f 100644 --- a/fs/affs/super.c +++ b/fs/affs/super.c | |||
@@ -54,6 +54,7 @@ affs_write_super(struct super_block *sb) | |||
54 | int clean = 2; | 54 | int clean = 2; |
55 | struct affs_sb_info *sbi = AFFS_SB(sb); | 55 | struct affs_sb_info *sbi = AFFS_SB(sb); |
56 | 56 | ||
57 | lock_super(sb); | ||
57 | if (!(sb->s_flags & MS_RDONLY)) { | 58 | if (!(sb->s_flags & MS_RDONLY)) { |
58 | // if (sbi->s_bitmap[i].bm_bh) { | 59 | // if (sbi->s_bitmap[i].bm_bh) { |
59 | // if (buffer_dirty(sbi->s_bitmap[i].bm_bh)) { | 60 | // if (buffer_dirty(sbi->s_bitmap[i].bm_bh)) { |
@@ -66,6 +67,7 @@ affs_write_super(struct super_block *sb) | |||
66 | sb->s_dirt = !clean; /* redo until bitmap synced */ | 67 | sb->s_dirt = !clean; /* redo until bitmap synced */ |
67 | } else | 68 | } else |
68 | sb->s_dirt = 0; | 69 | sb->s_dirt = 0; |
70 | unlock_super(sb); | ||
69 | 71 | ||
70 | pr_debug("AFFS: write_super() at %lu, clean=%d\n", get_seconds(), clean); | 72 | pr_debug("AFFS: write_super() at %lu, clean=%d\n", get_seconds(), clean); |
71 | } | 73 | } |