diff options
author | Chuck Lever <chuck.lever@oracle.com> | 2008-03-27 16:34:40 -0400 |
---|---|---|
committer | J. Bruce Fields <bfields@citi.umich.edu> | 2008-04-23 16:13:41 -0400 |
commit | 6ffd4be6336f9c3f1a10822099587544cd0a11d7 (patch) | |
tree | 19023c6f1f7237b5d99fcae95c49d0eabab89b92 /fs/Kconfig | |
parent | 03550fac06c4f0c39a1885d46015c28794413c82 (diff) |
NFSD: Use "depends on" for PROC_FS dependency
Recently, commit 440bcc59 added a reverse dependency to fs/Kconfig to
ensure that PROC_FS was enabled if NFSD_V4 was enabled.
There is a guideline in Documentation/kbuild/kconfig-language.txt that
states "In general use select only for non-visible symbols (no prompts
anywhere) and for symbols with no dependencies."
A quick grep around other Kconfig files reveals that no entry currently
uses "select PROC_FS" -- every one uses "depends on". Thus CONFIG_NFSD_V4
should use "depends on PROC_FS" as well.
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>
Diffstat (limited to 'fs/Kconfig')
-rw-r--r-- | fs/Kconfig | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/fs/Kconfig b/fs/Kconfig index 1d81be3fef3b..9539848b4110 100644 --- a/fs/Kconfig +++ b/fs/Kconfig | |||
@@ -1695,7 +1695,6 @@ config NFSD | |||
1695 | select SUNRPC | 1695 | select SUNRPC |
1696 | select EXPORTFS | 1696 | select EXPORTFS |
1697 | select NFS_ACL_SUPPORT if NFSD_V2_ACL | 1697 | select NFS_ACL_SUPPORT if NFSD_V2_ACL |
1698 | select PROC_FS if NFSD_V4 | ||
1699 | select PROC_FS if SUNRPC_GSS | 1698 | select PROC_FS if SUNRPC_GSS |
1700 | help | 1699 | help |
1701 | Choose Y here if you want to allow other computers to access | 1700 | Choose Y here if you want to allow other computers to access |
@@ -1757,7 +1756,7 @@ config NFSD_V3_ACL | |||
1757 | 1756 | ||
1758 | config NFSD_V4 | 1757 | config NFSD_V4 |
1759 | bool "NFS server support for NFS version 4 (EXPERIMENTAL)" | 1758 | bool "NFS server support for NFS version 4 (EXPERIMENTAL)" |
1760 | depends on NFSD && NFSD_V3 && EXPERIMENTAL | 1759 | depends on NFSD && NFSD_V3 && PROC_FS && EXPERIMENTAL |
1761 | select FS_POSIX_ACL | 1760 | select FS_POSIX_ACL |
1762 | select RPCSEC_GSS_KRB5 | 1761 | select RPCSEC_GSS_KRB5 |
1763 | help | 1762 | help |