diff options
author | Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com> | 2011-03-08 06:09:46 -0500 |
---|---|---|
committer | Eric Van Hensbergen <ericvh@gmail.com> | 2011-03-22 16:43:35 -0400 |
commit | 5a7e0a8cf50cf905403f5a498e86d1f97cfcf51b (patch) | |
tree | 3f20f98db76f7a221f397630a03e6089c1208510 /fs/9p/vfs_inode_dotl.c | |
parent | f741a79e982cf56d7584435bad663553ffe6715f (diff) |
fs/9p: Fix race in initializing writeback fid
When two process open the same file we can end up with both of them
allocating the writeback_fid. Add a new mutex which can be used
for synchronizing v9fs_inode member values.
Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
Signed-off-by: Venkateswararao Jujjuri <jvrao@linux.vnet.ibm.com>
Signed-off-by: Eric Van Hensbergen <ericvh@gmail.com>
Diffstat (limited to 'fs/9p/vfs_inode_dotl.c')
-rw-r--r-- | fs/9p/vfs_inode_dotl.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/fs/9p/vfs_inode_dotl.c b/fs/9p/vfs_inode_dotl.c index 67c138e94feb..327c578c7ba6 100644 --- a/fs/9p/vfs_inode_dotl.c +++ b/fs/9p/vfs_inode_dotl.c | |||
@@ -245,6 +245,7 @@ v9fs_vfs_create_dotl(struct inode *dir, struct dentry *dentry, int omode, | |||
245 | v9fs_set_create_acl(dentry, dacl, pacl); | 245 | v9fs_set_create_acl(dentry, dacl, pacl); |
246 | 246 | ||
247 | v9inode = V9FS_I(inode); | 247 | v9inode = V9FS_I(inode); |
248 | mutex_lock(&v9inode->v_mutex); | ||
248 | if (v9ses->cache && !v9inode->writeback_fid) { | 249 | if (v9ses->cache && !v9inode->writeback_fid) { |
249 | /* | 250 | /* |
250 | * clone a fid and add it to writeback_fid | 251 | * clone a fid and add it to writeback_fid |
@@ -256,10 +257,12 @@ v9fs_vfs_create_dotl(struct inode *dir, struct dentry *dentry, int omode, | |||
256 | inode_fid = v9fs_writeback_fid(dentry); | 257 | inode_fid = v9fs_writeback_fid(dentry); |
257 | if (IS_ERR(inode_fid)) { | 258 | if (IS_ERR(inode_fid)) { |
258 | err = PTR_ERR(inode_fid); | 259 | err = PTR_ERR(inode_fid); |
260 | mutex_unlock(&v9inode->v_mutex); | ||
259 | goto error; | 261 | goto error; |
260 | } | 262 | } |
261 | v9inode->writeback_fid = (void *) inode_fid; | 263 | v9inode->writeback_fid = (void *) inode_fid; |
262 | } | 264 | } |
265 | mutex_unlock(&v9inode->v_mutex); | ||
263 | /* Since we are opening a file, assign the open fid to the file */ | 266 | /* Since we are opening a file, assign the open fid to the file */ |
264 | filp = lookup_instantiate_filp(nd, dentry, generic_file_open); | 267 | filp = lookup_instantiate_filp(nd, dentry, generic_file_open); |
265 | if (IS_ERR(filp)) { | 268 | if (IS_ERR(filp)) { |