diff options
author | Linus Torvalds <torvalds@woody.linux-foundation.org> | 2007-08-31 00:55:22 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@woody.linux-foundation.org> | 2007-08-31 00:55:22 -0400 |
commit | 644b55ce889edd37d6406df26e2d96d7a7390749 (patch) | |
tree | 9dc34216c5cf4c65d789fb2695289e09324558d4 /drivers | |
parent | feabb06bd70551668540f2305047675667f5f60f (diff) | |
parent | b3e2c70cd0d05fb6621521521fbd5debed57d753 (diff) |
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input
* 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input:
Input: psmouse - make dummy touchkit_ps2_detect() static
Input: gscps2 - convert to use kzalloc
Input: iforce - fix 'unused variable' warning
Input: i8042 - fix retrun value of i8042_aux_test_irq
Input: gpio_keys - remove duplicate includes
Diffstat (limited to 'drivers')
-rw-r--r-- | drivers/input/joystick/iforce/iforce-packets.c | 8 | ||||
-rw-r--r-- | drivers/input/keyboard/gpio_keys.c | 1 | ||||
-rw-r--r-- | drivers/input/mouse/touchkit_ps2.h | 3 | ||||
-rw-r--r-- | drivers/input/serio/gscps2.c | 6 | ||||
-rw-r--r-- | drivers/input/serio/i8042.c | 4 |
5 files changed, 11 insertions, 11 deletions
diff --git a/drivers/input/joystick/iforce/iforce-packets.c b/drivers/input/joystick/iforce/iforce-packets.c index 3154ccd74000..45c4939ced75 100644 --- a/drivers/input/joystick/iforce/iforce-packets.c +++ b/drivers/input/joystick/iforce/iforce-packets.c | |||
@@ -246,13 +246,12 @@ void iforce_process_packet(struct iforce *iforce, u16 cmd, unsigned char *data) | |||
246 | 246 | ||
247 | int iforce_get_id_packet(struct iforce *iforce, char *packet) | 247 | int iforce_get_id_packet(struct iforce *iforce, char *packet) |
248 | { | 248 | { |
249 | int status; | ||
250 | |||
251 | switch (iforce->bus) { | 249 | switch (iforce->bus) { |
252 | 250 | ||
253 | case IFORCE_USB: | 251 | case IFORCE_USB: { |
254 | |||
255 | #ifdef CONFIG_JOYSTICK_IFORCE_USB | 252 | #ifdef CONFIG_JOYSTICK_IFORCE_USB |
253 | int status; | ||
254 | |||
256 | iforce->cr.bRequest = packet[0]; | 255 | iforce->cr.bRequest = packet[0]; |
257 | iforce->ctrl->dev = iforce->usbdev; | 256 | iforce->ctrl->dev = iforce->usbdev; |
258 | 257 | ||
@@ -273,6 +272,7 @@ int iforce_get_id_packet(struct iforce *iforce, char *packet) | |||
273 | #else | 272 | #else |
274 | dbg("iforce_get_id_packet: iforce->bus = USB!"); | 273 | dbg("iforce_get_id_packet: iforce->bus = USB!"); |
275 | #endif | 274 | #endif |
275 | } | ||
276 | break; | 276 | break; |
277 | 277 | ||
278 | case IFORCE_232: | 278 | case IFORCE_232: |
diff --git a/drivers/input/keyboard/gpio_keys.c b/drivers/input/keyboard/gpio_keys.c index 739212252b09..f0b22b8b2769 100644 --- a/drivers/input/keyboard/gpio_keys.c +++ b/drivers/input/keyboard/gpio_keys.c | |||
@@ -22,7 +22,6 @@ | |||
22 | #include <linux/delay.h> | 22 | #include <linux/delay.h> |
23 | #include <linux/platform_device.h> | 23 | #include <linux/platform_device.h> |
24 | #include <linux/input.h> | 24 | #include <linux/input.h> |
25 | #include <linux/irq.h> | ||
26 | #include <linux/gpio_keys.h> | 25 | #include <linux/gpio_keys.h> |
27 | 26 | ||
28 | #include <asm/gpio.h> | 27 | #include <asm/gpio.h> |
diff --git a/drivers/input/mouse/touchkit_ps2.h b/drivers/input/mouse/touchkit_ps2.h index 61e9dfd8419f..8a0dd3574aef 100644 --- a/drivers/input/mouse/touchkit_ps2.h +++ b/drivers/input/mouse/touchkit_ps2.h | |||
@@ -15,7 +15,8 @@ | |||
15 | #ifdef CONFIG_MOUSE_PS2_TOUCHKIT | 15 | #ifdef CONFIG_MOUSE_PS2_TOUCHKIT |
16 | int touchkit_ps2_detect(struct psmouse *psmouse, int set_properties); | 16 | int touchkit_ps2_detect(struct psmouse *psmouse, int set_properties); |
17 | #else | 17 | #else |
18 | inline int touchkit_ps2_detect(struct psmouse *psmouse, int set_properties) | 18 | static inline int touchkit_ps2_detect(struct psmouse *psmouse, |
19 | int set_properties) | ||
19 | { | 20 | { |
20 | return -ENOSYS; | 21 | return -ENOSYS; |
21 | } | 22 | } |
diff --git a/drivers/input/serio/gscps2.c b/drivers/input/serio/gscps2.c index 74f14e097789..3e99df6be084 100644 --- a/drivers/input/serio/gscps2.c +++ b/drivers/input/serio/gscps2.c | |||
@@ -340,8 +340,8 @@ static int __init gscps2_probe(struct parisc_device *dev) | |||
340 | if (dev->id.sversion == 0x96) | 340 | if (dev->id.sversion == 0x96) |
341 | hpa += GSC_DINO_OFFSET; | 341 | hpa += GSC_DINO_OFFSET; |
342 | 342 | ||
343 | ps2port = kmalloc(sizeof(struct gscps2port), GFP_KERNEL); | 343 | ps2port = kzalloc(sizeof(struct gscps2port), GFP_KERNEL); |
344 | serio = kmalloc(sizeof(struct serio), GFP_KERNEL); | 344 | serio = kzalloc(sizeof(struct serio), GFP_KERNEL); |
345 | if (!ps2port || !serio) { | 345 | if (!ps2port || !serio) { |
346 | ret = -ENOMEM; | 346 | ret = -ENOMEM; |
347 | goto fail_nomem; | 347 | goto fail_nomem; |
@@ -349,8 +349,6 @@ static int __init gscps2_probe(struct parisc_device *dev) | |||
349 | 349 | ||
350 | dev_set_drvdata(&dev->dev, ps2port); | 350 | dev_set_drvdata(&dev->dev, ps2port); |
351 | 351 | ||
352 | memset(ps2port, 0, sizeof(struct gscps2port)); | ||
353 | memset(serio, 0, sizeof(struct serio)); | ||
354 | ps2port->port = serio; | 352 | ps2port->port = serio; |
355 | ps2port->padev = dev; | 353 | ps2port->padev = dev; |
356 | ps2port->addr = ioremap_nocache(hpa, GSC_STATUS + 4); | 354 | ps2port->addr = ioremap_nocache(hpa, GSC_STATUS + 4); |
diff --git a/drivers/input/serio/i8042.c b/drivers/input/serio/i8042.c index 3888dc307e0c..06b05dd22485 100644 --- a/drivers/input/serio/i8042.c +++ b/drivers/input/serio/i8042.c | |||
@@ -512,6 +512,7 @@ static irqreturn_t __devinit i8042_aux_test_irq(int irq, void *dev_id) | |||
512 | { | 512 | { |
513 | unsigned long flags; | 513 | unsigned long flags; |
514 | unsigned char str, data; | 514 | unsigned char str, data; |
515 | int ret = 0; | ||
515 | 516 | ||
516 | spin_lock_irqsave(&i8042_lock, flags); | 517 | spin_lock_irqsave(&i8042_lock, flags); |
517 | str = i8042_read_status(); | 518 | str = i8042_read_status(); |
@@ -520,10 +521,11 @@ static irqreturn_t __devinit i8042_aux_test_irq(int irq, void *dev_id) | |||
520 | if (i8042_irq_being_tested && | 521 | if (i8042_irq_being_tested && |
521 | data == 0xa5 && (str & I8042_STR_AUXDATA)) | 522 | data == 0xa5 && (str & I8042_STR_AUXDATA)) |
522 | complete(&i8042_aux_irq_delivered); | 523 | complete(&i8042_aux_irq_delivered); |
524 | ret = 1; | ||
523 | } | 525 | } |
524 | spin_unlock_irqrestore(&i8042_lock, flags); | 526 | spin_unlock_irqrestore(&i8042_lock, flags); |
525 | 527 | ||
526 | return IRQ_HANDLED; | 528 | return IRQ_RETVAL(ret); |
527 | } | 529 | } |
528 | 530 | ||
529 | /* | 531 | /* |