aboutsummaryrefslogtreecommitdiffstats
path: root/drivers
diff options
context:
space:
mode:
authorAdrian Bunk <bunk@stusta.de>2005-11-21 17:32:14 -0500
committerJody McIntyre <scjody@modernduck.com>2005-11-21 17:32:14 -0500
commitd734f92b0dc4c04daa2e0106354972cbbc2e0fbe (patch)
treec0eaa2ea898f5acc05d08bbe1a2914ed4aac8cfc /drivers
parent977545e35289b13981614a57fd6c9b82d55e3b4a (diff)
drivers/ieee1394/raw1394.c: fix a NULL pointer
The coverity checker spotted that this was a NULL pointer dereference in the "if (copy_from_user(...))" case since the next step is to kfree(cache->filled_head). There's no need to free cache at this point, and it's getting free'd later. Signed-off-by: Adrian Bunk <bunk@stusta.de> Signed-off-by: Jody McIntyre <scjody@modernduck.com>
Diffstat (limited to 'drivers')
-rw-r--r--drivers/ieee1394/raw1394.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/ieee1394/raw1394.c b/drivers/ieee1394/raw1394.c
index 0278dc5d5ef9..99b2ce15db83 100644
--- a/drivers/ieee1394/raw1394.c
+++ b/drivers/ieee1394/raw1394.c
@@ -2131,7 +2131,6 @@ static int modify_config_rom(struct file_info *fi, struct pending_request *req)
2131 req->req.length)) { 2131 req->req.length)) {
2132 csr1212_release_keyval(fi->csr1212_dirs[dr]); 2132 csr1212_release_keyval(fi->csr1212_dirs[dr]);
2133 fi->csr1212_dirs[dr] = NULL; 2133 fi->csr1212_dirs[dr] = NULL;
2134 CSR1212_FREE(cache);
2135 ret = -EFAULT; 2134 ret = -EFAULT;
2136 } else { 2135 } else {
2137 cache->len = req->req.length; 2136 cache->len = req->req.length;