aboutsummaryrefslogtreecommitdiffstats
path: root/drivers
diff options
context:
space:
mode:
authorGreg Kroah-Hartman <gregkh@suse.de>2009-03-10 23:42:55 -0400
committerGreg Kroah-Hartman <gregkh@suse.de>2009-03-17 17:01:28 -0400
commit5b10916ea0a62920204517e1c4ce14560b4f96ab (patch)
treec119039aa73e1b47e07b1857d6cfa2efc11adad6 /drivers
parentee568b25ee9e160b32d1aef73d8b2ee9c05d34db (diff)
USB: usbtmc: fix stupid bug in open()
open() will never succeed, as we always return -ENODEV. Fix this obvious bug. Thanks to Jouni Ryno for reporting it. Reported-by: Jouni Ryno <Jouni.Ryno@fmi.fi> Cc: stable <stable@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers')
-rw-r--r--drivers/usb/class/usbtmc.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/usb/class/usbtmc.c b/drivers/usb/class/usbtmc.c
index 0f5c05f6f9df..895a09839001 100644
--- a/drivers/usb/class/usbtmc.c
+++ b/drivers/usb/class/usbtmc.c
@@ -106,12 +106,13 @@ static int usbtmc_open(struct inode *inode, struct file *filp)
106{ 106{
107 struct usb_interface *intf; 107 struct usb_interface *intf;
108 struct usbtmc_device_data *data; 108 struct usbtmc_device_data *data;
109 int retval = -ENODEV; 109 int retval = 0;
110 110
111 intf = usb_find_interface(&usbtmc_driver, iminor(inode)); 111 intf = usb_find_interface(&usbtmc_driver, iminor(inode));
112 if (!intf) { 112 if (!intf) {
113 printk(KERN_ERR KBUILD_MODNAME 113 printk(KERN_ERR KBUILD_MODNAME
114 ": can not find device for minor %d", iminor(inode)); 114 ": can not find device for minor %d", iminor(inode));
115 retval = -ENODEV;
115 goto exit; 116 goto exit;
116 } 117 }
117 118